From: Konrad Sztyber <konrad.sztyber@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: <dev@dpdk.org>, Chenbo Xia <chenbox@nvidia.com>,
Nipun Gupta <nipun.gupta@amd.com>,
Peng Zhang <peng.zhang@corigine.com>,
Long Wu <long.wu@corigine.com>, Zerun Fu <zerun.fu@corigine.com>,
Chaoyong He <chaoyong.he@corigine.com>
Subject: Re: [PATCH] bus/pci: don't open uio device in secondary process
Date: Wed, 9 Oct 2024 12:11:32 +0200 [thread overview]
Message-ID: <e76395a1-7d4b-41d8-8614-50a3953e49c5@intel.com> (raw)
In-Reply-To: <20241007104918.463c9adf@hermes.local>
On 10/7/24 19:49, Stephen Hemminger wrote:
> On Wed, 28 Aug 2024 12:40:02 +0200
> Konrad Sztyber <konrad.sztyber@intel.com> wrote:
>
>> The uio_pci_generic driver clears the bus master bit when the device
>> file is closed. So, when the secondary process terminates after probing
>> a device, that device becomes unusable in the primary process.
>>
>> To avoid that, the device file is now opened only in the primary
>> process. The commit that introduced this regression, 847d78fb95
>> ("bus/pci: fix FD in secondary process"), only mentioned enabling access
>> to config space from secondary process, which still works, as it doesn't
>> rely on the device file.
>>
>> Fixes: 847d78fb95 ("bus/pci: fix FD in secondary process")
>>
>> Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
>
> Wouldn't this break use of interrupts in the secondary process?
Yes, it will. But I don't think we can support interrupts in the
secondary process *and*, at the same time, keep the device usable in the
primary process when secondary terminates. Maybe we could pass the fd
via SCM_RIGHTS? But I don't know if that results in the same struct file
being used by both processes.
> The patch does need the minor fix of the comment style.
> So resubmit
I already did, see:
https://inbox.dpdk.org/dev/20240829085724.270041-1-konrad.sztyber@intel.com
next prev parent reply other threads:[~2024-10-09 10:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-28 10:40 Konrad Sztyber
2024-08-29 5:53 ` Chaoyong He
2024-08-29 8:06 ` Chenbo Xia
2024-08-29 8:57 ` [PATCH v2] " Konrad Sztyber
2024-08-30 3:48 ` Chenbo Xia
2024-10-11 11:15 ` [PATCH v3] " Konrad Sztyber
2024-10-24 9:05 ` David Marchand
2024-11-19 10:39 ` Konrad Sztyber
2024-10-07 17:49 ` [PATCH] " Stephen Hemminger
2024-10-09 10:11 ` Konrad Sztyber [this message]
2024-10-09 15:12 ` Stephen Hemminger
2024-10-11 6:38 ` Konrad Sztyber
2024-10-11 6:46 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e76395a1-7d4b-41d8-8614-50a3953e49c5@intel.com \
--to=konrad.sztyber@intel.com \
--cc=chaoyong.he@corigine.com \
--cc=chenbox@nvidia.com \
--cc=dev@dpdk.org \
--cc=long.wu@corigine.com \
--cc=nipun.gupta@amd.com \
--cc=peng.zhang@corigine.com \
--cc=stephen@networkplumber.org \
--cc=zerun.fu@corigine.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).