From: "Juraj Linkeš" <juraj.linkes@pantheon.tech>
To: Jeremy Spewock <jspewock@iol.unh.edu>,
Nicholas Pratte <npratte@iol.unh.edu>
Cc: probb@iol.unh.edu, dmarx@iol.unh.edu, luca.vizzarro@arm.com,
yoan.picchi@foss.arm.com, Honnappa.Nagarahalli@arm.com,
paul.szczepanek@arm.com, dev@dpdk.org
Subject: Re: [RFC PATCH v3 1/2] dts: add port config mtu options to testpmd shell
Date: Thu, 22 Aug 2024 11:14:28 +0200 [thread overview]
Message-ID: <e76d490e-9464-437e-a19e-edd4a1e03a1d@pantheon.tech> (raw)
In-Reply-To: <CAAA20UQEu=Jf9f6nn2a9CBUUyfMyEkAvzR4xJKB6sV-4nb=pmg@mail.gmail.com>
>> + def configure_port_mtu_all(self, mtu_length: int) -> None:
>> + """Set the MTU length on all designated ports.
>> +
>> + Args:
>> + mtu_length: The MTU length to be set on all ports.
>> + """
>> + for port in self.show_port_info_all():
>> + self.send_command(f"port config mtu {port.id} {mtu_length}")
There's a patch in my capabilities series [0] that could be use here.
I'll create a standalone patch from it.
[0]
https://patches.dpdk.org/project/dpdk/patch/20240821145315.97974-8-juraj.linkes@pantheon.tech/
>> +
>> + def close(self) -> None:
>
> This looks like something that went wrong in the merge, this method is
> called _close on main and that is the one that
> SingleActiveIntactiveShells use to properly close.
>
>> """Overrides :meth:`~.interactive_shell.close`."""
>> self.stop()
>> self.send_command("quit", "Bye...")
>> --
>> 2.44.0
>>
> [1] https://patchwork.dpdk.org/project/dpdk/patch/20240709175341.183888-2-jspewock@iol.unh.edu/
These two are basically the same patch. Let's coordinate this and create
one standalone patch that will be used for all three patches (I'm
counting my capabilities patch as well here).
next prev parent reply other threads:[~2024-08-22 9:14 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-24 18:36 [RFC PATCH 0/1] Initial Implementation For Jumbo Frames Nicholas Pratte
2024-05-24 18:36 ` [RFC PATCH] Initial Implementation For Jumbo Frames Test Suite Nicholas Pratte
2024-07-26 14:09 ` [RFC PATCH v3 0/2] Initial Implementation For Jumbo Frames Nicholas Pratte
2024-06-21 21:13 ` [RFC PATCH v2 0/1] " Nicholas Pratte
2024-06-21 21:19 ` [RFC PATCH v2] Initial Implementation For Jumbo Frames Test Suite Nicholas Pratte
2024-06-21 22:18 ` Stephen Hemminger
2024-06-21 23:54 ` Honnappa Nagarahalli
2024-06-25 19:57 ` Nicholas Pratte
2024-06-25 21:57 ` Thomas Monjalon
2024-07-01 16:45 ` Nicholas Pratte
2024-06-25 23:49 ` Stephen Hemminger
2024-07-26 14:13 ` [RFC PATCH v3 0/2] Initial Implementation For Jumbo Frames Nicholas Pratte
2024-07-26 14:13 ` [RFC PATCH v3 1/2] dts: add port config mtu options to testpmd shell Nicholas Pratte
2024-08-02 19:54 ` Jeremy Spewock
2024-08-22 9:14 ` Juraj Linkeš [this message]
2024-07-26 14:13 ` [RFC PATCH v3 2/2] dts: Initial Implementation For Jumbo Frames Test Suite Nicholas Pratte
2024-08-02 19:54 ` Jeremy Spewock
2024-08-28 9:52 ` Alex Chapman
2024-08-29 19:04 ` Nicholas Pratte
2024-09-19 15:54 ` [RFC PATCH v3 0/2] Initial Implementation For Jumbo Frames Alex Chapman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e76d490e-9464-437e-a19e-edd4a1e03a1d@pantheon.tech \
--to=juraj.linkes@pantheon.tech \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=dev@dpdk.org \
--cc=dmarx@iol.unh.edu \
--cc=jspewock@iol.unh.edu \
--cc=luca.vizzarro@arm.com \
--cc=npratte@iol.unh.edu \
--cc=paul.szczepanek@arm.com \
--cc=probb@iol.unh.edu \
--cc=yoan.picchi@foss.arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).