From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C602B45844; Thu, 22 Aug 2024 11:14:32 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9113642E6E; Thu, 22 Aug 2024 11:14:32 +0200 (CEST) Received: from mail-ej1-f44.google.com (mail-ej1-f44.google.com [209.85.218.44]) by mails.dpdk.org (Postfix) with ESMTP id 73D3C42E66 for ; Thu, 22 Aug 2024 11:14:30 +0200 (CEST) Received: by mail-ej1-f44.google.com with SMTP id a640c23a62f3a-a8666734767so73303466b.1 for ; Thu, 22 Aug 2024 02:14:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pantheon.tech; s=google; t=1724318070; x=1724922870; darn=dpdk.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=79vNPHb7i5QxLEhxPMT5jg2+EnAAH9F1cbtsMI8hDYo=; b=cRbQdf90Ujz6G59YaxpQfOcHBF+2XD2KzxhsU0H09c9FaWcEuZ8388GyIpYQN7XlNL FS7KoA4yL5F7EEZCAzD4gs6CLTIZw4tk16Cy0Q4Y2jddj9t3XC6Ht8NQw7WY8cfCfAJO X1iI5x2xtHEyqI2/8AH5kC4P+oYrqVfHqkldhRkCDn5whFHH7xM+oiBPa8AH7YaVV7T6 QuBy1ge6r0Kya2D+X3Jh4GWeSG600YF2pkXssErKOTfXqIUZzwNgku9PWox97o17jtKB ZriN1QT4UySIaL3eNlCUowvkcBRjO58ifhbnOobjU6Z7bWGFUnu7GPy4BlLbnsm3UQT7 ncIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724318070; x=1724922870; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=79vNPHb7i5QxLEhxPMT5jg2+EnAAH9F1cbtsMI8hDYo=; b=F9sSQC/GG52/QV/gmUTDvaV2Xub6kIq8xXgHhdemhmqDA4Zg9AZ/XaaWRa4ni+qdsq RYwt+/DG/JoG/f3makViZGvFaGX2XTZvOywHoqn4+MGt03WZ365NuN2Q2Fk13G9LbqP8 /l9ht3M0UzNOv6A/d9KJmAwcHJKo1aZswYkxZGQhUkXZHbcPRWW4J7gbgTeJEPPEnU0H +4yVeo7EDX81bBtfsUNZbzTSKWJCkqHkRPQaiGd9jUTksF/JoVGY8voAbSUGO6QDLKfW K/8lbgfiMDozh4MDAaXnc0NStxFlru3N05ej3MwQ2J/5EmsfPNFcPeuu5n2E36gldiha 3avw== X-Forwarded-Encrypted: i=1; AJvYcCUY7MYnOhR65xy546BMNNfeEDkD0jaZxVC+YVCJujQ/KwDIsmEjKEps+p9PDtlZUIT6WUk=@dpdk.org X-Gm-Message-State: AOJu0YySexfiQ9ahOKlQb3Tu7FuFcaHOEUx+59hm8wroc5yWZkgHMIwI dpwY671Ol9utnExHvSTUKfMtvQN2DzqTUGPlQIrFbVhxVkYX3zsTZpY5ya9+HKo= X-Google-Smtp-Source: AGHT+IENwh0Mo8O/a4p0xBCcgH8VdeFYUndM01iCEeNoc6ziJGLV59zUlfC+80uFjCY1IGiIQOEK+Q== X-Received: by 2002:a17:907:1b05:b0:a86:6d49:c507 with SMTP id a640c23a62f3a-a866f709316mr353621966b.49.1724318069850; Thu, 22 Aug 2024 02:14:29 -0700 (PDT) Received: from [192.168.200.22] ([84.245.121.236]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a868f223530sm90040066b.42.2024.08.22.02.14.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 Aug 2024 02:14:29 -0700 (PDT) Message-ID: Date: Thu, 22 Aug 2024 11:14:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH v3 1/2] dts: add port config mtu options to testpmd shell To: Jeremy Spewock , Nicholas Pratte Cc: probb@iol.unh.edu, dmarx@iol.unh.edu, luca.vizzarro@arm.com, yoan.picchi@foss.arm.com, Honnappa.Nagarahalli@arm.com, paul.szczepanek@arm.com, dev@dpdk.org References: <20240524183604.6925-1-npratte@iol.unh.edu> <20240726141307.14410-1-npratte@iol.unh.edu> <20240726141307.14410-2-npratte@iol.unh.edu> Content-Language: en-US From: =?UTF-8?Q?Juraj_Linke=C5=A1?= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org >> + def configure_port_mtu_all(self, mtu_length: int) -> None: >> + """Set the MTU length on all designated ports. >> + >> + Args: >> + mtu_length: The MTU length to be set on all ports. >> + """ >> + for port in self.show_port_info_all(): >> + self.send_command(f"port config mtu {port.id} {mtu_length}") There's a patch in my capabilities series [0] that could be use here. I'll create a standalone patch from it. [0] https://patches.dpdk.org/project/dpdk/patch/20240821145315.97974-8-juraj.linkes@pantheon.tech/ >> + >> + def close(self) -> None: > > This looks like something that went wrong in the merge, this method is > called _close on main and that is the one that > SingleActiveIntactiveShells use to properly close. > >> """Overrides :meth:`~.interactive_shell.close`.""" >> self.stop() >> self.send_command("quit", "Bye...") >> -- >> 2.44.0 >> > [1] https://patchwork.dpdk.org/project/dpdk/patch/20240709175341.183888-2-jspewock@iol.unh.edu/ These two are basically the same patch. Let's coordinate this and create one standalone patch that will be used for all three patches (I'm counting my capabilities patch as well here).