From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 161F745561; Wed, 3 Jul 2024 14:03:05 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E60AB40E7C; Wed, 3 Jul 2024 14:03:04 +0200 (CEST) Received: from DB3PR0202CU003.outbound.protection.outlook.com (mail-northeuropeazon11011066.outbound.protection.outlook.com [52.101.65.66]) by mails.dpdk.org (Postfix) with ESMTP id 7957C4029E for ; Wed, 3 Jul 2024 14:03:03 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OWe+e5Ptybp7LA8/VNGic2EDozlHFM2mbyoCO7VUqbvXkG2RB6vSrdCNyMv+U/43eSXWdorzOg5l615F6uJyTaDKE7r94o7h6aSqRf4XIK1+BQ+S6QfIIi6uQe3icOYQL4hDZlt9rHtIYGc9g04OB8WwBXdUSXHujFGqlA42n1yrLSZljRjyL7z/glbUioJUTh2/rEc7dEChviajWsaJqq/BYI3ujMHjkB+5Sx2hKIQF6yM6BrhB6p6QKGHixC1WVvv4Kwf2QxHCT95tsik9arWnMUQVZ/ihVk3yAg8Cl0JKDe+xKg+ECDzziGdvxnvyZi6K5DRhUpo0cJK7pGvCUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=h9d2jyugt17K5XPuXuROI9E/pB+v6ToGCaPxNNX3PfU=; b=S0e5VCK/tKNIw7Yq0+HYX0uHKhDqadtlbIhzCgWCdB3cWksnTVgctoG7iqadf492/z248YdN8FnVJ7kHhj2ZRWVZwYOOzq79yNJGRrNRQ7ugnb369o7+dvv9xfReZDL+w/R0fTgmGmX085Jt2ot1sQKoyyN/QCWUxjLUcnIB4JQvSB4t0aDCVtPzI2R3AtpYYHX+ZbGbabQuizANh9y/945sy1GQeZbz3qpwh3KNr+qIirfmiQwh/hCDs9WYUIxkOz+9C1hkNkBTJEeIU30byu1zqv5MD++hm765fBauRDxrB6iKBVaFUUW+dZPA9gBMUKucXKZVMlxmGLPBRYMf/Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=h9d2jyugt17K5XPuXuROI9E/pB+v6ToGCaPxNNX3PfU=; b=JYjWUllVV3FLy455ng6KR8maQOtZbfSP2YLD3DBZZ767SkN3HjScPMBYfwRVRlcc+aaMA2C5HNxZP+xk7yOwN1DJsztBrY25k+osd8IIP6W6nIh8LvIBzzrTAsX0LA/HElbJqT/lleHUPqTqUsy4VKjgX7kN9tj5JRuHKnLuqOA= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB9328.eurprd04.prod.outlook.com (2603:10a6:102:2b6::15) by AS5PR04MB9875.eurprd04.prod.outlook.com (2603:10a6:20b:652::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7741.23; Wed, 3 Jul 2024 12:02:57 +0000 Received: from PAXPR04MB9328.eurprd04.prod.outlook.com ([fe80::367:d59:375:fb87]) by PAXPR04MB9328.eurprd04.prod.outlook.com ([fe80::367:d59:375:fb87%4]) with mapi id 15.20.7719.036; Wed, 3 Jul 2024 12:02:57 +0000 Message-ID: Date: Wed, 3 Jul 2024 17:32:52 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH v3 1/3] drivers: replace printf with log macros Content-Language: en-US To: David Marchand , Hemant Agrawal Cc: dev@dpdk.org, thomas@monjalon.net, stephen@networkplumber.org References: <20240702104013.3813272-1-hemant.agrawal@nxp.com> <20240702130856.3927348-1-hemant.agrawal@nxp.com> From: Hemant Agrawal In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: SI1PR02CA0019.apcprd02.prod.outlook.com (2603:1096:4:1f4::15) To PAXPR04MB9328.eurprd04.prod.outlook.com (2603:10a6:102:2b6::15) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9328:EE_|AS5PR04MB9875:EE_ X-MS-Office365-Filtering-Correlation-Id: 8cb7ee9d-3c26-4dd5-3c17-08dc9b581389 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?U2c3YUdzSjRKbTNmUWFnL2hiT3QwcEVCVGNyU1BTUjJiVDNzQTZSZ1N0eXNX?= =?utf-8?B?VWg1K3UzT0ZDSjVjK1ZCeENYcjZnWDlKQ2E1UXpLSDlyWVpGcldNUmN1TW9s?= =?utf-8?B?WElMZnRyaFhhSjZDN0xFNXVTMmxSbXQvbGVFNEdNR2J0OU4wbzRORXRKMEhy?= =?utf-8?B?dTdVV2lxazE2V0U2dWdIaGhLZnFTcUtHMDFnZzVxRWxPSG0wRWxMN2l3NHky?= =?utf-8?B?RS9YaW5ybEdwblpXYkdWWnRkejBUd1gyL1NWV0lvYzc5OEN4azhOems2eFc3?= =?utf-8?B?NVJmT1VtVU1zd2NmK3pETUhML2RKMFNkbWdFdVY0OERWbHpzQi8wNjFZemhB?= =?utf-8?B?VG1sOFRibHNXQ3N1cStiVStaMGVydVhrTlNzMFJCdDBRUEt1ME01SVRwd294?= =?utf-8?B?VUdNOS9FTjNOdG1oNHpPNEw2WWNvSmxJUUtmeDhQalBPY3prRHZpdDNPU2wz?= =?utf-8?B?WExyeUlKYkhZZklzR1JzcWJuYTBob1FBRGV0TTB0YnJSczdlOCtpbU55WCtp?= =?utf-8?B?NWlqVmJVc0RMREduQ2NmM0xUVkUzTndvMkRPQmFodlhBcFRVTW80K2YvWFRP?= =?utf-8?B?MmVXak1sYkx5YXJwdmhwbDg2S3FPc3FJZis4c2RCL3VYTEhDR0h3akk4enNy?= =?utf-8?B?MXlFZGRFRURHOFVITjBkbHIzN3lTS0JBQWQxQ1Y3Y0k2UWdqQ0Z0OE11d0g1?= =?utf-8?B?dDRnbjA4RTZ2V2UvWTRBem9yVTZ6S2lIWVlkSG80UTZnUkVZL0lFVnB6V1VZ?= =?utf-8?B?MTVUQ2xwTmhtMjRQYUVxT012b2NjZHR0OHU2R0p5TUgrNGlGTWZ1aFV0RW1n?= =?utf-8?B?bWdOMjkrVHRWdjI5OEJPZTRyK2ZBaXpRcDZWUmVld0JWRlIwL05CV1JJNWZk?= =?utf-8?B?YkxnZjlnT3o1V0hpTk0yc0svdTVNVlBaTjJuYTMxOWxMaC9xbk9RbnpQZ1lF?= =?utf-8?B?OVNVWnZnbWpJbTJ5UmlzQkJkR0xJUXNicTcrNnk3OTVSdjN3dGtSTEdTZDdh?= =?utf-8?B?NWNtT1ZGSmMzeTJvMmhzSnBWNGxJNGtOaWdFajIvVDJodG16enZoL3hjRGlN?= =?utf-8?B?dHZWb3I0ZEVwQXRqckduV1dKUmtTWGp6ckVKWkFmSEtHZXN4VEJzakIzUXJZ?= =?utf-8?B?VWNOdURicUlQeERGQ0I1S1RadjNzVmRVQXZ2dGNTQ290SlF3MjN3RkxBZzJn?= =?utf-8?B?T21tRzBRVE82RlRHSlovNUlCVkRmUXhBc0RpVGFMaGFsUnFYYklaNVpNUjNY?= =?utf-8?B?V1prT2xUMDRwVVcrQzFUN1JRUzZZSllQUkF1WFQ2WUg2YzVMVTJ4TXJSbld6?= =?utf-8?B?YVZHakp1VU9URFdwUGYrVThMdTNObWZCTlQwYnVSYVRBcVdvQlJYOWhRWDcx?= =?utf-8?B?RWd3MVVkc1pHK3ZCWlFrSjdWMEFNeHRCR1I3eXQ4b3hFM1htNldLVjBxWlor?= =?utf-8?B?emkrZ2tKTFpMUXRUWWRWVjNYYkZZQ0pjK3hicFBXZ29zallaTXJMK2lZUWpj?= =?utf-8?B?SzQxNEh4OTVNT29NSUswWFBmSko1RXFRZERtSGJma0VPa2VrTEJUVUpKdWNn?= =?utf-8?B?Q0kyUlhJdWRHc1dYd3l2bStoV1FGYzIweStuRFp1Mm9jYzJZd0NpSWtGVlRB?= =?utf-8?B?S2xuWHJpa0VuUCs2czFJZ1ZwYXcvTGhmbkVIVGhTMldObStiRjlqdWM4VkVl?= =?utf-8?B?RksxcUd6QzRYM1JpdjI1TUJjVFRsQm5UUUtraUl2SE9QbzMxZUFQclZQQXFt?= =?utf-8?B?YUZtL3Q5WHdjVUdkRno5dWdMWUlZWGl5M3cxK0NTZTlONUhmeXFyMFNQOWxC?= =?utf-8?B?Z1VFZG1pbXU3SDVuRFFWQT09?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PAXPR04MB9328.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(1800799024)(376014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cVk4MFZ3OGhNTFhyTEJVNXBkcVAwZXhmRzllUS9yUDVrZzBUVUZUNit4N0dy?= =?utf-8?B?WHhBNEtmN0k1NWlpS25ETExzVkI1NkdaMzgzZVQ1anlQc3hOM2tIdURQME9n?= =?utf-8?B?alEyMzJkaWpjb0NGemo4NDQ5bElJWU1aYUpjQitqSVVlMzRqZ0FjYTdrVmdR?= =?utf-8?B?dmk1ektHTkk0NFZkRXVkN2s5ZlhaMHRGbE9Wa2V0TTQ0VWovZGwrY1N0ZXI3?= =?utf-8?B?c3JDVXVVSDJ3QmdrWGlsSjBZUEg2a0NZZkNLRFRrb0wwUTJ1eFpmKzdyazNI?= =?utf-8?B?NFpuenRMNTVVcDdDNlBodVhROWg5RHpJcmJucERVeWRVc0UyK0Z2OG1yeElo?= =?utf-8?B?b3hyR3VJQzVjY0dlRGR3RUxhZTR2UC9XZWJJRjU2ajBHdVVRTFBaUGUyY2Zu?= =?utf-8?B?RWFGWDdFSmZhaGZxVTYxWDFrRFFSZFVBTjBuTTZqZStrbE1wWWZVZE90R3Rx?= =?utf-8?B?TGxCZk1sQ0R0cTd3VTZucEl2RENxOUMvcDlWK1pLbktManFqQm5IaTByVjlv?= =?utf-8?B?cnljWE1WZmZmWlU4aS9OTExoc24wL2NrK2I1anpkOXhnODBSUFQ0OUdsMWRr?= =?utf-8?B?eUQ1RUc3Q3NQVHQ2TmRnRnJRM0NWcThxNFdnbEtjd0NJVEhFb3lqWVJHbzRj?= =?utf-8?B?U2o1a0RzNjJZb2dXY0lob2RLQmkwUFN6SjZYK0ZVTlgrREhzV3hYMlpqQVhO?= =?utf-8?B?eGgrbEVnNVBGSHQzYjh4UGN5NUJON3pFeUNwRUNmYjlCb0pjNmRJTkw1Z01u?= =?utf-8?B?S3V1cnpHYk9YQkhSN2MySlRRTFQyQmRRejJ0RURmRFRvQWhITW90a0duY3pL?= =?utf-8?B?QmlKOFVCTEpCcW1WKy90UWxEdktSeWRra1FweURCZlVaSlVGYzByUnlIVVV5?= =?utf-8?B?NXJTdFpLKzR2T3VhQzRNZHdJNk0vTWRRQjhtLzFLb2plUFUrTjVDRTd0NlFK?= =?utf-8?B?cDY3alhNTXI0WnYrN0ZFVFVSbVBVMVp1bC9GM0NZOGJDVCtNV2ZEd2liNDJi?= =?utf-8?B?NG9vS1lMVWJzUFlVRnBWOGd0bEMyU3JCcXpFRlc2ck03T1hCRzRrTEw2Q1NC?= =?utf-8?B?MjhGaFFvazkzNm5HdFNhYTd2bTBsbWR1SnJjUTRyNVB1N3JmUE5xbTVhL0s3?= =?utf-8?B?Y0l2Wjg4TlMzMjc1bWlIODhQUXptU1V4b3BEdE9zNndUVnJkTzdYa2h6Y0Vh?= =?utf-8?B?cGNtN2NnNzhEd3QyaXh5emw5a1ljbitmZGEwT1VGMXhQWUl1dVl2NmtYc3lO?= =?utf-8?B?NzE3T044YXhjUTZtNEZMczVQK01xVmNXb2pOKzFhRStkWmozZ09RbzYrVEht?= =?utf-8?B?ZVhvSVk4VzBEMnZTT002SEU0dnZneFZSQit6c1BHVkZPZ1ZtNWJWOEpMOGVT?= =?utf-8?B?TDJYUlB0MXhmYVJ6a1B1c0dydWJFWnNsWlV6S2RyWHZJWFFTMVZuTE5kbE1t?= =?utf-8?B?TklPRENSaGliQnBUYzc4WGIyVnVTbHR6TjNIWWxwcVVCVFRSd0xOL3AvaVVZ?= =?utf-8?B?OE5rTWhHZkhKNDdFT0xNU3JzOWY2WC9WVlJTMTA2UGlENlh0dldoMFlLZXBm?= =?utf-8?B?clRaRWlibkw2clJVeERnK3crYU5KMXhMN0hZazNrRU93ZXRvYjV6ejlmZ3dx?= =?utf-8?B?bFp4b0tvVzE1NCtMMldkNXd4ZmM1c2FIWmt5dGt5VStvSUl0SnV6Mi93SnRr?= =?utf-8?B?aFNKYXJUWVpaV29VMzJOWUNBQkpIa000dHRLVWxHK3BEdEdGZzUrbDBMUkJT?= =?utf-8?B?bE10MmlvWHNiZlo4UmhEWGpSOUwyMzdxazVuRVNRaXdrWnd0b2dhQzFoK2l6?= =?utf-8?B?SjdzbGZJTW9YY1JRVm83TW5oWXdwWVd6OVlsYVp4aitiZWNJZmZzNkNFU0JS?= =?utf-8?B?VVFMRURTTmZLZlZobWgySXdGSVN0UXgwWUcyQW9YU3NSV1dxNzZmSmF1dGVl?= =?utf-8?B?UUhsQ0FvV0p6NUhLRTRIalFaOWh5Ni9HNkRRNFZ4RkxyOFNlbXpTcEdES2RP?= =?utf-8?B?WElFcktmd0EzaElOb2hIMDVOMkZxbHpuV1F0RDlidnJEVHVDMGVHeWw2Tjhm?= =?utf-8?B?T2ViT1M2ajBWUlQ1cU1GZk1nRTllNlVvN3UyeXNENFpidHN6MkFUTTI3OXFP?= =?utf-8?B?Ulp6ODZTZCt5bzFNNlg4WFRRSngrdW9GVEdPZWRQQ1ppaEZUbEIzWVJhVFdF?= =?utf-8?B?Wnc9PQ==?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8cb7ee9d-3c26-4dd5-3c17-08dc9b581389 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9328.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jul 2024 12:02:57.2307 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: YBquXQHXl9twASgyw9HjoN6VO5RCaJBS5KeKDi2WAj0+OY/0oeWLPBTPPdXaAQhXElnB7YPUpFSAXNzG5mLicA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS5PR04MB9875 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi David On 03-07-2024 16:11, David Marchand wrote: > Hello Hemant, > > On Tue, Jul 2, 2024 at 3:09 PM Hemant Agrawal wrote: > > [snip] > >> diff --git a/drivers/crypto/caam_jr/caam_jr.c b/drivers/crypto/caam_jr/caam_jr.c >> index 0fa70c978f..fb9ac9cb30 100644 >> --- a/drivers/crypto/caam_jr/caam_jr.c >> +++ b/drivers/crypto/caam_jr/caam_jr.c >> @@ -461,7 +461,7 @@ caam_jr_prep_cdb(struct caam_jr_session *ses) >> } >> >> #if CAAM_JR_DBG >> - SEC_DUMP_DESC(cdb->sh_desc); >> + SEC_DUMP_DESC(cdb->sh_desc, stdout); >> #endif > This hunk should go to next patch. will fix it in v4 >> cdb->sh_hdr.hi.field.idlen = shared_desc_len; > [snip] > >> diff --git a/drivers/net/dpaa/dpaa_ethdev.c b/drivers/net/dpaa/dpaa_ethdev.c >> index 935a4f2ada..bcd19f31fb 100644 >> --- a/drivers/net/dpaa/dpaa_ethdev.c >> +++ b/drivers/net/dpaa/dpaa_ethdev.c >> @@ -282,9 +282,9 @@ dpaa_eth_dev_configure(struct rte_eth_dev *dev) >> dpaa_interrupt_handler, >> (void *)dev); >> if (ret == EINVAL) >> - printf("Failed to enable interrupt: Not Supported\n"); >> + DPAA_PMD_ERR("Failed to enable interrupt: Not Supported\n"); >> else >> - printf("Failed to enable interrupt\n"); >> + DPAA_PMD_ERR("Failed to enable interrupt\n"); > DPAA_PMD_ERR appends a \n, so \n should be removed here. > > There are double \n in this driver prior to this patch, can you fix them too? > It is probably worth checking other NXP drivers on this topic. will fix this in v4 and for the time being I am fixing it for dpaa set of drivers in 2nd patch of this series. Rest will follow as a separate patch. > >> } >> dev->data->dev_conf.intr_conf.lsc = 0; >> dev->data->dev_flags &= ~RTE_ETH_DEV_INTR_LSC; >> @@ -340,7 +340,7 @@ dpaa_eth_dev_configure(struct rte_eth_dev *dev) >> dpaa_update_link_speed(__fif->node_name, speed, duplex); >> } else { >> /* Manual autoneg - custom advertisement speed. */ >> - printf("Custom Advertisement speeds not supported\n"); >> + DPAA_PMD_ERR("Custom Advertisement speeds not supported\n"); > Idem. ok > > >> } >> } >> > [snip] > >> diff --git a/drivers/net/dpaa/dpaa_rxtx.c b/drivers/net/dpaa/dpaa_rxtx.c >> index ce4f3d6c85..c2579d65ee 100644 >> --- a/drivers/net/dpaa/dpaa_rxtx.c >> +++ b/drivers/net/dpaa/dpaa_rxtx.c >> @@ -103,7 +103,7 @@ static void dpaa_display_frame_info(const struct qm_fd *fd, >> for (ii = 0; ii < fd->length20; ii++) { >> DISPLAY_PRINT("%02x ", ptr[ii]); >> if (((ii + 1) % 16) == 0) >> - printf("\n"); >> + DISPLAY_PRINT("\n"); >> } >> DISPLAY_PRINT("\n"); >> } > Indeed it is better to call this macro, but this macro is calling printf. > I am ok with the change as this is under a debug build cflag, but I > would prefer this debug code goes through rte_log in the future. > >