From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5815242BF2; Wed, 31 May 2023 16:18:18 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E04F440A89; Wed, 31 May 2023 16:18:17 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id BE00640A82 for ; Wed, 31 May 2023 16:18:16 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1685542696; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iiUKLgnMbuuakVZs79Zu3+9JY9LevSAfLrZ1ScBnD3M=; b=eGvvHloIq81o76w4X5Q+7/V4SW/34JgKIlkBXbHPDa7oiR8VZ1G6FNwo+3cnIOVcssLToe W/8x1qpZGAxKVqlWlcCQYv3yfRIzY5T5pF89jnGS4sMViK6doouxypVatFZ3rIrPbAtccw wqd4F+WWY8y7BlxYkLTJZtY6ik1JwzU= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-340-DHhZCuLSOQ6yu2HSI11owQ-1; Wed, 31 May 2023 10:18:14 -0400 X-MC-Unique: DHhZCuLSOQ6yu2HSI11owQ-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 686CE811E7C; Wed, 31 May 2023 14:18:14 +0000 (UTC) Received: from [10.39.208.19] (unknown [10.39.208.19]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7860F20296C6; Wed, 31 May 2023 14:18:13 +0000 (UTC) Message-ID: Date: Wed, 31 May 2023 16:18:12 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v3 4/4] vhost: add device op to offload the interrupt kick To: David Marchand Cc: Eelco Chaudron , chenbo.xia@intel.com, dev@dpdk.org References: <168431450017.558450.16680518469610688737.stgit@ebuild.local> <168431455219.558450.14986601389394385835.stgit@ebuild.local> From: Maxime Coquelin In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 5/31/23 16:12, David Marchand wrote: > Maxime, > > On Wed, May 17, 2023 at 11:09 AM Eelco Chaudron wrote: >> @@ -974,11 +994,8 @@ vhost_vring_call_packed(struct virtio_net *dev, struct vhost_virtqueue *vq) >> if (vhost_need_event(off, new, old)) >> kick = true; >> kick: >> - if (kick && vq->callfd >= 0) { >> - eventfd_write(vq->callfd, (eventfd_t)1); >> - if (dev->notify_ops->guest_notified) >> - dev->notify_ops->guest_notified(dev->vid); >> - } >> + if (kick && vq->callfd >= 0) >> + vhost_vring_inject_irq(dev, vq); > > Thinking again about the VDUSE series overlap... > > This hunk here is implicitely fixing an issue. > You addressed it in > https://patchwork.dpdk.org/project/dpdk/patch/20230525162551.70359-2-maxime.coquelin@redhat.com/ > > So I suggest you apply this patch of yours before Eelco patch 4. > This way, the fix backport will be trivial. > > Thanks David, this is indeed the best thing to do to ease backporting the fix to v22.11. Maxime