Re: [PATCH v4 2/2] ethdev: move driver interface functions to its own file

[Ferruh Yigit <ferruh.yigit@intel.com>]

On 2/11/2022 6:55 PM, Thomas Monjalon wrote:
> 11/02/2022 19:38, Ferruh Yigit:
>> ethdev has two interfaces, one interface between applications and
>> library, these APIs are declared in the ethdev.h public header.

will update file name as 'rte_ethdev.h'

>> Other interface is between drivers and library, these functions are
>> declared in ethdev_driver.h and marked as internal.
>>
>> But all functions are defined in rte_ethdev.c file. This patch moves
>> functions for drivers to its own file, ethdev_driver.c for cleanup, no
>> functional change in functions.
>>
>> Some public APIs and driver APIs call common internal functions, which
> 
> here
> 
>> were mostly static since both were in same file. To be able to move
>> driver APIs, common functions are moved into ethdev_private.c.
> 
> and there, "driver APIs" should be "driver helpers", right?
> 

I wasn't sure what to say them, I will update as "driver helpers"

>> (ethdev_private.c is used for functions that are internal to the library
>> and shared by multiple .c files in the ethdev library.)
>>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> 
> Acked-by: Thomas Monjalon <thomas@monjalon.net>
> 
>