From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D95B6A0C41; Wed, 15 Sep 2021 18:56:35 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C4DB84068F; Wed, 15 Sep 2021 18:56:35 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 5C7DC4014F for ; Wed, 15 Sep 2021 18:56:33 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10108"; a="222417446" X-IronPort-AV: E=Sophos;i="5.85,295,1624345200"; d="scan'208";a="222417446" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Sep 2021 09:56:32 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,295,1624345200"; d="scan'208";a="508878127" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga008.fm.intel.com with ESMTP; 15 Sep 2021 09:56:31 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 15 Sep 2021 09:56:31 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Wed, 15 Sep 2021 09:56:31 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.104) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Wed, 15 Sep 2021 09:56:31 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=npeAuJbN3APUd7mQGpAorUGCiN1l5vujjbVGXNCVJsDLu77ubHf/j/qH98y5EhjVy+cShdcdr5eCpvbL41aNTvklgmLKt3alFhrmgOInwZavttg09gtlsqtyiuJPjobNgplTMCO0YoPQ/hej5z/MStRfJRdnre4C2oorkNWTPBS1Tu6kA/QufoxrInCMl7VON32cqXNpPmkBjathbhcLvlNYmgLGIsm/mMEuYtmJiihLx0LRy+LRZwp0/YAMuLyg1HYl6OuRSyPZx2e16x6TkALvXMQY5UhnMdgVSUFobbF9gGvY/A0hsXToRZ82+eKXCj8tO4nL0lsWVjVcn8hxXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=TFD2PkjaEEsHgxyiuDC5xxzxtpOEsFO9lVCLgiNgXEs=; b=b1Yl99Lw011pZzjkXUsBIaLScmHt7QGYD4+WGwEWpQqGLBR7rjLmJsHO2EBhmaUXCn7hmdNLyP9fiKsvHDzx/f5pW9KOjY0EfTnP7o7FDD2bkgyY3wC4y4/rq+H6hOi5KuLV+/cvw5dRVlf0L482TEhC3z8LoYpr4wfPLEEekLIp9PO2FH1o9EUQ2P3McjF9s7DVJqoX6Ps4BZqGqO6jY4GuC1ep8B862giqbOBQvk3Zx8i06A4B8l1VLzX45hvqJtH6uYoLDDWhli2z2kCMqN4N0ESewq721Kmuefgb51r/uRiraaA+RhqE8rXRU/loTY/MKupae2Fmwc0JkqQspQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TFD2PkjaEEsHgxyiuDC5xxzxtpOEsFO9lVCLgiNgXEs=; b=V9qRjIDpGw/O0XD60X1CUEZDWVNuXv/yyDogcHk+JKufcPMkY8yysNXvgBcblacqv181758qwHCeoKQJz3ZCUPaz3VrK+GSn10dKUEpLiZealj8Oc+UzqVlhNIGi9d5bZ5pwnvlL24Vv2i1szpHnqquYOM9FQMEhKrxqx3RrDB0= Authentication-Results: ashroe.eu; dkim=none (message not signed) header.d=none;ashroe.eu; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB4887.namprd11.prod.outlook.com (2603:10b6:510:30::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4523.14; Wed, 15 Sep 2021 16:56:25 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc%5]) with mapi id 15.20.4500.019; Wed, 15 Sep 2021 16:56:25 +0000 To: Jiawen Wu , References: <20210908083758.312055-1-jiawenwu@trustnetic.com> <20210908083758.312055-20-jiawenwu@trustnetic.com> From: Ferruh Yigit CC: Ray Kinsella X-User: ferruhy Message-ID: Date: Wed, 15 Sep 2021 17:56:20 +0100 In-Reply-To: <20210908083758.312055-20-jiawenwu@trustnetic.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DB3PR08CA0013.eurprd08.prod.outlook.com (2603:10a6:8::26) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DB3PR08CA0013.eurprd08.prod.outlook.com (2603:10a6:8::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4523.14 via Frontend Transport; Wed, 15 Sep 2021 16:56:24 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e0c98a5c-6dfb-40c8-8a5c-08d97869c0e6 X-MS-TrafficTypeDiagnostic: PH0PR11MB4887: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4125; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bgJYwu+Zx2IbEeKHmKoMRsYEv3jw0+ePtBm8DvEbx/+DZwVBGccFjrLgNygbTr6TxCV15ZM8P+wcpHDXLa+IdT8BQxEHJ9r9Hos5vouwWI2l7NtqfXaAJJuUDos5UKLNrXfCFHVQWdKo7CLSPHijtoQ0w0Doov6VgeiY+CnlCr3lAFfBJ0nFf9iKx7Q/OtPpD4AuRNzPn52ybFf45/wp+bwPWRmI34UbXERPBXaoFbMuKCQgRxyAIL2lAvEahvhhCWR/FCRO5gpjImLgIyvvLWVwH99NkKrvfZirPJghqGr+VgHm9J1IP5yUW9doWrBl/CccMJP9ueVj9S3wcWJc1rje/ZDZsR3DAX8HzOM1JERIaG892TUwGajWWN6v19/9clKuKvDB2C41iIXN5cKl8WL53zEknmAIKnRcksd+mWTijXOiMP6P9pwTNKhFxLVOEIBaCXxvineZvZhcyZH36h586jKTdkQC8rpqZwyrb/DiGM/TLfafftGhDe59gxGLUNwAut9P6RQYhURJ7Z5XKopmg1mNEiTD9IR+JvjrdqVvVwDqGwQwbYizn+Eu7iME+lkfASnrvHklh90dmBumllsDfPlBQ+qRJD0zmBNeEIRprmrO+qBf4JqaZYb4Oc0LzfQ/WCRLRHNoHh66dvTi+i2D9kWMl40G+8dvnvv4keFQn94xP0Vc7O5JYW/YMIjIvD+f7pa0iF3017RtVW4yaA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(66946007)(66476007)(956004)(66556008)(2616005)(31696002)(86362001)(38100700002)(83380400001)(36756003)(8936002)(4744005)(2906002)(53546011)(15650500001)(8676002)(4326008)(5660300002)(26005)(186003)(316002)(31686004)(6486002)(6666004)(16576012)(44832011)(508600001)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?a1k2M2NTcFV4cGFldWhGNW5aYTlhc1ViaS83TElwcWZYcDR2MG5YSUhaamoz?= =?utf-8?B?MHUyT25BTjRucUVaejMyYWpHK0t2eCtIU0d3aWdJM3BOWTFxTXZpd0ZYNG1h?= =?utf-8?B?bjdtcXQ5WXh0WHU2Rk5rbGtaV1o3YWZHeE91WWdrS1czYnp5bnB0RjU4d2pZ?= =?utf-8?B?a3FERGNBaVQzekZmYmVIOWE5dHR1VkVwS0xyaFFuajU2L2sxVWZTdmZVNUlI?= =?utf-8?B?RWpxeW5KaTgyNkZjZlo1WGZsWnVXNzZ3SWsvcG5YbTAxQmpIT3BhVE50djlC?= =?utf-8?B?SmhKWkhzTElHblg3K0x3czZPbHI5NzNQL3lSTVdjbVlkUjJoSUExY3M2WkFn?= =?utf-8?B?S3F4M2NnMnd4SDlSNWQ3WmdES3VPeUNjeThQNE5WM3lCL2laWlJKbTRrNDFU?= =?utf-8?B?Zko1c1puK2laanFQQ3JLQXluMFZTeStjMlNheEVrWVB3S3d0QklzZUsyN2E5?= =?utf-8?B?VFJqeUZ1eFhQMWt0WG4vM2dLaEFmU0N4VWN3TzJybHJKaWp5TGRqckp4OFNr?= =?utf-8?B?ZDBiZkVWQmNUNklsSDVqKzd2VWhGRzJiQWlCUElEY0NpdnF2eWl1a2tzSUIr?= =?utf-8?B?ODNFWmRER0RVRit0aWwvenlDU2ZnTkVRWjB1NXQyNnJrdDVBTzRRdjJiUzVK?= =?utf-8?B?V0oxUDFNTkxNZHJmK3Y0K1ZYeDQ1Z3FGMmd2S2pPN0FOZnhqWUJjSGpxcVlS?= =?utf-8?B?d2wzbEcwZ1pidTJXelFudjNaZWovSHB6c3ZvVlJyUnUwbG93UFdnWDFjaERH?= =?utf-8?B?QXJuTnpQVmhRcmhFajJjL1B1NUhBdXpTbHRpLy9CV2Ixb0NJWGJWdEpVZ1Fo?= =?utf-8?B?NS9pRHozSWhxNGVwWUxXbnZ1dmRDTHBPWXVKb2dsOC9vZ3NTdE5lRkptK3hx?= =?utf-8?B?cERuNXdHWFdMcm8yV042Z0htTmp0ZkRZK2JXOVdpYmNnMDN1ZlBlSmQxeWJY?= =?utf-8?B?aE50M0p1RDZyR2FZdVNiamZ1NmdQZ3RvNU0xOUk1eFVvNEp3cGF0OEUxZGV3?= =?utf-8?B?S1NRbkFDMmNhSW42QXFIb2hnUER3bHRlV3FORkZ2d2ZkSnh3Y001QzFFekUy?= =?utf-8?B?TnBIaUJaNHdxbTQ0NDZqK1Q0MVA0MGYyR0xZaWEwME1GNGVxTzlxcE4vNkVw?= =?utf-8?B?RnJrM2ZoY2F1eUNWZ3BnUlZoem1rYXhKR21RUFFCVVRHd2sxS1Q0b09tRFJJ?= =?utf-8?B?Q3BtOWhlYUhPallaNUVqRkJIeldacU5WQTk1UlM1N3RXTHRqVkxTcmVZWWRV?= =?utf-8?B?NkNETndhSDVlanROUGdWRFJtWER2a2d2bjNLSDlPUFZReXZMZlh6NUlwdS82?= =?utf-8?B?cGRsK0t2ZVp4MUN4cEJnWkdvcm9WK0R5M1BnYWlDQTk3cnFaNk9taWJsS3BN?= =?utf-8?B?eFBKeUtPd3JUdnNFYWNIOXFOR0hucUg1RTkrTCtTemV3SGZTWUR3dnQweFFU?= =?utf-8?B?ZTVDUFdyTmxuaW44aHJqMytYWHl3UU1hNjg0Y2huTmlqbThaOExjWmNVaGNO?= =?utf-8?B?Yk55TUdaYlVjZWhwWWMyVTlYWnBGOS9NVkJIOVlDMlJHTDFHcWoyWjNEYU9M?= =?utf-8?B?UGVaUGY1RTJUY3RWaXdIUW1ERkhQcHFTSVdmQTRQYnpKc3lNSHFXcjhNeFlw?= =?utf-8?B?V2hnV21tRy9kOGpSMm9XdlVOLzFIWGQ4TTlmOHZxYXJEZXUrM3dIZzVBYnpu?= =?utf-8?B?blJZRVJMeUVvQ0s1QUkzajhHMzlHR0ZjVlJ1Vm8wMU1DU0lja3l3Z2d6amVC?= =?utf-8?Q?ibKfhoQkAYbsMvWLCNujZ1qjAsqPJagCUPvMdm3?= X-MS-Exchange-CrossTenant-Network-Message-Id: e0c98a5c-6dfb-40c8-8a5c-08d97869c0e6 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2021 16:56:25.4780 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: xXM+wdwb+TpVEMVsipWDf3bsUCJTe47ni2xcLUey2DVAgkrWdRpGhCnYxu+kjwDMyecQJUT14vypLS6385Me+w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4887 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH 19/32] net/ngbe: add mailbox process operations X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/8/2021 9:37 AM, Jiawen Wu wrote: > Add check operation for vf function level reset, > mailbox messages and ack from vf. > Waiting to process the messages. > > Signed-off-by: Jiawen Wu <...> > --- a/drivers/net/ngbe/meson.build > +++ b/drivers/net/ngbe/meson.build > @@ -20,3 +20,5 @@ sources = files( > deps += ['hash'] > > includes += include_directories('base') > + > +install_headers('rte_pmd_ngbe.h') Why installing this header? Normally it is not expected drivers to have public headers, only some PMDs has public APIs (we call them PMD specific APIs) but that is not somehting we want. For this case why driver needs public symbols, can you please describe?