From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 2B0CC1C67C for ; Fri, 13 Apr 2018 17:33:20 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Apr 2018 08:33:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,446,1517904000"; d="scan'208";a="47660078" Received: from tanjianf-mobl.ccr.corp.intel.com (HELO [10.255.29.166]) ([10.255.29.166]) by orsmga001.jf.intel.com with ESMTP; 13 Apr 2018 08:33:19 -0700 To: Anatoly Burakov , dev@dpdk.org References: From: "Tan, Jianfeng" Message-ID: Date: Fri, 13 Apr 2018 23:33:18 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 1/2] eal/ipc: fix use-after-free in synchronous requests X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Apr 2018 15:33:21 -0000 On 4/13/2018 7:54 PM, Anatoly Burakov wrote: > Previously, we were adding synchronous requests to request list, we > were doing it after checking if request existed. However, we only > removed the request from the request list if we have succeeded in > sending the request. In case of failed request send, we left an > invalid pointer in the request list. > > Fix this by only adding request to the list once we succeed in > sending it. > > Fixes: 783b6e54971d ("eal: add synchronous multi-process communication") > Cc: jianfeng.tan@intel.com > > Signed-off-by: Anatoly Burakov Nice catch. Acked-by: Jianfeng Tan > --- > lib/librte_eal/common/eal_common_proc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/lib/librte_eal/common/eal_common_proc.c b/lib/librte_eal/common/eal_common_proc.c > index c888c84..e3eb430 100644 > --- a/lib/librte_eal/common/eal_common_proc.c > +++ b/lib/librte_eal/common/eal_common_proc.c > @@ -922,8 +922,6 @@ mp_request_sync(const char *dst, struct rte_mp_msg *req, > > pthread_mutex_lock(&pending_requests.lock); > exist = find_sync_request(dst, req->name); > - if (!exist) > - TAILQ_INSERT_TAIL(&pending_requests.requests, &sync_req, next); > if (exist) { > RTE_LOG(ERR, EAL, "A pending request %s:%s\n", dst, req->name); > rte_errno = EEXIST; > @@ -939,6 +937,8 @@ mp_request_sync(const char *dst, struct rte_mp_msg *req, > } else if (ret == 0) > return 0; > > + TAILQ_INSERT_TAIL(&pending_requests.requests, &sync_req, next); > + > reply->nb_sent++; > > do {