From: "Mattias Rönnblom" <hofors@lysator.liu.se>
To: "Pathak, Pravin" <pravin.pathak@intel.com>,
"Sevincer, Abdullah" <abdullah.sevincer@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "jerinj@marvell.com" <jerinj@marvell.com>,
"Richardson, Bruce" <bruce.richardson@intel.com>,
"mattias.ronnblom@ericsson.com" <mattias.ronnblom@ericsson.com>,
"Aggarwal, Manish" <manish.aggarwal@intel.com>
Subject: Re: [PATCH v8 2/3] eventdev: add support for independent enqueue
Date: Wed, 28 Aug 2024 18:45:24 +0200 [thread overview]
Message-ID: <e7c65ecd-fc02-4031-9329-365203898098@lysator.liu.se> (raw)
In-Reply-To: <BL1PR11MB5461DCA99D9BB0D22D12091FF4892@BL1PR11MB5461.namprd11.prod.outlook.com>
On 2024-08-24 22:41, Pathak, Pravin wrote:
>
>
>> -----Original Message-----
>> From: Mattias Rönnblom <hofors@lysator.liu.se>
>> Sent: Friday, August 23, 2024 7:03 AM
>> To: Sevincer, Abdullah <abdullah.sevincer@intel.com>; dev@dpdk.org
>> Cc: jerinj@marvell.com; Richardson, Bruce <bruce.richardson@intel.com>;
>> Pathak, Pravin <pravin.pathak@intel.com>; mattias.ronnblom@ericsson.com;
>> Aggarwal, Manish <manish.aggarwal@intel.com>
>> Subject: Re: [PATCH v8 2/3] eventdev: add support for independent enqueue
>>
>> On 2024-08-12 22:00, Abdullah Sevincer wrote:
>>> This commit adds support for independent enqueue feature and updates
>>> Event Device and PMD feature list.
>>>
>>> A new capability RTE_EVENT_DEV_CAP_INDEPENDENT_ENQ is introduced to
>>> support independent enqueue to support PMD to enqueue in any order
>>> even the underlined hardware device needs enqueues in a strict dequeue
>>
>> This sentence needs to be rephrased.
>>
>> My attempt:
>> "A new capability RTE_EVENT_DEV_CAP_INDEPENDENT_ENQ is introduced. An
>> application may, on an event device where independent enqueue is supported,
>> using an event port where it is enabled, enqueue RTE_EVENT_OP_FORWARD or
>> RELEASE type events in any order."
>>
>>> order.
>
> Will this work:
> A new capability, RTE_EVENT_DEV_CAP_INDEPENDENT_ENQ, is introduced. It
> allows out-of-order enqueuing of RTE_EVENT_OP_FORWARD or RELEASE type
> events on an event port where this capability is enabled.
>
Sounds good and better than my attempt.
>>>
>>> To use this capability applications need to set flag
>>> RTE_EVENT_PORT_CFG_INDEPENDENT_ENQ during port setup only if the
>>> capability RTE_EVENT_DEV_CAP_INDEPENDENT_ENQ exists.
>>>
>>> Signed-off-by: Abdullah Sevincer <abdullah.sevincer@intel.com>
>>> ---
>>> doc/guides/eventdevs/features/default.ini | 1 +
>>> doc/guides/eventdevs/features/dlb2.ini | 1 +
>>> doc/guides/rel_notes/release_24_11.rst | 5 +++
>>> lib/eventdev/rte_eventdev.h | 37 +++++++++++++++++++++++
>>> 4 files changed, 44 insertions(+)
>>>
>>> diff --git a/doc/guides/eventdevs/features/default.ini
>>> b/doc/guides/eventdevs/features/default.ini
>>> index 1cc4303fe5..7c4ee99238 100644
>>> --- a/doc/guides/eventdevs/features/default.ini
>>> +++ b/doc/guides/eventdevs/features/default.ini
>>> @@ -22,6 +22,7 @@ carry_flow_id =
>>> maintenance_free =
>>> runtime_queue_attr =
>>> profile_links =
>>> +independent_enq =
>>>
>>> ;
>>> ; Features of a default Ethernet Rx adapter.
>>> diff --git a/doc/guides/eventdevs/features/dlb2.ini
>>> b/doc/guides/eventdevs/features/dlb2.ini
>>> index 7b80286927..c7193b47c1 100644
>>> --- a/doc/guides/eventdevs/features/dlb2.ini
>>> +++ b/doc/guides/eventdevs/features/dlb2.ini
>>> @@ -15,6 +15,7 @@ implicit_release_disable = Y
>>> runtime_port_link = Y
>>> multiple_queue_port = Y
>>> maintenance_free = Y
>>> +independent_enq = Y
>>>
>>> [Eth Rx adapter Features]
>>>
>>> diff --git a/doc/guides/rel_notes/release_24_11.rst
>>> b/doc/guides/rel_notes/release_24_11.rst
>>> index f0ec07c263..04f389876a 100644
>>> --- a/doc/guides/rel_notes/release_24_11.rst
>>> +++ b/doc/guides/rel_notes/release_24_11.rst
>>> @@ -30,6 +30,11 @@ New Features
>>> ``RTE_EVENT_PORT_CFG_INDEPENDENT_ENQ`` to enable the feature if the
>> capability
>>> ``RTE_EVENT_DEV_CAP_INDEPENDENT_ENQ`` exists.
>>>
>>> +* **Updated Event Device Library for independent enqueue feature**
>>> +
>>> + * Added support for independent enqueue feature. Updated Event Device
>> and
>>> + PMD feature list.
>>> +
>>>
>>> Removed Items
>>> -------------
>>> diff --git a/lib/eventdev/rte_eventdev.h b/lib/eventdev/rte_eventdev.h
>>> index 08e5f9320b..48e6eadda9 100644
>>> --- a/lib/eventdev/rte_eventdev.h
>>> +++ b/lib/eventdev/rte_eventdev.h
>>> @@ -446,6 +446,31 @@ struct rte_event;
>>> * @see RTE_SCHED_TYPE_PARALLEL
>>> */
>>>
>>> +#define RTE_EVENT_DEV_CAP_INDEPENDENT_ENQ (1ULL << 16) /**< Event
>>> +device is capable of independent enqueue.
>>> + * A new capability, RTE_EVENT_DEV_CAP_INDEPENDENT_ENQ, will indicate
>>> +that Eventdev
>>> + * supports the enqueue in any order or specifically in a different
>>> +order than the
>>> + * dequeue. Eventdev PMD can either transmit events in the changed
>>> +order in which
>>> + * they are enqueued or restore the original order before sending
>>> +them to the
>>> + * underlying hardware device. A flag is provided during the port
>>> +configuration to
>>> + * inform Eventdev PMD that the application intends to use an
>>> +independent enqueue
>>> + * order on a particular port. Note that this capability only matters
>>> +for Eventdevs
>>> + * supporting burst mode.
>>> + *
>>> + * To Inform PMD that the application plans to use independent
>>> +enqueue order on a port
>>> + * this code example can be used:
>>> + *
>>> + * if (capability & RTE_EVENT_DEV_CAP_INDEPENDENT_ENQ)
>>> + * port_config = port_config |
>> RTE_EVENT_PORT_CFG_INDEPENDENT_ENQ;
>>> + *
>>> + * When an implicit release is enabled on a port, Eventdev PMD will
>>> +also handle
>>> + * the insertion of RELEASE events in place of dropped events. The
>>> +independent enqueue
>>> + * feature only applies to FORWARD and RELEASE events. New events
>>> +(op=RTE_EVENT_OP_NEW)
>>> + * will be transmitted in the order the application enqueues them and
>>> +do not maintain
>>> + * any order relative to FORWARD/RELEASE events. FORWARD vs NEW
>>> +relaxed ordering
>>> + * only applies to ports that have enabled independent enqueue feature.
>>> + */
>>> +
>>> /* Event device priority levels */
>>> #define RTE_EVENT_DEV_PRIORITY_HIGHEST 0
>>> /**< Highest priority level for events and queues.
>>> @@ -1072,6 +1097,18 @@ rte_event_queue_attr_set(uint8_t dev_id, uint8_t
>> queue_id, uint32_t attr_id,
>>> *
>>> * @see rte_event_port_setup()
>>> */
>>> + #define RTE_EVENT_PORT_CFG_INDEPENDENT_ENQ (1ULL << 5)
>>> +/**< Flag to enable independent enqueue. Must not be set if the
>>> +device
>>> + * is not RTE_EVENT_DEV_CAP_INDEPENDENT_ENQ capable. This feature
>>> + * allows an application to enqueue RTE_EVENT_OP_FORWARD or
>>> + * RTE_EVENT_OP_RELEASE in an order different than the order the
>>> + * events were dequeued from the event device, while maintaining
>>> + * RTE_SCHED_TYPE_ATOMIC or RTE_SCHED_TYPE_ORDERED semantics.
>>> + *
>>> + * Note that this flag only matters for Eventdevs supporting burst mode.
>>> + *
>>> + * @see rte_event_port_setup()
>>> + */
>>>
>>> /** Event port configuration structure */
>>> struct rte_event_port_conf {
>>
>> Acked-by: Mattias Rönnblom <mattias.ronnblom@ericsson.com>
next prev parent reply other threads:[~2024-08-28 16:45 UTC|newest]
Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-21 20:12 [PATCH v1 0/2] DLB Enqueue Reorder Support Abdullah Sevincer
2024-06-21 20:12 ` [PATCH v1 1/2] event/dlb2: add support for enqueue reordering Abdullah Sevincer
2024-06-21 20:51 ` [PATCH v2 0/2] DLB Enqueue Reorder Support Abdullah Sevincer
2024-06-21 20:51 ` [PATCH v2 1/2] event/dlb2: add support for enqueue reordering Abdullah Sevincer
2024-06-21 20:51 ` [PATCH v2 2/2] eventdev: add support for enqueue reorder Abdullah Sevincer
2024-06-21 22:24 ` [PATCH v3 0/2] DLB Enqueue Reorder Support Abdullah Sevincer
2024-06-21 22:24 ` [PATCH v3 1/2] event/dlb2: add support for enqueue reordering Abdullah Sevincer
2024-06-21 22:24 ` [PATCH v3 2/2] eventdev: add support for enqueue reorder Abdullah Sevincer
2024-06-24 8:28 ` Jerin Jacob
2024-06-26 18:31 ` Sevincer, Abdullah
2024-06-27 13:13 ` Jerin Jacob
2024-07-01 8:24 ` Mattias Rönnblom
2024-07-01 8:50 ` Mattias Rönnblom
2024-07-02 17:25 ` Pathak, Pravin
2024-07-11 3:20 ` Pathak, Pravin
2024-07-10 1:20 ` [PATCH v4 0/3] Independent Enqueue Support Abdullah Sevincer
2024-07-10 1:20 ` [PATCH v4 1/3] event/dlb2: add support for independent enqueue Abdullah Sevincer
2024-07-10 1:20 ` [PATCH v4 2/3] eventdev: " Abdullah Sevincer
2024-07-10 1:20 ` [PATCH v4 3/3] event/dsw: add capability " Abdullah Sevincer
2024-07-10 6:33 ` [PATCH v5 0/3] Independent Enqueue Support Abdullah Sevincer
2024-07-10 6:33 ` [PATCH v5 1/3] event/dlb2: add support for independent enqueue Abdullah Sevincer
2024-07-10 6:33 ` [PATCH v5 2/3] eventdev: " Abdullah Sevincer
2024-07-10 6:33 ` [PATCH v5 3/3] event/dsw: add capability " Abdullah Sevincer
2024-07-11 19:54 ` [PATCH v6 0/3] Independent Enqueue Support Abdullah Sevincer
2024-07-11 19:54 ` [PATCH v6 1/3] event/dlb2: add support for independent enqueue Abdullah Sevincer
2024-07-11 19:54 ` [PATCH v6 2/3] eventdev: " Abdullah Sevincer
2024-07-23 6:40 ` Mattias Rönnblom
2024-07-29 13:49 ` Pathak, Pravin
2024-08-13 15:00 ` Sevincer, Abdullah
2024-08-20 16:48 ` Sevincer, Abdullah
2024-08-12 18:41 ` [PATCH v7 0/3] Independent Enqueue Support Abdullah Sevincer
2024-08-12 18:41 ` [PATCH v7 1/3] event/dlb2: add support for independent enqueue Abdullah Sevincer
2024-08-12 18:41 ` [PATCH v7 2/3] eventdev: " Abdullah Sevincer
2024-08-12 18:41 ` [PATCH v7 3/3] event/dsw: add capability " Abdullah Sevincer
2024-08-12 20:00 ` [PATCH v8 0/3] Independent Enqueue Support Abdullah Sevincer
2024-08-12 20:00 ` [PATCH v8 1/3] event/dlb2: add support for independent enqueue Abdullah Sevincer
2024-08-12 20:00 ` [PATCH v8 2/3] eventdev: " Abdullah Sevincer
2024-08-23 11:02 ` Mattias Rönnblom
2024-08-24 20:41 ` Pathak, Pravin
2024-08-27 18:33 ` Sevincer, Abdullah
2024-08-28 16:45 ` Mattias Rönnblom [this message]
2024-08-28 16:59 ` Sevincer, Abdullah
2024-08-29 12:51 ` Jerin Jacob
2024-08-31 18:38 ` Sevincer, Abdullah
2024-08-29 17:36 ` [PATCH v9 0/3] Independent Enqueue Support Abdullah Sevincer
2024-08-29 17:36 ` [PATCH v9 1/3] event/dlb2: add support for independent enqueue Abdullah Sevincer
2024-08-29 17:36 ` [PATCH v9 2/3] eventdev: " Abdullah Sevincer
2024-08-29 17:36 ` [PATCH v9 3/3] event/dsw: add capability " Abdullah Sevincer
2024-08-30 16:23 ` [PATCH v10 0/3] Independent Enqueue Support Abdullah Sevincer
2024-08-30 16:23 ` [PATCH v10 1/3] event/dlb2: add support for independent enqueue Abdullah Sevincer
2024-09-09 1:47 ` fengchengwen
2024-09-16 17:51 ` Sevincer, Abdullah
2024-09-09 15:52 ` [PATCH v11 0/3] Independent Enqueue Support Abdullah Sevincer
2024-09-09 15:52 ` [PATCH v11 1/3] eventdev: add support for independent enqueue Abdullah Sevincer
2024-09-09 15:52 ` [PATCH v11 2/3] event/dlb2: " Abdullah Sevincer
2024-09-09 15:52 ` [PATCH v11 3/3] event/dsw: add capability " Abdullah Sevincer
2024-09-09 16:05 ` [PATCH v12 0/3] Independent Enqueue Support Abdullah Sevincer
2024-09-09 16:05 ` [PATCH v12 1/3] eventdev: add support for independent enqueue Abdullah Sevincer
2024-09-09 16:05 ` [PATCH v12 2/3] event/dlb2: " Abdullah Sevincer
2024-09-09 16:05 ` [PATCH v12 3/3] event/dsw: add capability " Abdullah Sevincer
2024-08-30 16:23 ` [PATCH v10 2/3] eventdev: add support " Abdullah Sevincer
2024-08-30 16:23 ` [PATCH v10 3/3] event/dsw: add capability " Abdullah Sevincer
2024-08-12 20:00 ` [PATCH v8 " Abdullah Sevincer
2024-08-23 11:03 ` Mattias Rönnblom
2024-07-11 19:54 ` [PATCH v6 " Abdullah Sevincer
2024-07-23 6:41 ` Mattias Rönnblom
2024-06-21 20:12 ` [PATCH v1 2/2] eventdev: add support for enqueue reorder Abdullah Sevincer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e7c65ecd-fc02-4031-9329-365203898098@lysator.liu.se \
--to=hofors@lysator.liu.se \
--cc=abdullah.sevincer@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=manish.aggarwal@intel.com \
--cc=mattias.ronnblom@ericsson.com \
--cc=pravin.pathak@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).