From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 8D3972C0A for ; Fri, 9 Sep 2016 08:24:23 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP; 08 Sep 2016 23:24:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,304,1470726000"; d="scan'208";a="876734358" Received: from shwdeisgchi083.ccr.corp.intel.com (HELO [10.239.67.193]) ([10.239.67.193]) by orsmga003.jf.intel.com with ESMTP; 08 Sep 2016 23:24:22 -0700 To: Yuanhan Liu References: <1470397003-5782-1-git-send-email-jianfeng.tan@intel.com> <1470397003-5782-3-git-send-email-jianfeng.tan@intel.com> <20160906064246.GQ30752@yliu-dev.sh.intel.com> <20160906082011.GA23158@yliu-dev.sh.intel.com> <53e1d78c-e3b0-e16c-992d-e45ed1b31a4f@intel.com> <20160908121818.GO23158@yliu-dev.sh.intel.com> <11291eac-cbbe-7080-3d35-bdacb5341d89@intel.com> <20160909041949.GP23158@yliu-dev.sh.intel.com> <1537a739-9805-cd51-cf0a-f32d608a97e0@intel.com> <20160909060348.GQ23158@yliu-dev.sh.intel.com> Cc: dev@dpdk.org, zhihong.wang@intel.com, lining18@jd.com From: "Tan, Jianfeng" Message-ID: Date: Fri, 9 Sep 2016 14:24:20 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <20160909060348.GQ23158@yliu-dev.sh.intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 2/3] net/virtio_user: fix wrong sequence of messages X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Sep 2016 06:24:24 -0000 On 9/9/2016 2:03 PM, Yuanhan Liu wrote: >> GET_PROTOCOL_FEATURES >> is not supported yet. I see those features in PROTOCOL_FEATURES is for live >> migration (right?). > Not exactly. PROTOCOL_FEATURES was firstly introduced while MQ was > enabled. Thus it's no wonder MQ is the first protocol feature vhost > user supports: > > [yliu@yliu-dev ~/dpdk]$ gg PROTOCOL_F_ lib/librte_vhost/ > lib/librte_vhost/vhost_user.h:46:#define VHOST_USER_PROTOCOL_F_MQ 0 > lib/librte_vhost/vhost_user.h:47:#define VHOST_USER_PROTOCOL_F_LOG_SHMFD 1 > lib/librte_vhost/vhost_user.h:48:#define VHOST_USER_PROTOCOL_F_RARP 2 > > --yliu OK, I got it. The maximum of queue pair number is now a parameter of virtio_user, but we need to depend on PROTOCOL_FEATURES (further, VHOST_USER_GET_QUEUE_NUM) to maximum queue pair number that vhost can support. Just wonder why not QEMU depends on (1ULL << VIRTIO_NET_F_MQ) inside features to do that? Thanks, Jianfeng > >> Assuming that, anyone using container/process now >> enables live migration so far? I don't think so. >> >> Thanks, >> Jianfeng >> >> >>> --yliu