From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.warmcat.com (mail.warmcat.com [163.172.24.82]) by dpdk.org (Postfix) with ESMTP id C95725593 for ; Thu, 17 May 2018 15:09:20 +0200 (CEST) To: Bruce Richardson Cc: dev@dpdk.org References: <152627436523.53156.4398253089110011263.stgit@localhost.localdomain> <152627462791.53156.5271968691770807055.stgit@localhost.localdomain> <20180517105353.GD22048@bricha3-MOBL.ger.corp.intel.com> From: Andy Green Message-ID: Date: Thu, 17 May 2018 21:09:13 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 In-Reply-To: <20180517105353.GD22048@bricha3-MOBL.ger.corp.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v4 12/23] rte_mbuf.h: explicit cast for size type to uint32 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 May 2018 13:09:20 -0000 On 05/17/2018 06:53 PM, Bruce Richardson wrote: > On Mon, May 14, 2018 at 01:10:27PM +0800, Andy Green wrote: >> Signed-off-by: Andy Green >> --- >> lib/librte_mbuf/rte_mbuf.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h >> index 0580ec8a0..169f3d3b0 100644 >> --- a/lib/librte_mbuf/rte_mbuf.h >> +++ b/lib/librte_mbuf/rte_mbuf.h >> @@ -1577,7 +1577,7 @@ static inline void rte_pktmbuf_detach(struct rte_mbuf *m) >> __rte_pktmbuf_free_direct(m); >> >> priv_size = rte_pktmbuf_priv_size(mp); >> - mbuf_size = sizeof(struct rte_mbuf) + priv_size; >> + mbuf_size = (uint32_t)sizeof(struct rte_mbuf) + priv_size; >> buf_len = rte_pktmbuf_data_room_size(mp); >> >> m->priv_size = priv_size; >> > It would be good to include the error message in the commit log. > Also, for safety, is it better to have extra braces to cast the whole > expression, not just the sizeof, i.e. > > mbuf_size = (uint32_t)(sizeof(...) + priv_size); OK I went back and captured the original error and added it back in, and adapted the scope of the cast as you suggested. -Andy > /Bruce >