From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6080542E9D; Mon, 17 Jul 2023 17:14:00 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E2EAF40DFD; Mon, 17 Jul 2023 17:13:59 +0200 (CEST) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2077.outbound.protection.outlook.com [40.107.220.77]) by mails.dpdk.org (Postfix) with ESMTP id 7F45340A80 for ; Mon, 17 Jul 2023 17:13:58 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SB8vlT5vXepIrwuDsohV+MNMqix/yiVfsiRhdu/9BTMhAySowbLoFT1sVKwfH7voY+WbaOxdUM0Hi0VeeHRVTbSrzYbbgXmVN1FIwT1gx04WW1Emd7A05rsqUIHrDEqBefdU5zq5g3oHYAXZzWlmr69C3w713dDOdpPXbopN1FyE+7PuARIZ4VSbvmGdp5jKQdvV2bJvxuglYAx10YeBJdTNxCVqT+l0KB0SqiJ8EhQYFy6H0eojgOKV0TBMiH9DujyWScr9NJBPAoSjhfcfgEt2iIyqXuB8+dXN/I5IQiXnmE4jq1JeKhokaaohHRfpp4V9PqbpwVh087NDTcaDCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4sGmZlMXmcZo0kVOwMrIHsxyZoebsY6kK0pkw+Pa9RU=; b=HNh4g0WZVZX1GElpgYqDudlBV7UQ1kqLcShMlP9m2t6+NHcbzL1KYD4NMzEEPXR9SeNSVZZ8pnZkeFkzqKO1XDA0f31VHJPJ23ebJJKAALHnKW23bgw21XphqIrFK7kxvQGMIGQnNayiMcjC6HqMiJZRei+Wfz2jOFoZ30kTKR5omfyOU5bUNKer/5j5fAbWkYhzIYcPPZncnoHyArjgg7WruSVScI3aga+Z8rnKiDlKrRP1yQ8q26T2gfz+WNSw+wwgzh738nThRMo4wRpMLw6dnbcVyjhAagKfbucQz3PAJHDrXLF3gmJfVnyOizXXK9cl9yvhPUgwzcTDK6omzQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4sGmZlMXmcZo0kVOwMrIHsxyZoebsY6kK0pkw+Pa9RU=; b=VSiLwOLMRMUJSIVDx527+52iTSWRE0dWp1nvmWKNeV0ZnCPa34NEAEPDNcvu8PJNKB2zwrzPXPRaMSkYt0H26EKaazsThGBmB1sNon8hLoa6mLKqPfD91HtaRhxCj7kEegVfhUlgibf2ygTKxT6K8XT5h8Kxa4/QFn5N9jgfezo= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by SN7PR12MB6669.namprd12.prod.outlook.com (2603:10b6:806:26f::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6588.28; Mon, 17 Jul 2023 15:13:55 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::369d:5f05:aaba:ebd8]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::369d:5f05:aaba:ebd8%3]) with mapi id 15.20.6588.031; Mon, 17 Jul 2023 15:13:55 +0000 Message-ID: Date: Mon, 17 Jul 2023 16:13:49 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Content-Language: en-US To: Chaoyong He , dev@dpdk.org Cc: oss-drivers@corigine.com, niklas.soderlund@corigine.com, Long Wu References: <20230714081526.1277786-1-chaoyong.he@corigine.com> <20230714081526.1277786-4-chaoyong.he@corigine.com> From: Ferruh Yigit Subject: Re: [PATCH 3/3] doc: announce bonding function change In-Reply-To: <20230714081526.1277786-4-chaoyong.he@corigine.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PA7P264CA0299.FRAP264.PROD.OUTLOOK.COM (2603:10a6:102:370::10) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|SN7PR12MB6669:EE_ X-MS-Office365-Filtering-Correlation-Id: 146e177a-8ac1-4293-2e54-08db86d8700a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: XqaMmAgadX/4cFMegqW0bXyCnZARZ71X/BoHHwywFtKJkvLpLL6bY1wyZHBIdn9GThlDMsqUrkU6kkJAX/PVW2lzXCIHmxCkxlQSIIqmjaQIiQTUUpvrH4IpWoFSNgdlhHmE6zN4Sq5P2zm8GnEJ1+yrJXrl+jcYpfKtgztC0+w9WGqaXTwki2nroREGvrkg0yhbzPjDGV/IbwKH481cZoRH+ovmZzuUUTSEfaq3HplS7qelM7jIcY0n0nYAoJdSttyuVvZcQLgEuTayG0hdWL876es16zMa87TsTnZ15RyE2H1oJZNjZoZOD4bVT/Yq/K7cjWY//z7r3Q5XMKOsB/k2zXw1trrcP0riB/7MNSVxPOSgaa/aDy1QA1H/vWvWjywYdYF+PVPhxW3hnS7/yvfWzsHpLFJ5XCLKvWVpRHdn41LDO4CAKNFFck10FSI6xSDE9N5banYz8yRok/vc25Pmjott1dV3LWsMKgmnvmLV9Y6wTFx6yVvGbMad0ErJcRJIRlKCv6HVlSLDuQQjibPSJ8Zrlgd3Oo+KjhPxONx+58FuESXxnk7eWHtSsSXrn1afWel6dT4YWwDlMrzhjG0vYiwa1TGs0TFBbdqcXGjqP66L1DoJdBwJR/Jz8+yM X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(376002)(396003)(39860400002)(366004)(136003)(346002)(451199021)(2616005)(6666004)(966005)(31696002)(6512007)(478600001)(86362001)(6486002)(36756003)(6506007)(53546011)(26005)(5660300002)(44832011)(41300700001)(4326008)(38100700002)(66476007)(66556008)(186003)(8936002)(2906002)(316002)(66946007)(8676002)(83380400001)(31686004)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UmROZFJHYktvSGhIKzVnOFdBSTA3dzdNVnpId2h6bjVTNERVWVVTd0VRRkJq?= =?utf-8?B?UDE3R2NTam9KTHpmUEpZdmtubmNzWFdzRzMvWTA1VlJZSVpjZ1orWnBHSmF3?= =?utf-8?B?czM4YWd5dHZqM2Y3Y2xXNDliZnczZ3BIMjdDTU5BdWJOUnlWNFB0OVZJQzMv?= =?utf-8?B?UStYY2hodXlzZXJjbWE5MU0vbW4vK3JVQjRLQzRhL1hXQ3BEazhPeHF1bU5F?= =?utf-8?B?OXZkK3pTQXVUUVFqRjdCeVNMNG9KVVVJWGI5VkVvZnhIbngyN0VxVU5idTQ0?= =?utf-8?B?QUJRYXIrV09tUkV4ZmlEelVZcDhjUkNSNktaWHlldkZFSUhRc1hFOXhXWGly?= =?utf-8?B?UDlnTHdkK0dmc2MwK0NMZzBzWWFkUk5PMWVSeTBkcUQyRmFsSHNKWlBjTjZB?= =?utf-8?B?VExaenNZMGhldXZYR29xTTVPVC94OVVIKy9NMWQ4bFpTYnBXWUpySnVKdE5z?= =?utf-8?B?akZ0QnBPazZXRFZsTWdIUkFaU0RWQ25GSEc1NkxTR1BJNVpWR2h4SVdseTRU?= =?utf-8?B?ZmtCdGdPR0pDQVQ4SWJUcXgxQUFWbU9uVDZGRjhkN3c1TU5xWUkxQytYUnFl?= =?utf-8?B?S01ReElkZU40TnRacWRaaXB1RThxYTdmMDlYVUdMbGpBL2hUTXNvS1lRNFdw?= =?utf-8?B?aTlKWTFXdVRHNmhBZUE3RUJ4OE9qZVRvTDNpdHk2d2pRTEc1ZVVwNGJYTnB6?= =?utf-8?B?amZ0K0JoNXRkN3YwZ2taZ3lUOFdYTHY3WFduNnlVZTZQYXVnTTEvMk0waUR6?= =?utf-8?B?UFlrVnYzSFd3bTFWd1g3Q1cvTFhseU5IakQzdGx4c3hNcU1OMTRtVWF0TU0r?= =?utf-8?B?VllRL2lQQmlFa3RGeDNTbVdHV0hTWmVaYkpaOTltd0g5UlcrMnZWTk1VbVMz?= =?utf-8?B?TVZoQkdqNGpkcGJ6K2RUU1lEYmU1UDVldXJEVGRQZWk1VVpPcnk5ODdmclRG?= =?utf-8?B?Rjc2MjVCMnZpT21Ca01tVjJHc3FlWjVmUjFTRHFxNkpaYWhtRit4bm9QQnIw?= =?utf-8?B?MWszYklRRXRrMUg1U0w1OFFkSkxUK0cxbHh5Y0tST2NyY2RwLzc0aHRLbmd1?= =?utf-8?B?NEFQT2NqVWZOUDdGRkptRjVkdlczZ05MdERVVUlEMlRtck5udHdBQUIxeFBw?= =?utf-8?B?dXloSzM0a3EvaTdhREJ0bWVzeEw2MFkwQUVWVk1hVlFsalpBOWloNDFBYzdo?= =?utf-8?B?amRDVFduSUkrSkFxaENBSmZpbHFjTmdma3BGRyszL3BKOW5KUXpuY2ljSlll?= =?utf-8?B?bGsyeHlXTGgvbTAvQ1hBK1hJUUc2dkd4M2Vncitib1d2SjljbUJURGo4bXYx?= =?utf-8?B?Zm9XUCtiMjZscDlrUFg3NVJwdGNQWk9BYmh5b25ERHE5Qm1oZXdWQWw2SXFP?= =?utf-8?B?SCs1TGtLTlkrdFdkejA3czZXMi9RNjFFbitOdm9tMDAxTmpyaUZRTmRHZ0FX?= =?utf-8?B?ZnhyeEQydTdDK3luV3lxYTBpRk9ha1Z4NERoNlZQM0FPSndTTE9KS3RjVE0y?= =?utf-8?B?YmtENjhxckx5eWdnTWdDRm81SVlwS0NpVnQ5WFErNUNoaUpiVjUxYjh6ZlpV?= =?utf-8?B?bVZXVUxzd3dwUy9mWksvb3U0UUhza3NBZnF2SzRRcHZVV2FXaEg4UGRrdmhn?= =?utf-8?B?ckRaQTgwZmZVays0TnJmblpzVXZiUHpYQmp6Y2RQZ3M0TTBHQTgwVHdqVlZn?= =?utf-8?B?amZHZXJZUnBqQThvK3Z5MkVnUUZJRmJieWk5ZUJtNmg4VFRLbm9ZZWhVUmpN?= =?utf-8?B?eWcxU202WU54a1EvSU84eGxOem9zdlhQeUxVWmR0N3B5bW4zYTlwSU5qNDk2?= =?utf-8?B?bkEvVk01dUlzeFVLLzhrMzZZaTlvQ3JHOXkzdG91ektxYUExS0RqZ0VCblhi?= =?utf-8?B?c21TWllxbDliUCtkSmxXZjRwVVJZWkhYU2w1YnVRRHB0SWhDMWFJcWM1MFFa?= =?utf-8?B?UkRnb2Z3WWROcG40YUR2VXJsdzZISGpKZThhVnE2WGxEOEt2OFVzOC9iKzhZ?= =?utf-8?B?NlZSM05DczJxdnJCSHRYUExJZEVVU0FOaDlneTQwQldjT1NjUTlSSHp6cTgz?= =?utf-8?B?amc1NEVFSlRjS25xcGRNQllGUVpGQ0lkYS9yU0hxdVo5K0dZZFQ3TnZIM050?= =?utf-8?Q?PZCWu5//Dp/JQ63il1U9Yjfti?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 146e177a-8ac1-4293-2e54-08db86d8700a X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jul 2023 15:13:55.7981 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: vrZZ+I4WyLpqvpbpRWFcxtmQl3ROb/r7ZKu6rZc0mz2zujo9OyEm+grTEPgTb5rk X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB6669 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 7/14/2023 9:15 AM, Chaoyong He wrote: > In order to support inclusive naming, some of the function in DPDK will > need to be renamed. Do this through deprecation process now for 23.07. > > Signed-off-by: Long Wu > Signed-off-by: Chaoyong He <...> > --- a/drivers/net/bonding/rte_eth_bond.h > +++ b/drivers/net/bonding/rte_eth_bond.h > @@ -121,8 +121,16 @@ rte_eth_bond_free(const char *name); > * @return > * 0 on success, negative value otherwise > */ > +__rte_experimental > int > -rte_eth_bond_slave_add(uint16_t bonded_port_id, uint16_t slave_port_id); > +rte_eth_bond_member_add(uint16_t bonded_port_id, uint16_t member_port_id); > + > +__rte_deprecated > +static inline int > +rte_eth_bond_slave_add(uint16_t bonded_port_id, uint16_t slave_port_id) > +{ > + return rte_eth_bond_member_add(bonded_port_id, slave_port_id); > +} > This will make old symbols disappear from shared library, since they are static inline functions and not object in the shared library. And this will break the ABI, you can see this from the CI test: https://mails.dpdk.org/archives/test-report/2023-July/427987.html One option is to add old functions to the .c file, and keep old function declarations in the header file, with '__rte_deprecated' attribute. But I think it is simpler/safer to rename in one go in v23.11 release, so this patch can update only deprecation notice to list functions that will be renamed in v23.11 release.