From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E4BD6A00C3; Thu, 12 May 2022 16:13:24 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CA28C40E64; Thu, 12 May 2022 16:13:24 +0200 (CEST) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2049.outbound.protection.outlook.com [40.107.94.49]) by mails.dpdk.org (Postfix) with ESMTP id 1A18940DDD for ; Thu, 12 May 2022 16:13:24 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gE2WsOrX2ZxZN/wPuN4fHDyT7D4d5IMXBBOH588BSNA223krUhX3I/uO6Xi2uwW7URHtNWbBDTqhwhdcWYItiiwgmd+ZZcpVh7u3fJDtFdoukb2bzrZqKAZtBpfH5wsdi858pa1xQuHibsZyZ6pID5P8hXLJ4WzPBRNXlrJKAK6xRGnZMbmMFEC8D/WXkvDf/k5EUrXSQU2mbrmkX0VmTKXK6Tt/TrX0rFIDv3g6qyIpx6OYD1qxy9eVOTFSvYT1nDKakGhn+KQJiQNKxMB+XAaEa6PcuBHDjCsPGCP2LNi2zVxwV8Mj8oHh/km7Sqo3Jsro/j4LIQTymqoaYIA2hA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GvesfcGX6F6VwISsuwgjBqjtpCzZ667yqnF0F9KC7tM=; b=ZIXajadLKj7wEkOFbWLfM461JF4pGM7yJZHUgQqGnZ4aj6snKg6s7lZ4x98KPDHbuc/xL45ivU1hdJVItY1lLzOReu/EXSBSx/OHKFC/xzBFwSXdur+hz8x6XGzkvNEuEPcKF7KzpRefMlkL5HifY39BBHA/IcUKEtqL5dcmHs1DQ/1J8ASAPtIy6RWQ1qWn/iZSgKh/+r0fJT/acaevXOuHVMeKUUVsrTDggbw0F0ZEDRMjEHRbRVTl12kPbJIP1RyI/VmDYYlc1jqpCErhIiI2D9+pYCGeFAxQOzLXNp8nOD+D0suAX1W08h9y3918PxSEuPXerMppNbSlmbC+dQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.80.198) smtp.rcpttodomain=nvidia.com smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GvesfcGX6F6VwISsuwgjBqjtpCzZ667yqnF0F9KC7tM=; b=Eutt/z+7V/LgoHPj33wQyjO1rZ274cfuZdy03mFu9IZCxMhUMf3rM+5Xm2abA9cXVzATQg+Aa5AWGfLGP7zsYGChcN9bwr3lB5CbqrurffcKlZSlrKBFlE4SNSlTnyoawZNaEvpd/gEivT/x6mTO2R1QCmuIvho2fhxIssCv/eU= Received: from BN1PR14CA0001.namprd14.prod.outlook.com (2603:10b6:408:e3::6) by DM6PR02MB4316.namprd02.prod.outlook.com (2603:10b6:5:28::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.13; Thu, 12 May 2022 14:13:21 +0000 Received: from BN1NAM02FT057.eop-nam02.prod.protection.outlook.com (2603:10b6:408:e3:cafe::1c) by BN1PR14CA0001.outlook.office365.com (2603:10b6:408:e3::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.22 via Frontend Transport; Thu, 12 May 2022 14:13:21 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.80.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.80.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.80.198; helo=xir-pvapexch02.xlnx.xilinx.com; Received: from xir-pvapexch02.xlnx.xilinx.com (149.199.80.198) by BN1NAM02FT057.mail.protection.outlook.com (10.13.2.165) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5250.13 via Frontend Transport; Thu, 12 May 2022 14:13:21 +0000 Received: from xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) by xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Thu, 12 May 2022 15:13:20 +0100 Received: from smtp.xilinx.com (172.21.105.198) by xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Thu, 12 May 2022 15:13:20 +0100 Envelope-to: orika@nvidia.com, lihuisong@huawei.com, humin29@huawei.com, dev@dpdk.org, thomas@monjalon.net, andrew.rybchenko@oktetlabs.ru, qi.z.zhang@intel.com, olivier.matz@6wind.com, ajit.khaparde@broadcom.com, jerinj@marvell.com, stephen@networkplumber.org, viacheslavo@nvidia.com, huangdaode@huawei.com Received: from [10.71.116.223] (port=62787) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1np9Z8-0007Re-5F; Thu, 12 May 2022 15:13:20 +0100 Message-ID: Date: Thu, 12 May 2022 15:13:17 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH 2/6] net/hns3: fix inconsistent enabled RSS behavior Content-Language: en-US To: Ori Kam , "lihuisong (C)" , "Min Hu (Connor)" , "dev@dpdk.org" , "NBU-Contact-Thomas Monjalon (EXTERNAL)" , Andrew Rybchenko , Qi Zhang CC: Olivier Matz , Ajit Khaparde , "jerinj@marvell.com" , Stephen Hemminger , Slava Ovsiienko , huangdaode References: <20220228032146.37407-1-humin29@huawei.com> <20220228032146.37407-3-humin29@huawei.com> <5b829b45-220b-daa2-19e4-3b3fc746d152@huawei.com> <7a17f2d7-758c-9dde-5550-b52622d17ef5@huawei.com> From: Ferruh Yigit In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: cd9a938f-22b6-4e5f-bf60-08da342191f7 X-MS-TrafficTypeDiagnostic: DM6PR02MB4316:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: e+AMQ0EArSlqQaJBSGkyJ94fFLkNhkuzdnI9PuwMgCMMfMD9+LFIlVc+bl1+LO0zwcCc+S0CdIJ0UF0S0UrQU0jcALefLP+6f0ZdzQvRWm4U2wfP3K/M4d0ZdTAc3YQ1D9L+RTsOKSdhQ/G4rqOkMnFzs0QPSdhTbTciss9RAKFqBUetlubtZfUSVYm7wiUjHT+T43m+IrBotpJvkL6MMrdXMfXQm7KChwbH2HoL2Dj1A6F4sWRBvfLxEiZIXTTLNDELoG0+x4qs65FQ9MesAaRh01quN/Q7D5zmLnoKktvrxEQvGfAZJ+7hropydsuqWRm7iINBhZOcG64VauBMYNfRjCHNSmsIbzejV1za0teon2Ae68GJcUo1toSSvpzFrjixL/FVIic0BPGOF5IdJRUS/jiuGbR3Riln+MxO8jC4pGiM7qdhPrmVbW+NgTSlP5bhxbR1cOYDwkgynza6f9IPelgfn/F989XuXrRkuTYWH7bgW+K9FuPNIis2HcU+qL/tTcwtJAt/zsK87lq8NPUhwVpGui+Crs/9Crrw9uFmNvoEmTT29btFg2Y7vUZifVZ/Or5Lbfgyx/KL3QP2AXwdLSDPclzLjl4kfqoi9vGJVYVKA32QC8q3XBYHMbtZyOdQ1JFw8Hl0XAZTL15hawUDJw1ozR/DtGZitxwOVPVz18/hdFzbtZydiRd699Q9yhaAN39L1jPys60FcPuYpnaYlxxuiJUSXD9Jo79ldkk= X-Forefront-Antispam-Report: CIP:149.199.80.198; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:xir-pvapexch02.xlnx.xilinx.com; PTR:unknown-80-198.xilinx.com; CAT:NONE; SFS:(13230001)(4636009)(84040400005)(36840700001)(40470700004)(46966006)(8676002)(83380400001)(110136005)(9786002)(316002)(4326008)(54906003)(8936002)(26005)(70586007)(82310400005)(53546011)(40460700003)(2616005)(47076005)(36860700001)(426003)(508600001)(336012)(186003)(7636003)(6666004)(70206006)(31686004)(36756003)(44832011)(31696002)(2906002)(7416002)(5660300002)(356005)(50156003)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 May 2022 14:13:21.2125 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: cd9a938f-22b6-4e5f-bf60-08da342191f7 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.80.198]; Helo=[xir-pvapexch02.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: BN1NAM02FT057.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR02MB4316 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 3/9/2022 9:55 AM, Ori Kam wrote: > Hi Lihusiong, > >> -----Original Message----- >> From: lihuisong (C) >> Sent: Wednesday, March 9, 2022 10:03 AM >> Subject: Re: [PATCH 2/6] net/hns3: fix inconsistent enabled RSS behavior >> >> >> 在 2022/3/3 10:47, lihuisong (C) 写道: >>> Hi, Ori, >>> >>> 在 2022/3/2 22:07, Ori Kam 写道: >>>> Hi Lihuisong, >>>> >>>>> -----Original Message----- >>>>> From: lihuisong (C) >>>>> Sent: Wednesday, March 2, 2022 4:10 AM >>>>> Subject: Re: [PATCH 2/6] net/hns3: fix inconsistent enabled RSS >>>>> behavior >>>>> >>>>> >>>>> 在 2022/3/1 0:42, Ferruh Yigit 写道: >>>>>> On 2/28/2022 3:21 AM, Min Hu (Connor) wrote: >>>>>>> From: Huisong Li >>>>>>> >>>>>>> RSS will not be enabled if the RTE_ETH_MQ_RX_RSS_FLAG isn't be set in >>>>>>> dev_configure phase. However, if this flag isn't set, RSS can be >>>>>>> enabled >>>>>>> through the ethdev ops and rte_flow API. This behavior is contrary to >>>>>>> each >>>>>>> other. >>>>>>> >>>>>>> Fixes: c37ca66f2b27 ("net/hns3: support RSS") >>>>>>> Cc: stable@dpdk.org >>>>>>> >>>>>>> Signed-off-by: Huisong Li >>>>>> >>>>>> Hi Huisong, Connor, >>>>>> >>>>>> Let's get a little more feedback for this patch, cc'ed more people. >>>>>> >>>>>> >>>>>> To enable RSS, multi queue mode should be set to >>>>>> 'RTE_ETH_MQ_RX_RSS_FLAG'. >>>>>> >>>>>> But I wonder if it is required to configure RSS via flow API, >>>>> I do not know the original purpose of adding the RSS configuration in >>>>> flow API. >>>>> >>>> The purpose is simple, this allow to create RSS per rule and not a >>>> global one. >>>> For example create RSS that sends TCP to some queues while othe RSS >>>> will send >>>> UDP traffic to different queues. >>> I'm a little confused now. The "per rule" also seems to be a global >>> configuration. >>> Example: >>>  - start PMD with 0,1,2,3 >>>  - create TCP packets to 2,3 queues. At this moment, only 2,3 queues >>> can be received for other types of packets. >>> Because this rule is implemented by modifying the entry of the >>> redirection table which is global for this device. >> Hi, Ori and Stephen. >> Can you help me clear up the confusion above? If some NICs behave like >> this, what should we do about it? > > I'm not sure I understand the issue, maybe it is releated to some HW/PMD limitation. > In your example non TCP traffic will be routed to one of the 4 queues (0,1,2,3), > While TCP traffic will only be routed to queues 2,3. > > Now I can add new rule that matches on UDP packet and RSS to queue 0 and 3 in this case: > TCP packets will be routed to queues 0,3. > UDP packets will be routed to queues 2,3. > All the rest of the traffic will be routed to queues 0,1,2,3 > Hi Ori, How RETA is managed for per flow RSS configuration? And is there a limit on how many per flow RSS rule can be created? > And just to be clear if now I add a rule to match all packets in higher priority, > with RSS to queues 1,2. Then all traffic will be routed to queues 1,2. > > At least this is what is expected, from API point of view. > > Best, > Ori > >>>> >>>>> However, as far as I know, the hash algorithm can be configured via >>>>> this >>>>> API, >>>>> >>>>> but not via ethdev ops API. >>>>> >>>>>> and if other PMDs check this configuration for flow API? >>>>> Some PMDs already have similar check in RSS releated ops or rte_flow >>>>> API. >>>>> >>>>> For example, hinic, axbge, bnxt, cnxk, otx2, and ena. >>>>> >>>>>> . >>>>  From my view point those are two different settings. >>>> The RTE_ETH_MQ_RX_RSS_FLAG is global per port while >>>> rte_flow is per rule. >>>> >>>> I think, that if a PMD needs this flag, in order to enable it also >>>> for rte_flow then >>>> it should be documented in the release note of the PMD. >>>> It is a valid use case that the default traffic will not have RSS and >>>> only rules created by >>>> rte_flow will have the RSS, for matching traffc. >>>> >>>> Best, >>>> Ori