From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 69833A054F;
	Mon, 15 Mar 2021 12:25:59 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id CC5E224262E;
	Mon, 15 Mar 2021 12:25:58 +0100 (CET)
Received: from out0-133.mail.aliyun.com (out0-133.mail.aliyun.com
 [140.205.0.133]) by mails.dpdk.org (Postfix) with ESMTP id 7B5EE4003C
 for <dev@dpdk.org>; Mon, 15 Mar 2021 12:25:56 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=alibaba-inc.com; s=default;
 t=1615807555; h=Subject:To:From:Message-ID:Date:MIME-Version:Content-Type;
 bh=Q2ZdVOMiFT85Yukc5+s2GtNgvqEt50XR0TTd9+5jIgU=;
 b=fpNWiEbbkpIoE14LSkMU8LXu/2JVt2irjbMMz4igzrxTPrSEvfZF0us5h1nVyuWJOrzt0rgEz/rxCi0yjfdAXxvHXfKzRPsoUoNkML83uGFUxtn6iAltsznc1UAvw/OV0TDz3tmeRtPl6uFGTGPh7AiTmjyKViWSrx0sKxdMpbU=
X-Alimail-AntiSpam: AC=PASS; BC=-1|-1; BR=01201311R141e4; CH=green; DM=||false|;
 DS=||; FP=0|-1|-1|-1|0|-1|-1|-1; HT=ay29a033018047192;
 MF=huawei.xhw@alibaba-inc.com; NM=1; PH=DS; RN=8; SR=0;
 TI=SMTPD_---.JlJplhp_1615807553; 
Received: from 30.43.72.224(mailfrom:huawei.xhw@alibaba-inc.com
 fp:SMTPD_---.JlJplhp_1615807553) by smtp.aliyun-inc.com(127.0.0.1);
 Mon, 15 Mar 2021 19:25:53 +0800
To: David Marchand <david.marchand@redhat.com>,
 "Wang, Haiyue" <haiyue.wang@intel.com>
Cc: "maxime.coquelin@redhat.com" <maxime.coquelin@redhat.com>,
 "Yigit, Ferruh" <ferruh.yigit@intel.com>, "dev@dpdk.org" <dev@dpdk.org>,
 "Burakov, Anatoly" <anatoly.burakov@intel.com>,
 "xuemingl@nvidia.com" <xuemingl@nvidia.com>, "grive@u256.net"
 <grive@u256.net>
References: <1614797225-114594-1-git-send-email-huawei.xhw@alibaba-inc.com>
 <1615397790-16169-1-git-send-email-huawei.xhw@alibaba-inc.com>
 <1615397790-16169-3-git-send-email-huawei.xhw@alibaba-inc.com>
 <BN8PR11MB379559171764FF615E06D4FBF7909@BN8PR11MB3795.namprd11.prod.outlook.com>
 <CAJFAV8wp7jM6+j+mn7wzwLH_1gGRuC0NVgzv7t458A1ZteYEDg@mail.gmail.com>
From: "=?UTF-8?B?6LCi5Y2O5LyfKOatpOaXtuatpOWIu++8iQ==?="
 <huawei.xhw@alibaba-inc.com>
Message-ID: <e82a4810-2998-4374-ce27-99549e5070a9@alibaba-inc.com>
Date: Mon, 15 Mar 2021 19:25:34 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.8.1
MIME-Version: 1.0
In-Reply-To: <CAJFAV8wp7jM6+j+mn7wzwLH_1gGRuC0NVgzv7t458A1ZteYEDg@mail.gmail.com>
Content-Language: en-US
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Content-Filtered-By: Mailman/MimeDel 2.1.29
Subject: Re: [dpdk-dev] [PATCH v11 2/2] bus/pci: support MMIO in PCI ioport
 accessors
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>


On 2021/3/15 18:19, David Marchand wrote:
>> #else
>> #define IO_COND(addr, is_pio, is_mmio) do {           \
>>                  is_mmio;                              \
>> } while (0)
>> #endif
> We should not just copy/paste kernel code.
>
> Plus here, this seems a bit overkill.
> And there are other parts in this code that could use some polishing.
>
> What do you think of merging this series as is (now that we got non
> regression reports) and doing such cleanups in followup patches?

I am OK. Yes, we could do some cleanup after it is merged, for example 
against vfio, if it is really necessary for virtio PMD only to use vfio 
to access IO port.