From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-BY2-obe.outbound.protection.outlook.com (mail-by2nam03on0044.outbound.protection.outlook.com [104.47.42.44]) by dpdk.org (Postfix) with ESMTP id DEBB11B3A3 for ; Mon, 16 Oct 2017 08:50:25 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=kEh9HTT70YPj9QLe4bRMsvcwHWLsoPc2XxM6ocasK1k=; b=E6N2koTCFplmfKhDdqDrdO5Fnm0t2J+Ur6QfHiTK5oNTxhebUj9rfdSqdoVPtjcOcOudcAP8iiC1GRRCqhc1pTo0D83OQ5gg8EemR9fWThxoZ6x/qAcmS+Qsm5dSfL2miVzD+mPs3JcyWafoZJ+kz8z/42uS9be0+zriMHc+/LA= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Santosh.Shukla@cavium.com; Received: from [10.160.0.38] (111.93.218.67) by BN6PR07MB3091.namprd07.prod.outlook.com (10.172.105.9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7; Mon, 16 Oct 2017 06:50:20 +0000 To: Hemant Agrawal , "olivier.matz@6wind.com" , "dev@dpdk.org" References: <3e228854-d5d4-7dc1-6c25-29de7f6c37c7@caviumnetworks.com> <6bda52aa-6084-0db9-d78e-57019c2f1f7b@nxp.com> Cc: "thomas@monjalon.net" , "jerin.jacob@caviumnetworks.com" From: santosh Message-ID: Date: Mon, 16 Oct 2017 12:20:03 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <6bda52aa-6084-0db9-d78e-57019c2f1f7b@nxp.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Originating-IP: [111.93.218.67] X-ClientProxiedBy: BM1PR01CA0084.INDPRD01.PROD.OUTLOOK.COM (10.174.208.152) To BN6PR07MB3091.namprd07.prod.outlook.com (10.172.105.9) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2cc088fb-72dd-40d1-2d00-08d514622c94 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017030254152)(2017052603199)(201703131423075)(201703031133081)(201702281549075); SRVR:BN6PR07MB3091; X-Microsoft-Exchange-Diagnostics: 1; BN6PR07MB3091; 3:J/fx8dT5SEnbpywO9jMhnmiX3UPWe+vYaaYCh9HVMVe4pr31EZHU8jbswmpUsMxDIKjBGwJgaM3dH6WZ5u8zqFnLLln+6ihytJOz+4ovuZ60av0VZtdDqf83SuYNiIJdosVz7GQ2fEU7C4I9jXJZ/8zUyyZ44Q3pW+4M1afLy3Igfi/++LjdjiVBOuLJNkG3Pj/uZmb2vEhn27YdS9avpPlbF9HmLyyIn5rmDCJ/2AV0F9Pj4QJ9RukPF8h95O6n; 25:VBDYSth+BatvVevfOstXW9iciqnQjL7uybZ63adgLF6PKz6+BXkXotiLHIYhRfCxNUD2+Gqy8lgBQQ6GICQnRf1GAWFH7iELh1R5PCfIYjcpppuc8eup5v+OGu8I1BqIVw/Dd6WiJa+fJIHZcM+Sm3JAAeJrvlTWG8GR7TO2rrdeffURGo+XT3OqY6VpXMGZKAGhs1j2HM4zfBOPGKpNYC7YvI1WxdvfV3M8AxMZfVxQRB8oUXpZKQCQ34rjXZ8U1Gesbkm3a08IPEW8AhPvHc79RBoTt5ymkOqea43gpbD6Pg1SxPnfQHgdq+zJQdfenRuiBGiWo5pxkq3p/B+pTw==; 31:CrT2ENdizrrMArVYgkhErMG29vYY8PJJuceav8vIWPaw3FaSRj9RP13hQVQzm5s+nDKpUIlgmjgeC7qbpjiZSmCcQfzI/f9Fs6ibI6/LVAuJIz+VR63f7fhfo1N2zSDEz+HWZBzOzv9w9gcWrjjTufDXrjEdGWqwmMsfPq0qRmy9KqoCAeP9o31SV2ZzwjgeXRn23N2FMqWu7qYLc1yQvXZlSSzh1qjcg9I44ntmlGM= X-MS-TrafficTypeDiagnostic: BN6PR07MB3091: X-Microsoft-Exchange-Diagnostics: 1; BN6PR07MB3091; 20:T1wM7YDeVXmNrG1dO+sE42jIN+UkG1IIdz4NsXBCPAhaSN+elqxFyXRjYchOFvSRN69kty97E3WiqLSydVv77gac2iMoJIqzhmOtWUIQTIscIH4oWAF/z84XHk0XxJPyIzMXZYWC5OEKjkegDzXFAe4lpU+GAlD1JmdHP2LhwbCaRIFnXlt71sh8TF0WoUty/2421wQP9r1cUjigkDNOmANZH8aAYNWqYS4Rt1GRvcTPZreUexTOmT4dB2hXCpWMK0TphYIav8JJaMO06OfyewTicLDcpKuAZUu0JUd15+Sp54QpUcLT+8kJVqAOY13Ad/tAlRDvGLLmIbIQoxbKfPE2UzMyrns0YDapD2k4Mol5qEzPGQiFzCUAYmVIwGmWQkEO9CcHSujuy+b39ERP4wm6WECVFfNleI0slhnDVPHJfaWM39fxE2cadinjTxGYyTrFIds362Oc09HqnLe419wBf779NlI2iPKhXf0M1/TMc2jvQXjY1im3nxtlu4MzHLdWCPP38Ji50pq8Q7rN1MJyywrUi6WJED/BxoELUhY76tHxvTFmnRyIygyC9SkQCOJnJxO3XrDKkMAlx7qHPTPsPjVXHZvKu5m1n0a3BGc=; 4:DOimzHpeUAa/2M2rzmWJQa6o+4BZiI5q7uDKUBtdUY5435A7b3+0qxudRx8qNQaJ/5K2N7rfo77hE2UljRc5r4/dnzEfO8ZD60Jbz+VYD+xSclOKOtZuvX9Al4yMS+bBcqVqvmaELMxOMtISHHS5rOOWGsgnUU+HDCfWqDe2sASzQ3rMy+DZ8lxbSgxe2ht/O32uQaQyQs2Gtt2rWQSYVGg5R1y+A9NISDc+Hot+mwSh5iNoypkEl37MtTJMsvM1 X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(93006095)(10201501046)(100000703101)(100105400095)(3002001)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123558100)(20161123564025)(20161123562025)(20161123560025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:BN6PR07MB3091; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:BN6PR07MB3091; X-Forefront-PRVS: 0462918D61 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(6049001)(376002)(346002)(377454003)(24454002)(199003)(189002)(8656003)(16526018)(65806001)(53546010)(3846002)(6116002)(966005)(77096006)(66066001)(6486002)(65956001)(36756003)(110136005)(90366009)(58126008)(16576012)(316002)(31686004)(2201001)(189998001)(4326008)(2501003)(72206003)(64126003)(53376002)(97736004)(107886003)(86152003)(83506001)(25786009)(33646002)(76176999)(50986999)(478600001)(2950100002)(42882006)(5660300001)(7736002)(50466002)(106356001)(105586002)(31696002)(101416001)(54906003)(6306002)(6246003)(229853002)(23746002)(47776003)(305945005)(54356999)(81156014)(230700001)(8936002)(53936002)(81166006)(6666003)(8676002)(65826007)(5009440100003)(2906002)(68736007); DIR:OUT; SFP:1101; SCL:1; SRVR:BN6PR07MB3091; H:[10.160.0.38]; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; BN6PR07MB3091; 23:VO3Nh69N22iHY8HeYc//a2NiaoyUIgyPmoNmS?= =?Windows-1252?Q?0MawOMt6s5iSIOcxRKKo3E8wNxBrTiCOwMFXpuJvORghcg9n2hDHJaFI?= =?Windows-1252?Q?mZredJ7HM4ZFW8xiHTgK3SojFki7Wpl4B8reOMXSvMDWW+LdfQ39cvLg?= =?Windows-1252?Q?YBvihUER30ywd5BdexBv/RncIXvzu8IWMKXBUZy6BGH38po5BsQEcIjU?= =?Windows-1252?Q?v6aVCZrryk3IkTxK00weAvlnUelspEVnqMKL3wc9nLyFt3LCrh5bGFRm?= =?Windows-1252?Q?qu9yyauaCcWvubbGy3ofVsoQJOoVPLy08nYln1ObGilKwZcr1XclXfM5?= =?Windows-1252?Q?dTaxojEkIvlrHw260HCmYaHmwcPoOk6x9OoYBYE0Q7hl3idr+vXEtmUK?= =?Windows-1252?Q?DmW9Vo8CpJ4LjRdsECH1JOnK1tG0DEx9EMofcEGlc40AfSTMJmA9Nrkj?= =?Windows-1252?Q?cTo4lxqC6rzzpHyIMzvr0y7e8hcYOriDAYYDJCVn5L+yCF/sB7X7AyyD?= =?Windows-1252?Q?ht9FUJspIFhwPlCYI2TZ8SwvkSrZUFoE1HWbCUXVQICn01D/Efapvngo?= =?Windows-1252?Q?NFyvydZaZ3BCJsGhJGEoSwROMi/t4PA7HxBZQHigDc+grAU7CE033DR4?= =?Windows-1252?Q?rTxkBUFUSKk89Bg64JA1qcEIrVP54RduQBNm87e5eGTRJDtVvo2UHQ4C?= =?Windows-1252?Q?3ppk2CaXm0eW5qTUGv9mODgLU4lAMVbVXkMnOYnXneYxpvPiZN443jst?= =?Windows-1252?Q?fBC2DTx/pjxqaShzGOitPOC1MXgqiZj9EuTMj8y2WshLFF3zQMEyUmfV?= =?Windows-1252?Q?Fr7Q6ZYzKGzwWdgkG5GLTAfciCMNmfWxNWOV84GrVZnFZ03pqzFXMws5?= =?Windows-1252?Q?Iarpnl1fJV2efUnsJ1GTWtCSv0h6m874IiTU3M6X5weJrH5yKDQ4CKAV?= =?Windows-1252?Q?/BIG1YE2i5gtBWxTkfAf+9PhkglU+JgNwRF4ky4kAXIizcTprnaJVx8v?= =?Windows-1252?Q?bTcsOzkwril0WOVstoMt7E0lNMBgr/xIl6wpvnVxR+Jtc/mvsiabmf/u?= =?Windows-1252?Q?pHR1icoUAh3pC6C0k8Tg61Cs6FBBl1ZiErL0tS6r4Bmttn7MVprB4mGl?= =?Windows-1252?Q?F2qFcUR3m28DavNoyfruubImBrbfh7yjK5dU5pzLsERs/qULmAyJVfks?= =?Windows-1252?Q?+rwwV2VAKvEvng71FdOvCncrolv/NGJyPXCIHfKBfmeeFO9Pgfj1swIP?= =?Windows-1252?Q?SobQ62jgycZxBaNtnSNEwXlgjFjD6c/1vUOyb5c6c0S8+nsw1FhPBTIb?= =?Windows-1252?Q?10j/2vLr9UmoVO+QCitLQ93oHNuJA+hDKldUJfpdW7jVDUrHW708m9hP?= =?Windows-1252?Q?Yn2oZB6viWTVDCuCtOUiKY546XzFRJvVfPkbjehDjBie1LDJT+/zXkvH?= =?Windows-1252?Q?SuPeR3RH5Ao7QeS+0WYaTYcz964Z5SIGqawxTaHw5IH+qCXi7Ezcx/2O?= =?Windows-1252?Q?uG0kmUXfKBWvEBF+C8yKMgKewC1r362Q+Nc/5ZR77ScqaAsPoTZcZmDW?= =?Windows-1252?Q?850uMeprFiN4SQFPdBRWIfuiYKURLBOdzCjCYr/CahBRmGWnlYX7mzbc?= =?Windows-1252?Q?sHKrv2NxSWNNn5ZeL1fmaezYVEXdubDgUMUPjVtqmvbU3icdk5WRUwRF?= =?Windows-1252?Q?V173n7Kt+1R29Dm5Ec4uPVR8MQubpSyPyVAr5hwps0EmHsMUDJv?= X-Microsoft-Exchange-Diagnostics: 1; BN6PR07MB3091; 6:dApeymOcJzrEvfPj08G7QkcS4MkQ2SjAd3prP+BE6If4301QJKx/cc5ICO0dm6Ft2MwqhQl985Ld1wasdUO4hpGsIETbXENOkzf1QXxAoGz8fh+F8PquM+6Z/8MgwFYoRz4j2atjG2MRUJRsF05v2MFq5azHvIUAy2V7ZkBwlqO6VxeyMvSeQONuhYG0PGcGhobUWsoGwakvWBme/K1B/ETJJlof+8lRKua5D+/3cLxBGT2X3oM9SpyzxbupsAI6zfKcV6mtV+NEQlfDxpZ02v8+FDkrQSu0Db8/2PHZkDNS2mQea2SorEk+VegYMZ3Q7ESi8qBMXzULrnFtyywzaw==; 5:NoZsJNn0SjIL1mFLpLqvf1YsczpNUvF2tu0mvwXEKKwFetB4utjiwKITEI4gYVGgxwQyjX+dzvshSn8A8yo/JeCI8IiIUf56hoBA1YXZKzX5s9KukRzedKK9+rBP+RHgxlHh/8ye6niVcqiBob/YqSbiaDt/0ncC1jZ+wWEYmdY=; 24:/UsCh5pFZJTTcvQYHu+aW0haDzwgs/vDGbfwzJ6X33OTzdrzirKXUTDELdaNkDEJZ2ialpfB/vCH7j1lU0HsNTpvz1YLmdN6PfARreDGy74=; 7:44xiUoMFHgOkDTM/GxS17r27ELDtz8H2+AY0PTOouS/gzB3gEb2zUpmMTGOiorlN1+wce9YX25mKI44a6xJnBFLb6VBxhFDqFoN4MDM1Flb+wqFKSekZcPZ7O6lorCRLoJRt+H9sGbjDYaNRled4HHbYYkC5aPVisYIQFM+JOMAAOCvipMnegz76LOwLCRLylTJ2PMaQnYKaZmoPPCx6vJNlrP5WSSz7EQJQPt/MOo4= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Oct 2017 06:50:20.9895 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR07MB3091 Subject: Re: [dpdk-dev] Shared compilation issue - mempool/octeontx: add build and log infrastructure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Oct 2017 06:50:26 -0000 On Monday 16 October 2017 12:18 PM, Hemant Agrawal wrote: > Hi Santosh, > > On 10/14/2017 8:57 PM, santosh wrote: >> >> On Saturday 14 October 2017 11:37 AM, Hemant Agrawal wrote: >>> Santosh/jerin, >>> Your patch "mempool/octeontx: add build and log infrastructure" is causing shared build failure for NXP's patch "event/dpaa2: support event eth adapter", which is still under review. >>> http://dpdk.org/dev/patchwork/patch/30248/ >>> >>> In your patch, you have added mempool to be dependent on event, which is not correct. >>> >>> "+DEPDIRS-mempool := bus event" >> >> Yes, Octeontx needed mbox definitions and it was defined at event area. >> >> But You are right that adding event dependency in mempool may create issues >> for future feature like you mentioned. >> >>> Ideally, if you have common code, you should put that in bus or mempool . This way you can make event, net or sec etc dependent on bus or mempool and not the otherway around. >> >> Right. >> Proposed change for makefile will be: >> >> diff --git a/drivers/Makefile b/drivers/Makefile >> index 3a5b22342..0467250aa 100644 >> --- a/drivers/Makefile >> +++ b/drivers/Makefile >> @@ -32,13 +32,13 @@ >> include $(RTE_SDK)/mk/rte.vars.mk >> >> DIRS-y += bus >> -DIRS-$(CONFIG_RTE_LIBRTE_EVENTDEV) += event >> -DEPDIRS-event := bus >> DIRS-y += mempool >> -DEPDIRS-mempool := bus event >> +DEPDIRS-mempool := bus >> DIRS-y += net >> DEPDIRS-net := bus mempool >> DIRS-$(CONFIG_RTE_LIBRTE_CRYPTODEV) += crypto >> DEPDIRS-crypto := bus mempool >> +DIRS-$(CONFIG_RTE_LIBRTE_EVENTDEV) += event >> +DEPDIRS-event := bus mempool >> >> include $(RTE_SDK)/mk/rte.subdir.mk >> >> Can you give it a try and let me know your feedback. >> > > This change breaks the octonetx compilation. > You may also have to move the the common code from event to mempool. > Yes, I missed mentioning that part in earlier mail. We'll post series soon. Thanks.