From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-BN3-obe.outbound.protection.outlook.com (mail-bn3nam01on0087.outbound.protection.outlook.com [104.47.33.87]) by dpdk.org (Postfix) with ESMTP id 27F9F6D45 for ; Mon, 11 Sep 2017 10:41:49 +0200 (CEST) Received: from BN3PR03CA0094.namprd03.prod.outlook.com (2603:10b6:400:4::12) by MWHSPR01MB180.namprd03.prod.outlook.com (2603:10b6:301:7b::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.35.12; Mon, 11 Sep 2017 08:41:48 +0000 Received: from BY2FFO11OLC001.protection.gbl (2a01:111:f400:7c0c::142) by BN3PR03CA0094.outlook.office365.com (2603:10b6:400:4::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.56.8 via Frontend Transport; Mon, 11 Sep 2017 08:41:47 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BY2FFO11OLC001.mail.protection.outlook.com (10.1.15.185) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.13.11 via Frontend Transport; Mon, 11 Sep 2017 08:41:46 +0000 Received: from [10.232.134.49] (B35197-11.ap.freescale.net [10.232.134.49]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id v8B8fhBK010206; Mon, 11 Sep 2017 01:41:44 -0700 To: "De Lara Guarch, Pablo" , "dev@dpdk.org" CC: "hemant.agrawal@nxp.com" , "Doherty, Declan" References: <20170728110738.28922-3-akhil.goyal@nxp.com> <20170829065849.11424-1-akhil.goyal@nxp.com> From: Akhil Goyal Message-ID: Date: Mon, 11 Sep 2017 14:11:43 +0530 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131495929071978140; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(336005)(39380400002)(39860400002)(2980300002)(1110001)(1109001)(339900001)(3190300001)(13464003)(377454003)(199003)(24454002)(189002)(2906002)(8656003)(65956001)(65806001)(2501003)(47776003)(305945005)(8936002)(68736007)(104016004)(8676002)(81166006)(81156014)(50466002)(53546010)(85426001)(83506001)(36756003)(76176999)(50986999)(64126003)(230700001)(54356999)(498600001)(54906002)(105606002)(2950100002)(33646002)(53936002)(6246003)(4326008)(31696002)(86362001)(106466001)(23676002)(4001350100001)(97736004)(77096006)(356003)(31686004)(5660300001)(65826007)(189998001)(229853002)(21314002); DIR:OUT; SFP:1101; SCL:1; SRVR:MWHSPR01MB180; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BY2FFO11OLC001; 1:ip7mSMY1ZcnpD6mq9W6ZpYb+UBvfJmjNlWKgbNsBz/5KsYCrQL/Pf8XBkjqI2il4D7BcPdflku5B3bLsWhlaeRtJW9MMw0kGZIuk6S0dm7waTj8L5v0HTKUlycCOsFy1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b1721198-49a0-433f-bba4-08d4f8f0f022 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(300000503095)(300135400095)(2017052603199)(201703131430075)(201703131517081)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:MWHSPR01MB180; X-Microsoft-Exchange-Diagnostics: 1; MWHSPR01MB180; 3:1spATKuLSu2ccvEitGB+ldMT+uC86Bw+viKN9lviKUCSrwi6e1iolggf/ehXDoP5P9mlZ7GZjgpjBSLzlJPz3+RCYdkisreJV3LDCB6N7XQbpRfwrYUrhkYG6KRCsUnORVpm9xTaENCbv7VApiJhYEafBxFU+G49xceyr6YO1bhrfhH2lIwKiEP/iSDM9lCjWeZ0O6LsEPibEjYNfswgz9oj1mXdu2Z6rD+CsoWWvrcpNW0l2L8PTB6WiwsAfAU6ROZQ6A2XeSVdoxHwybn9JSqJipHGC3nWrGiFyOqoqcz4deG3XnfQVi77EzdADkXuIfMioyftkby/GHyzUzQKAk3UxHfy56FoeIfuVE2qHrU=; 25:0TKCQx7RXtaeCWUhd1gXqa9M7FPiMIY3NwKt7rtUU+2K5vka1so2f5hamBrUYmMnKzVNw7Lv/AswH2+3VdLIIESJLKM1eXBON1IMLbu3V73MaAsufgZ96D4mvlhiRaeKwUHT4rPC47c355FbmA2rJ4ZX/vyo0HxkOcO8Wiv4UiEBzoVFoaXN9nfcMtEVQQlQUKaOanW/jw1d49gQAqPHg/si1MsTxibc1vJsFQcoQ2xPKFSGC4xWX6Oi305DXXh+ol3PUzLp0rZDnoCp9TAnld9S+iqIsWsjl2Jib0FufCXc1GnnORdHW0Yyqt4jCCyryLOt5mErgi4BZb3j0Kd3Qg== X-MS-TrafficTypeDiagnostic: MWHSPR01MB180: X-Microsoft-Exchange-Diagnostics: 1; MWHSPR01MB180; 31:kbvQZU3Iv8WSYSnHD24xPzcfED1jjmmZGLSKT0Fy0LSt+vCjyDM0hqw4eFbe+P9k3jy1+B5kO8pGwXUjHjXmNrYFexJjOI+T0ubxhIXtG0hAGVsqqrLpT0ezqDAQHBgzyxbPcOTb8TuJ3XY9jebhOMMFVJf6e6QVl+AFe9ynlr/KTXey9uSqqN9h47tR5Te9kIKdTfTaqXiv6Q1BH8mKbiDBGndUNJGOwlwtwxUcZsE=; 4:DnITnXKJrUcbReg9C5nVX/9gc+cvd0pl5rZv4Nz0aAQayjdfwwHeBVY8MBrCwlvnY+vVNMawsLgcH/a09vRApTtI7qmR2aPvszFiYCm9/S2hgCQ3FoUX1leIelncJGAT78zBlhokJ+zs2QO7to8C0O+9a5QhGIAoTwFdpbMMO3dMtRC8lZN7MkN5dMgtziAYRugsiMhtA/5HrLdYTvMVKCo6H0vIz/K4l8ElLgUu8wLTY6mEQiY2ukGthhPd453CrmbyJp/vsAZXwZ5NUY/3AeFbrWo5/vyeLAMBE97hD6yQO90pi4kDvuzDm0q6lobwdu41pAB9dBWcxXdDB2poFupol/MKa/hOYEw7VlSnIwI= X-Exchange-Antispam-Report-Test: UriScan:(185117386973197)(788757137089)(228905959029699); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6095135)(2401047)(8121501046)(5005006)(93006095)(93001095)(100000703101)(100105400095)(10201501046)(3002001)(6055026)(6096035)(20161123559100)(20161123561025)(20161123563025)(20161123556025)(201703131430075)(201703131448075)(201703131433075)(201703161259150)(201703151042153)(20161123565025)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:MWHSPR01MB180; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(400006)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:MWHSPR01MB180; X-Forefront-PRVS: 04270EF89C X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtNV0hTUFIwMU1CMTgwOzIzOjB5UTBiRmRmbFA4TmF2VU0rSHord3E5WjQ4?= =?utf-8?B?TGNFdmJHaW13ZjU0U3p6b1pHNk1qb1JHSURPMjJMU01KYmhsY2Z2TWw1bnVh?= =?utf-8?B?ZS9sR2JmWnQ3TEhpcXAxUG8vRUhqazA1YXB1WC9rZ2pNbkVQS2VSQnZ6aEo3?= =?utf-8?B?WU1CNGZZK1RwTjNtQVZpRnZmZlZDUTdLNmYwVVZxYXl3REMrVG4wTjVuemFT?= =?utf-8?B?MEQ0andtTnhQR2FWYmNiZkIvRTAvSXRuaGtZZ2FYamx5TldvS1oyUDJ2djBv?= =?utf-8?B?WTFKTXN4UWZ0RU5JRXlPV203anJ4L3poY1dzMzdydVBPTmJNQ0xNQTMxZGk5?= =?utf-8?B?Wm51VzU5MlB4NDA4aVBiMlZ2TGZhSVMyTktBUlROS0czcEFWMTlhbG5DemlG?= =?utf-8?B?WElITmRxQTNkaFV3dmZGTlNTd0dSWXVPdGw5bjNRTnVKRkVuVGhiQ1hyUEp5?= =?utf-8?B?WU5CbEZnbWRxa1JIRVUva0MyWFlVMWZWSnJKY3dzS25WZlhsRm1kbDlwenlq?= =?utf-8?B?WUQ1a2lQZjR3MjJVckQ1WmdkU0oybG0ralA0bVdzQzUzWC9iSHhERUcycm9G?= =?utf-8?B?SW9qQ0tza1RMeHZsQjh3amxIZSt6cXZyZDlOYzEyU2M4aytVdERVQ2RHT1p4?= =?utf-8?B?bFhvZE5vaDI1NERMOHRjYTZNeXdBdmtpRHJ5NGJpTk5NbFVIQUJyeDZlTUVu?= =?utf-8?B?YmoxL3JJTVJuZ05ONEh3ZkdmS1hBUWVmRUR3MmZreFhDa3RKYWdzOHRyZ0hP?= =?utf-8?B?TG5yb1lFSkZxeTdVVVpsZ3JnYzkyUGpSUlJBTzFSTG1pWnlyZldNZE9wQVIx?= =?utf-8?B?N2RZLzU3b3hrUk5GcHdRQkpCYkVrVnZ3Mjl3MHdxTkkwQ0tGdFhoV0JURk9x?= =?utf-8?B?WktLeVBBWnJnZUt6U0tXS2x0WTFSajZKV1k4VW1HQU1lUTdja2tuMVB4bGhi?= =?utf-8?B?dC9MTG1vajNwdzRHK0NjeFB0ZmF0OXFvTEM2ekdTWERpU285NHN3NEd3a2tO?= =?utf-8?B?QmpxdlBWU2twcXFNQkNqN21lbXMzUXNMMGJpK0VhZVBWdDA4K1dlazVZb29l?= =?utf-8?B?Z3N2UkhHb3FYZWZLeHFCV1dmTkN0K09RbGc4eGdST21NVkhiUXI5SzJ5YkhI?= =?utf-8?B?dEZTK0NhSUVoejF3YytXanhMV1VmREF5SnJyeStvVEFtRWkvMnVqd2VaUlVk?= =?utf-8?B?Z3V0eVJnVENjeUJSdW4yNUtFVHVhUEFtdkVnL2VqaTlUUGNrZGwxOGU4Wm9D?= =?utf-8?B?NjBCWDhPemtRMVlBQVAwUUU5dEd1Z0Z5T3pzWnJtbjltYnoyNDJUWW94R2NY?= =?utf-8?B?eEthVGF2cDc0cEV4Z25EdFNDSndKTjkyVlJtcW95cm9YR2VMTXVMMmlFVlVy?= =?utf-8?B?Q0lLRlRqWFNNYzlvVncwS25JQmhhYzFZRDFiUmlXbHFFL3pnVm1yL0VLNHEy?= =?utf-8?B?UjNqWXVTTEtuMk03M3lCdUFIOG4rREU5ZXIweUs3SFN6cno5NEdFS3pZdm52?= =?utf-8?B?UEVPdENnVU9CUXZDeXNZT1IvditHaG13TXZnSktoMTFnZ0NyVytyZ0VadGoz?= =?utf-8?B?MDhDeDJqSUtlOUlpSzdDZXlmUXAzMHRNU1lONDBOSWViRS96d0lqdEcya3Q3?= =?utf-8?B?YjZrMWpTU1NhR25jNExtTWxPNUdnYlZtY3dHYktFVUs5OURIUmp2aG56eGNN?= =?utf-8?B?d1JEU04rcnk5bmc3SUcwY2hRR3Zhc2NmbjEzeXVCN2syb2g0YUNNSVQwNGpz?= =?utf-8?B?VTk3YUxmL0I4aS9vS2V0ck45WVJ2WjBRV0daSUdKbnJhUS9DWXVDVC9RYjFI?= =?utf-8?B?VGZpOWVacFNKZ0t2YTJQT0JGdzFMZkNOU3QwYUtVdmpXMHlRTmZmcm5yZFA4?= =?utf-8?Q?0A53hMEAUlT+saVwFfQCyVbe9YC7akFa?= X-Microsoft-Exchange-Diagnostics: 1; MWHSPR01MB180; 6:nOffAMqwxx6bKGkVIFSTEyeYDbz+wDXy8Tua7vYa0i4mJjn3H2JjbYLOq6VD/aV2Ps+s0FJFyFHTm+BLgO99tKmg2qCauWfYIu9rleiWBM01NF87E9mcspWcrgaj4uk/bMml+9UqSfblSS/4K/kh52pluYcG1m7Wy97JsgGRQystG9HKHiy0bZwdsW2jxYOTbi2rpkxgDreH0twYdwnzYWrjxq8APQ9CJ1kGu3jYoJbo/K8VLV5/KQDRvArkk2YNIf3vg4P+2DUs1/k+60Zw1RyUZRoc+gPpBxnMPnmZXJeoZxOWUbYpLiwlM9hP+fYdw6hKF1xVnZmVJXfCzXHRdw==; 5:iZSuvBjkrfJ8u5Xrovlf0aH0kdSWIIs6mRMN/VXrsPvWyJ1ZLqoUjEvECv0tlrkgrhNgqWEEh+j47Wktk5VWTTVTXSL34zXU+LQ2m/NsCOKOdtCMzZlDrVsniyp/VpO0V0epE1GHhJBUC7zOyCo/Ng==; 24:9Ej6V00jyOTK89YSRKvduTG8BST0LSCyAEVLTdvxKoJa0KzbNVz4eSrK82cSMKEYC1FIh0YFGdmsAH1ZOF5ZA/jlAm5Gzd37hiXKQPJ39ys=; 7:P6fY3+f/KWun2yvHnpY3AGAe5eUBpxFGq7pronbQA6GlCRoS5zw7TEYIVJXPxHFhOoxAUj5NedF7EOZVdZSdMZU9Y84HTlDXDyMolaRgBql0H3ABuoX4ike6N9t6ikp/9NPs+DUYbwpgggwOwmNk16Tha4JUnYpDe8cOWlxKsxWVa3PR2HijLeiwsdlM7tmWaDA0O616zqEF3MM+AT06j2yQabL/HXXWluBUKUk4C+c= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Sep 2017 08:41:46.8390 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHSPR01MB180 Subject: Re: [dpdk-dev] [PATCH v2 1/2] crypto/openssl: replace evp APIs with HMAC APIs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Sep 2017 08:41:50 -0000 Hi Pablo, On 9/8/2017 7:33 PM, De Lara Guarch, Pablo wrote: > Hi Akhil, > >> -----Original Message----- >> From: Akhil Goyal [mailto:akhil.goyal@nxp.com] >> Sent: Tuesday, August 29, 2017 7:59 AM >> To: dev@dpdk.org; De Lara Guarch, Pablo >> >> Cc: hemant.agrawal@nxp.com; Doherty, Declan >> ; Akhil Goyal >> Subject: [PATCH v2 1/2] crypto/openssl: replace evp APIs with HMAC APIs >> >> in case of HMAC the openssl APIs HMAC_XXX give better performance for >> all HMAC cases as compared with EVP_XXX >> >> Signed-off-by: Akhil Goyal >> --- >> changes in v2: >> patch split in two patches as per Pablo's recommendations >> >> drivers/crypto/openssl/rte_openssl_pmd.c | 37 +++++++++++++------- > > I just come across an issue with this patch on openssl 1.1.0 (below). > Unfortunately, I have already applied the patch in the subtree, but if you could send a patch to fix this, > I can integrate as part of that patch. > > Thanks, > Pablo > > drivers/crypto/openssl/rte_openssl_pmd_private.h:168:14: error: field 'ctx' has incomplete type > HMAC_CTX ctx; > ^~~ > In file included from drivers/crypto/openssl/rte_openssl_pmd_ops.c:39:0: > drivers/crypto/openssl/rte_openssl_pmd_private.h:168:14: error: field 'ctx' has incomplete type > HMAC_CTX ctx; > ^~~ > drivers/crypto/openssl/rte_openssl_pmd.c: In function 'openssl_set_session_auth_parameters': > drivers/crypto/openssl/rte_openssl_pmd.c:440:3: error: implicit declaration of function 'HMAC_CTX_init'; did you mean 'HMAC_CTX_new'? [-Werror=implicit-function-declaration] > HMAC_CTX_init(&sess->auth.hmac.ctx); > ^~~~~~~~~~~~~ > HMAC_CTX_new > > drivers/crypto/openssl/rte_openssl_pmd.c:440:3: error: nested extern declaration of 'HMAC_CTX_init' [-Werror=nested-externs] > make[4]: *** [mk/internal/rte.compile-pre.mk:140: rte_openssl_pmd_ops.o] Error 1 > make[4]: *** Waiting for unfinished jobs.... > drivers/crypto/openssl/rte_openssl_pmd.c: In function 'openssl_reset_session': > drivers/crypto/openssl/rte_openssl_pmd.c:588:3: error: implicit declaration of function 'HMAC_CTX_cleanup'; did you mean 'HMAC_CTX_get_md'? [-Werror=implicit-function-declaration] > HMAC_CTX_cleanup(&sess->auth.hmac.ctx); > ^~~~~~~~~~~~~~~~ > HMAC_CTX_get_md > drivers/crypto/openssl/rte_openssl_pmd.c:588:3: error: nested extern declaration of 'HMAC_CTX_cleanup' [-Werror=nested-externs] > cc1: all warnings being treated as errors > make[4]: *** [mk/internal/rte.compile-pre.mk:140: rte_openssl_pmd.o] Error 1 > I will look into this and will send the patch ASAP. Regards, Akhil