From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AE46E41D40; Wed, 22 Feb 2023 17:36:12 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A090243135; Wed, 22 Feb 2023 17:36:12 +0100 (CET) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id 9EC1443139 for ; Wed, 22 Feb 2023 17:36:10 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1677083770; x=1708619770; h=message-id:date:subject:to:references:from:in-reply-to: content-transfer-encoding:mime-version; bh=AreyXIwQ1KO1HvPjz/QnhCur0yevCywz9/0I1CIcu+k=; b=Bsc5QtFS+RnWEJrx4je5NqFrfgAjZn3oGDjcVhPP6wHhuK4JZ70XoZQL WsRY1pFG7izW23P0tPqLTO+enXfCjmgw80xAXEaBz7qPKL6OwhZkgwKNS AqUYbZrk6LJNfxUt/Kdq8FCvuo/ZQv5QdU6HeAuuUvwxYFwfgc2mTCs7G LrJ8+rkXQkj+lKMuQUMc4ulMscM46aDaFV1m3ie8UkeH3eWw1kcOTzNBi 8/XBsRkDyJ2VzrFO0seAx4O9nRt3tVsCdkAt+mH0ZdgZehFZDzwNWiR4V WSmmhu5yCYiT0xQU4dFO4lyVBBSdHBFEGRkl6J14Y90D/BoUEvrTNGwLo g==; X-IronPort-AV: E=McAfee;i="6500,9779,10629"; a="331639407" X-IronPort-AV: E=Sophos;i="5.97,319,1669104000"; d="scan'208";a="331639407" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Feb 2023 08:36:09 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10629"; a="704515832" X-IronPort-AV: E=Sophos;i="5.97,319,1669104000"; d="scan'208";a="704515832" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga001.jf.intel.com with ESMTP; 22 Feb 2023 08:36:08 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Wed, 22 Feb 2023 08:36:08 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Wed, 22 Feb 2023 08:36:08 -0800 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.101) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Wed, 22 Feb 2023 08:36:08 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Y4yCc3EAyfxPzBhPKWyZkjekB1QwHFDfPbiOxg2Id6re+FPdPc0lXFEUmYs5/++4SHYXyh+oTiIMPM1PjyI2VpO/H+fajEz6SrJbErwGUG/wSo7E3BWtKPa0IpFWDvmOjfkcTtWVdxnmTq0xuuy6KIXeL3vE9F1yGlS4DLVeuVfRC6fzw2OXDhgPziJ9igOggKsahx+HvcBYdwCxkg4rusDOHDYQL2e9/T1qcvNdbkBlYKrUXYfNeqnEWCJVQANNqDEVlVJe8IBLuns8V194KvIChK9XJRl4QDFU1QDLtsjfRFoOK33tUoy/qAWMufwA257I0VZEZQ6PSmy9RiDaow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=12K7ywIZ+XXElds1t54xPmW3GmpzA3IJK68uy5ZQEgs=; b=he6BaZbaqftQNYNdxvSoGXywg72OwC82NRsGftE7CbP0iC7V/ZF25IYo4iMsYIPaCaw/kYtYa+lgampgR9oboVqJ1y9l19LkbwAZrtCPopxuLsVWTvPiahP+Z4i1cVGKevw0hDUV6Wa3rwcTaEdubeqcTUEuzU7uLk4BUhy175iyxbiRrN7ydMy1Z4btlTGehNncIy4nsPtc0bm0+l3ESgVoVww/tPXQETaBz1jwXjTlCacbaCmOrZD+/dzRkGi6iugZThqkgKajgq5SpLwr7zeFI1MtvVIpCoq6/LYHgRY//hRD83xs/U5m3JfC5ug50Gx4OjSAqOsm8ytHVQ7PyQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from BYAPR11MB3799.namprd11.prod.outlook.com (2603:10b6:a03:fb::19) by BN9PR11MB5388.namprd11.prod.outlook.com (2603:10b6:408:11d::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.19; Wed, 22 Feb 2023 16:36:06 +0000 Received: from BYAPR11MB3799.namprd11.prod.outlook.com ([fe80::4242:36e2:5a81:ff49]) by BYAPR11MB3799.namprd11.prod.outlook.com ([fe80::4242:36e2:5a81:ff49%7]) with mapi id 15.20.6111.021; Wed, 22 Feb 2023 16:36:06 +0000 Message-ID: Date: Wed, 22 Feb 2023 16:36:00 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v10 08/22] examples/l3fwd-power: replace use of RTE_LOGTYPE_POWER Content-Language: en-US To: Stephen Hemminger , References: <20230207204151.1503491-1-stephen@networkplumber.org> <20230222160802.123611-1-stephen@networkplumber.org> <20230222160802.123611-9-stephen@networkplumber.org> From: "Hunt, David" In-Reply-To: <20230222160802.123611-9-stephen@networkplumber.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0055.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:153::6) To BYAPR11MB3799.namprd11.prod.outlook.com (2603:10b6:a03:fb::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR11MB3799:EE_|BN9PR11MB5388:EE_ X-MS-Office365-Filtering-Correlation-Id: 1d775dc1-3c6c-4389-28fb-08db14f2e505 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: q2btpgAOEu0aVT19VHHIBhgVAZzcFAmhioY/IkReG/tOWU6dOBF8Gl2OeEDGBocnXzwmcfF0rKsz7xkR/swnWyKvp6E6/N+6hCwxItMmN06kHDt0YCW1Db+qUX3mF684JqW/Gwb386dG3yrj8NgMTzQ7JlE/B3QEa6LTO2sNrWxalJJ7CzHpoUyJOmtLSZQA54L2vJ6hys1j8dwS7hoVo0Ypudo/u6IDyqWmo0RlLyYl6QlRnBYIBif5L7OMoVX0mu+XA2Bv8y4C+4B34jfJoGVUOGEOSrkKQfVaLdNreO2UNib3Wbnb4UwtAbFvI46UlqEoToNZ0GCn5MS0HSBjQFa4avlygMRn4YEGMHjwXN51EoVGl2ZpXowSpDGhXSq9VTst6YQLX7Y8TVJxU8VrNkkhyz43kpRTHLpu2T0bQbstq+l2mO5s6Dv8iy9b5r71WkTX8tpJPDvlytX6uo8aGBAPx6Z5N3LDfn7HgjAPMbLyePfT6HNG3wFykk4be8lHRJWvQnBzMKVQt6dujWLpv86ouzAfQaMXcHa8BSsz2vthzgVNzB6w836ak+GQJe8QFb8MR5uf1/1TrvArcE1mFEaeo09bVywLdo8B7Wclru3TnWr8tL4dJkOB3KMnhvT6LYfdL5NOIdP2SGv6lD5O+gxmoFE/qBbp4aoK8RoItgFVgmA0U0j0WTKLvL/ZO9qt3TImwo6XnaTpOojtEvLznfqQ8usUBWycnKBSM9eyZts= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB3799.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(39860400002)(136003)(396003)(346002)(376002)(366004)(451199018)(6486002)(31686004)(83380400001)(2906002)(36756003)(5660300002)(31696002)(41300700001)(478600001)(86362001)(6512007)(6666004)(8936002)(53546011)(38100700002)(2616005)(26005)(186003)(6506007)(82960400001)(66476007)(66946007)(66556008)(8676002)(316002)(43740500002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q0ttdEtYU2FHd3FoN0tEblkzSlROcm8xQWxQWklTekdmeW1aNzNDTTd2Mmxp?= =?utf-8?B?V29UdnJKMTJJaytSdDJCWkk5Y2hGR25QdmFoeG1oOGhraWZQNTR2SXNnUGN2?= =?utf-8?B?aWEzTHcrOEhDNzdTcFh2eWo4dTJMVjZ6eDRxanR2cXROMUVZUVNJZGZaTitL?= =?utf-8?B?bXp1VFVxUzRNalMycVpxK3FWYitTZ0hZM2lpSFJNdVprQ2MrV0NCSlFybGFi?= =?utf-8?B?eUxubnFTTUdzcVlKclBEZldYYTZjc1VGbjZRUE54S0QzaEVoNzk3eFRLaTVC?= =?utf-8?B?SjREWG9lVitacllBcHpmb0ZNZzdrcXFTem9XQU5mazV5MWZuZFFpQzVrK1kz?= =?utf-8?B?eWFVTmdrdE1oVVIvbFp3QXh5SSs0Y2xRMHJpS3gxTTR0MFZGR1JabUNmNjFk?= =?utf-8?B?dzR4QXFPN1ZoM3F5dmhlbmU2b3BvN1J4Sk9NMndLenZFekFCNU0xL3VKR0Rt?= =?utf-8?B?M3g1SmlJNmhERlg2WDdXcjRBdVYxdU05cFB4UWpwbFVjbGlLamc1Ujl6RGFN?= =?utf-8?B?allQRm9mVlZiS3lqa1hjd2lZM0t4Y21tRU5wOWkxV1lNT0RGVW4wbFJidkFu?= =?utf-8?B?TlNNakROOFZCZUlZd2x3NXRxWFlXRThYUTZlcTBrN1JsemhrbGZ5eEI1Y2JD?= =?utf-8?B?dlNsbEF5d3Z6RDcrNGVnUFBWUU1VUWp3VzFKWXk4OGw0N04zSlFVNVR6dzIr?= =?utf-8?B?dmNpM08wdk55VmZMOEtzVURwMkhEemxxcEJmQXBSSUh0YXhsOTFMTjlXM092?= =?utf-8?B?a29WeUNFZEE1Um5VY09hZWhVRzJIRkxtd3Zockdrb3ZFM3J0RXN0NTZFMGdX?= =?utf-8?B?M2k4ZWtPakpwUzNmU3pBVW82eGw3OUIrdjl4MlJXY3BjeFF2QVdJZlo0Q2lS?= =?utf-8?B?Vi90Wkpwelo1czlRZnBzZ3hLTEFzR0ttQ2ZvR0FNVUhQMDQzeEw3YkVvVDNY?= =?utf-8?B?M0ZiYmJlWGJKR2UwSG5CVnZHQTJxZWxReWY0Y2JscnBvTW10SytjNEVkcHlj?= =?utf-8?B?bGJvNFJuY0ZzUmR1NEE2MFduT0ZyeXplSS9na2JCYXNiMU9TcjViK2VvdnV4?= =?utf-8?B?UHhsMHAvQ0dtNjhnRVZLZTZxOFhmVWRkU0cyQ1QzZUZKelpVNWR0LzkrUjVu?= =?utf-8?B?d2d6M3VaejhWaXRySkhqNzQzVlozVVFBQitVa3dVT01BR0tONk5sSGxZUmQ1?= =?utf-8?B?S2pFVnJuOStIWlYrMnh6cE5pSGdLaVo1WVNISnZmZUlLR0JlSTl6UE1ra3V1?= =?utf-8?B?N014bVRQQ0EzTjBUYWJuZ0FoYmVsMW51RW5IYlRuemhnd2Z0ZTd3WHJZUHBD?= =?utf-8?B?eEJWZ1JqS0wwdDFxQWxzaEFtZmpIVTA0V05rUUh1M3JacDMrYkpRcFpyWXRl?= =?utf-8?B?UmFPYlFWbVFXSmpBSmpuY2pGWlJMRFEyUjgyZFVueWF6d3N0OEZSVGdHY3k1?= =?utf-8?B?RUI0VTJUbDFhcHBUbkJMeG41SVU5NXZDWTBtR25FMlA3RWRQL0pNdUFjL2xQ?= =?utf-8?B?NVpUSmFsVkxMK1VtbVhSZTl2NDBST0FTMC8zYjAzbk1JWTY5OUVXNU41aDlY?= =?utf-8?B?N0cvWmdNbC9WWjBKeG1EUks0VlRsbXFvQ3YvaW9CK3RjSVhqRFFTU3FMTGxQ?= =?utf-8?B?ZHBiZDlaVG9HMGFzcDlGNTZrNHFqa2o5K3MwRXpXTWpyTmR0UTR6dWRhbUZt?= =?utf-8?B?SEh0am1aNTFwQytOeXRxTU9uVjVMN0hPd3NZbUg2U2hsM2FReGd0VFZRN1BM?= =?utf-8?B?Y0NWdDdYVGNyYWUzdGwzdUIvS3Z1cDZDK05aNVdRandDd0xLUkxrZWZiampW?= =?utf-8?B?d2hRb0dPZnBpanJLZmdsWFJJa3pNUGhBY3ltcVo5d2hIYUhBL2hoNis3NmhF?= =?utf-8?B?OGdPcWlFbnhJWmRURGl4ZUVhZnB1Mk9Sa3A2V2hLVDl0QzRJWkwwbGhJQXVS?= =?utf-8?B?blhvSEhZN0tNdE9EcStLUktxRndJWWIvc0trbGUwOXZSRmhJL0hnNUZ6SGl0?= =?utf-8?B?T3NtbVFQcjFKYzZ4czluRUY0Q0g5cW04Qis0WU1HeitaL1g1T1hYZGsvUnFL?= =?utf-8?B?VWdJODlHK3RPRkF2MW9WOWVXd0x4MXZLSHphSWhzTUlwMjQwZE5WbGpKUFVH?= =?utf-8?B?NWtOanB2N05sd0VWYnJ6VzM5dEVwdTFYWmY1TXhTdFVUbWVFUW1Ia1cwaWxi?= =?utf-8?B?emc9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 1d775dc1-3c6c-4389-28fb-08db14f2e505 X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3799.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Feb 2023 16:36:06.2987 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: fnTq1Gd3caNFHMnyBpvXbAdsrE/CfEStil2NFP87NgZRW9GPHQovg31BXwr6ewSMVi9PrBzxgwXdhLEqn32JIA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR11MB5388 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 22/02/2023 16:07, Stephen Hemminger wrote: > Convert to using a dynamic logtype for the application. > > Signed-off-by: Stephen Hemminger > --- > examples/l3fwd-power/main.c | 15 ++++++++------- > 1 file changed, 8 insertions(+), 7 deletions(-) > > diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c > index f57c54d2b57c..76b890b76c88 100644 > --- a/examples/l3fwd-power/main.c > +++ b/examples/l3fwd-power/main.c > @@ -51,7 +51,8 @@ > #include "perf_core.h" > #include "main.h" > > -#define RTE_LOGTYPE_L3FWD_POWER RTE_LOGTYPE_USER1 > +RTE_LOG_REGISTER(l3fwd_power_logtype, l3fwd.power, INFO); > +#define RTE_LOGTYPE_L3FWD_POWER l3fwd_power_logtype > > #define MAX_PKT_BURST 32 > > @@ -2236,7 +2237,7 @@ init_power_library(void) > /* init power management library */ > ret = rte_power_init(lcore_id); > if (ret) { > - RTE_LOG(ERR, POWER, > + RTE_LOG(ERR, L3FWD_POWER, > "Library initialization failed on core %u\n", > lcore_id); > return ret; > @@ -2245,7 +2246,7 @@ init_power_library(void) > env = rte_power_get_env(); > if (env != PM_ENV_ACPI_CPUFREQ && > env != PM_ENV_PSTATE_CPUFREQ) { > - RTE_LOG(ERR, POWER, > + RTE_LOG(ERR, L3FWD_POWER, > "Only ACPI and PSTATE mode are supported\n"); > return -1; > } > @@ -2263,7 +2264,7 @@ deinit_power_library(void) > /* deinit power management library */ > ret = rte_power_exit(lcore_id); > if (ret) { > - RTE_LOG(ERR, POWER, > + RTE_LOG(ERR, L3FWD_POWER, > "Library deinitialization failed on core %u\n", > lcore_id); > return ret; > @@ -2332,7 +2333,7 @@ update_telemetry(__rte_unused struct rte_timer *tim, > ret = rte_metrics_update_values(RTE_METRICS_GLOBAL, telstats_index, > values, RTE_DIM(values)); > if (ret < 0) > - RTE_LOG(WARNING, POWER, "failed to update metrics\n"); > + RTE_LOG(WARNING, L3FWD_POWER, "failed to update metrics\n"); > } > > static int > @@ -2381,7 +2382,7 @@ launch_timer(unsigned int lcore_id) > rte_get_main_lcore()); > } > > - RTE_LOG(INFO, POWER, "Bring up the Timer\n"); > + RTE_LOG(INFO, L3FWD_POWER, "Bring up the Timer\n"); > > telemetry_setup_timer(); > > @@ -2397,7 +2398,7 @@ launch_timer(unsigned int lcore_id) > } > } > > - RTE_LOG(INFO, POWER, "Timer_subsystem is done\n"); > + RTE_LOG(INFO, L3FWD_POWER, "Timer_subsystem is done\n"); > > return 0; > } Acked-by: David Hunt