From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id EE7FB235 for ; Thu, 23 Nov 2017 11:07:27 +0100 (CET) Received: from pure.maildistiller.com (dispatch1.mdlocal [10.7.20.164]) by dispatch1-us1.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTP id 6853A60EF5; Thu, 23 Nov 2017 10:07:27 +0000 (UTC) X-Virus-Scanned: Proofpoint Essentials engine Received: from mx1-us4.ppe-hosted.com (us4-filterqueue.mdlocal [10.7.20.246]) by pure.maildistiller.com (Proofpoint Essentials ESMTP Server) with ESMTPS id BCEA022004D; Thu, 23 Nov 2017 10:07:26 +0000 (UTC) Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1-us4.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id 6ECEC80073; Thu, 23 Nov 2017 10:07:26 +0000 (UTC) Received: from [192.168.38.17] (84.52.114.114) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1044.25; Thu, 23 Nov 2017 10:07:21 +0000 To: Adrien Mazarguil CC: , Jingjing Wu References: <1511166121-743-1-git-send-email-arybchenko@solarflare.com> <20171123093944.GG4062@6wind.com> From: Andrew Rybchenko Message-ID: Date: Thu, 23 Nov 2017 13:07:17 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171123093944.GG4062@6wind.com> Content-Language: en-GB X-Originating-IP: [84.52.114.114] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-11.0.0.1191-8.100.1062-23484.003 X-TM-AS-Result: No--16.375300-0.000000-31 X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-MDID: 1511431647-bZ3y0KTy1FTH Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH 0/2] ethdev: add GENEVE to flow API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Nov 2017 10:07:28 -0000 Hi Adrien, On 11/23/2017 12:39 PM, Adrien Mazarguil wrote: > Hi Andrew, > > On Mon, Nov 20, 2017 at 08:21:59AM +0000, Andrew Rybchenko wrote: >> enum rte_flow_item_type states that items matching protocol headers >> must be stacked in the same order as the protocol layers to match. >> As the result the patch changes ABI since Geneve is added just after >> VXLAN (the closest protocol). >> >> In fact as far as I can see many items do not follow the requirement >> already. May be the comment/requirement should be removed and GENEVE >> should be added at the end of the list. If so, should be keep it just >> after VXLAN in all other places or move after ESP as well? > Perhaps documentation is unclear, this requirement only applies to > applications when constructing patterns out of those items (e.g. to make > sense, TCP is supposed to come after IPv4, not before). > > New item/action definitions must obviously be added at the end of both lists > to avoid ABI breakage, there is no specific order to follow other than that. > > What may have confused you is most of them are apparently ordered by > protocol layer, that's because those are here from day one; it's not the > case anymore starting with E_TAG, which was added much later. > > Besides addressing the ABI breakage, I don't see any issue with adding > GENEVE to rte_flow, I only have a few more comments on subsequent patches in > the series. Otherwise good job, looks like you didn't miss anything. Many thinks for review and clarification. We'll process review notes and send v2. -- Andrew