* [dpdk-dev] [PATCH] vfio: fix device hotplug when several devices per group
@ 2018-04-10 10:23 Anatoly Burakov
2018-04-12 23:14 ` Thomas Monjalon
0 siblings, 1 reply; 2+ messages in thread
From: Anatoly Burakov @ 2018-04-10 10:23 UTC (permalink / raw)
To: dev; +Cc: gowrishankar.m, alejandro.lucero, stable
We only need to perform DMA mapping for first device in first group.
At the time of mapping, we haven't yet added the device into the group,
so the count is expected to be zero.
Fixes: 810bfa64c673 ("vfio: fix index for tracking devices in a group")
Fixes: a9c349e3a100 ("vfio: fix device unplug when several devices per group")
Fixes: 94c0776b1bad ("vfio: support hotplug")
Cc: alejandro.lucero@netronome.com
Cc: stable@dpdk.org
Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
---
lib/librte_eal/linuxapp/eal/eal_vfio.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lib/librte_eal/linuxapp/eal/eal_vfio.c b/lib/librte_eal/linuxapp/eal/eal_vfio.c
index e44ae4d..15250ee 100644
--- a/lib/librte_eal/linuxapp/eal/eal_vfio.c
+++ b/lib/librte_eal/linuxapp/eal/eal_vfio.c
@@ -332,7 +332,8 @@ rte_vfio_setup_device(const char *sysfs_base, const char *dev_addr,
* functionality.
*/
if (internal_config.process_type == RTE_PROC_PRIMARY &&
- vfio_cfg.vfio_active_groups == 1) {
+ vfio_cfg.vfio_active_groups == 1 &&
+ vfio_group_device_count(vfio_group_fd) == 0) {
/* select an IOMMU type which we will be using */
const struct vfio_iommu_type *t =
vfio_set_iommu_type(vfio_cfg.vfio_container_fd);
--
2.7.4
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] [PATCH] vfio: fix device hotplug when several devices per group
2018-04-10 10:23 [dpdk-dev] [PATCH] vfio: fix device hotplug when several devices per group Anatoly Burakov
@ 2018-04-12 23:14 ` Thomas Monjalon
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Monjalon @ 2018-04-12 23:14 UTC (permalink / raw)
To: Anatoly Burakov; +Cc: dev, gowrishankar.m, alejandro.lucero, stable
10/04/2018 12:23, Anatoly Burakov:
> We only need to perform DMA mapping for first device in first group.
> At the time of mapping, we haven't yet added the device into the group,
> so the count is expected to be zero.
>
> Fixes: 810bfa64c673 ("vfio: fix index for tracking devices in a group")
> Fixes: a9c349e3a100 ("vfio: fix device unplug when several devices per group")
> Fixes: 94c0776b1bad ("vfio: support hotplug")
> Cc: alejandro.lucero@netronome.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-04-12 23:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-10 10:23 [dpdk-dev] [PATCH] vfio: fix device hotplug when several devices per group Anatoly Burakov
2018-04-12 23:14 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).