From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 09FCDA0C47; Tue, 5 Oct 2021 12:43:44 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5CFAE41318; Tue, 5 Oct 2021 12:43:44 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id 85FD241311 for ; Tue, 5 Oct 2021 12:43:42 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10127"; a="212828254" X-IronPort-AV: E=Sophos;i="5.85,348,1624345200"; d="scan'208";a="212828254" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Oct 2021 03:43:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,348,1624345200"; d="scan'208";a="438650080" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga006.jf.intel.com with ESMTP; 05 Oct 2021 03:43:40 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 5 Oct 2021 03:43:40 -0700 Received: from fmsmsx605.amr.corp.intel.com (10.18.126.85) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 5 Oct 2021 03:43:40 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Tue, 5 Oct 2021 03:43:40 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.105) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Tue, 5 Oct 2021 03:43:39 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=l7nl3H6UH6Cbj00KfBY7wdiWDMTWGHnszqpwxQ7F3IN65BgTOXQl+ZgZpfP5QhAX0fIEhldcPz9c/YV+2uA3QtXPYJYduxbehL42Bgls+xHl23b0ghO7bEumztYIXwjaBJCnw1p/C9PS/yCB9TEVxVc7kzMdC3REyT8bhDhX/DLvD8qTGnmfQRHvNbjFLYVe/7Fd4enuQ7cgUdIyb8GgZ6h9fykupP8uso895HsLOzwAOYJE0QMHhgxUZdCyjjVyKTx5KHdGdc2bsQAoUk5kzt8O565y+ftU5VM0iVEHTSzNt6To/L0OBX0IHdIJ42qc0uszOUozMUtcT+oaDzVPMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2Htw3Jw3jwPz08IU6oMcv344v7rV2AkmUcQRrCVpZdY=; b=ZHCcoXUrD+d7TzArKzz2AaN1Zu6VRFz8yQ/sIcNdYZEau2Jffn80jpAsj+gP09pZIqaXVmiIIngbbL5Gtu7N83DpQA0NeXe8ywEKdt/Qmg8FUEVRlH9yh7FIkqD4V/umenfNGC5ToWHPPUfj6jPdIPEPj6BrnO3L+lxB8efIl4eo/vNwEnpPgvuHQPbgQVFNSD8ShfeW/DG6r9NMWosjNcaqGzu+iFWKn31qhj5Fl95Jw4jwrUbXfYjBQchaSRf0tf8H3BbBH+9B/7zUlxMXgJE98xm9loNqvoo0rZvshSxkSr0ziplxIqv79R1Vla6i4UCKwRdX7Pu5zDkVJBBotQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2Htw3Jw3jwPz08IU6oMcv344v7rV2AkmUcQRrCVpZdY=; b=tSBtEOPVGGObRHUhz4Acu64X5Sy0SwspVw2+It6O98quWALQEEz1Zwu8Mm44H8DkMdViml92Ypijz32vrlraVSL0G53jlwlAiI39+7/mDmCX/pEmmD0WrU73XfTX8htT0MtNFEFKmypSQ3xJexJFU+fLuSi5DB7gfM6L07XK56w= Authentication-Results: redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB4838.namprd11.prod.outlook.com (2603:10b6:510:40::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.19; Tue, 5 Oct 2021 10:43:36 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc%4]) with mapi id 15.20.4566.022; Tue, 5 Oct 2021 10:43:36 +0000 Message-ID: Date: Tue, 5 Oct 2021 11:43:23 +0100 Content-Language: en-US To: David Marchand , Konstantin Ananyev , Thomas Monjalon CC: dev , Xiaoyun Li , Anoob Joseph , Jerin Jacob Kollanukkaran , "Nithin Dabilpuram" , Ankur Dwivedi , Shepard Siegel , Ed Czeck , John Miller , "Igor Russkikh" , Ajit Khaparde , Somnath Kotur , Rahul Lakkireddy , Hemant Agrawal , Sachin Saxena , "Wang, Haiyue" , John Daley , "Hyong Youb Kim" , Qi Zhang , Xiao Wang , "humin (Q)" , Yisen Zhuang , oulijun , Beilei Xing , Jingjing Wu , Qiming Yang , Matan Azrad , Slava Ovsiienko , Stephen Hemminger , Long Li , , "Kiran Kumar Kokkilagadda" , Andrew Rybchenko , Maciej Czekaj , "Jiawen Wu" , Jian Wang , "Maxime Coquelin" , "Xia, Chenbo" , Thomas Monjalon , Ray Kinsella , "Jayatheerthan, Jay" References: <20211001140255.5726-1-konstantin.ananyev@intel.com> <20211004135603.20593-1-konstantin.ananyev@intel.com> <20211004135603.20593-8-konstantin.ananyev@intel.com> From: Ferruh Yigit X-User: ferruhy In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DU2PR04CA0269.eurprd04.prod.outlook.com (2603:10a6:10:28e::34) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DU2PR04CA0269.eurprd04.prod.outlook.com (2603:10a6:10:28e::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.14 via Frontend Transport; Tue, 5 Oct 2021 10:43:27 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 58a0b147-d0d9-4530-4c38-08d987ecfbc1 X-MS-TrafficTypeDiagnostic: PH0PR11MB4838: X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: FCtlWLHBoa0WYyE6DVJM1gWz9HX7c/GF8ch/8AfvkVbezGdiBRtZIf1io9ugSJYKFiOzFMCEr+PWioydHKqFRqglo9mBuhoizeGW1ZTQ86aOJEj4/31EZw09lG2poHUQTN0RHH53/whLi2+FIz2g+1teoC2cWH4oMkXywgndqVGWiRPtlQj8XswSmTruofSSBgeAd7gaT6d+GeOsY4e+JG9ATGmn246X/smDLOCmKcAqSH0I39jIsPskcLxXeXOaC77ln63FjVPnfQSGhpRB5Qrq+Q/gZc8JtyD/S+EIks2WWW5FF+yAWmVQwJGasbg5N+jxlAa7Vyy+H1xsZKGfkL4oUtplPr0pOf3xGnA76iWwcBDc71OI4SaPYUmF9GG5yWWMEwRtqHqv69plqM0rTdqt90ooUkrbiMYBl0mb+E/Fh+dN0CbZwNVcJlCIrHyCYz412i6QRKfGm66rBH4c39yMwRIEG4IPCXiVs9ocw7UgCjHXjxTTLx3d/4eRlJLyH+TA5wdDDibjmuhbuxQ1OwEbXfaxnt4mmzeXURrfq7o/ANURyA4egvSW/fM5fNAVGqwUXI8L74AgdpMG95oXRlG6sY8y7HLC0J5RfDhLsc/TDxLI63GVf9MMlJIIBeMqeUcSB7xp0TcOSPntO2LWgmbTPML5fMqf97ADl5vjQq1xxV99yqpYkzJrt0n0IPaPixwRPsuPJfTnYR0lDpCEeKMMF8ogBhijZO3uE1Csq43YF0bmI/6M18Q03JMIxIfSGX1y3BFEYh2nRFuGQvNuwEtftmm/+ryUCwlBUgabYTs= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(36756003)(38100700002)(86362001)(16576012)(186003)(31686004)(31696002)(54906003)(2616005)(956004)(107886003)(110136005)(316002)(83380400001)(4326008)(8936002)(6666004)(966005)(5660300002)(508600001)(2906002)(26005)(66476007)(53546011)(44832011)(8676002)(66946007)(7406005)(7416002)(66556008)(6486002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZjZFbnF3OEdPZjNkVlQ5M3dIRmprNVNTSXBkZ2dZZHMxb1JnR0YxcWc2YTlN?= =?utf-8?B?c1k1UzBpRjdpOEhGaHJaSXQzVHUvZWJoRGdEU3ZhQ1VLYUFYS05KWGpnYy9V?= =?utf-8?B?M25lakNZb0JNVktGUXBVMklFN3MvcURaWkJPMFlFb0hxRldYaTVMUU0yQTc4?= =?utf-8?B?aEF4ZFlUbTdMRGM4VTNjRUNGUEkzVEhDV3ZIczRSY0ZsVGg2eVpsczBOTFFK?= =?utf-8?B?QitOc1dYL3krK2NlR3FGZWpJbXJMMVltVHhYZldRTkt0SlUzTkNzeWtjOFox?= =?utf-8?B?dU1raHkzalFSWjA1L0ZqYk51SFJYSnpqbi9OVHhMbVo1K056QmtJYmZmLzlz?= =?utf-8?B?V2tweXNQR21qdmtMS2JnazgxVUtwS09DNXBWczN4MTkzRWRVbVE3dkN5akI1?= =?utf-8?B?aVh2UFoyRGt1aVljWGg1M3ZyUnpObEZYYTFma2RORDJRVHROZFFTM3VHNWRF?= =?utf-8?B?ZlYxMUErT1EveTQ5RXZPc2htT0VhbzV5ejRVc0Q3QmJkNkJCbFBPVndFNldl?= =?utf-8?B?b0pzZkZ1MytpL3Y1UGNwR3RQWU4wOFp5L21zdGRwNzFObUQ4TGF1ME00L0lI?= =?utf-8?B?WU16bDdzYmo5TlBGTnRDS0QrRlJJd1c4K3ZnVXlxNnlDYVpTTUZjRnVZRWQ2?= =?utf-8?B?ZXRyNFBZb0UwMCtyb1Vnd2JGMTJUSWhzWm9KTlB1ZjZFOW9ZK0wwejlBaEM2?= =?utf-8?B?SGg4ZTh3bVNyNHh4OFo2ZkYxSStNRWpKQXV3U25OeG9iLzZvZ20zZ2I4cjVC?= =?utf-8?B?S0NDV24zZkx0ZksvZVA4blNlYlJXQTAwdlgxZGNVWG1Fbmp1dDhwYWlFa2JM?= =?utf-8?B?Z25adkw1M29SeU8wZVBGRUtkdVBiQmlIYzJ1a2NieU5YQVo0QmpOSVIvL2Nx?= =?utf-8?B?TTlsZXZWVG1uOVpqdnZ0SVQvYklaY1RneC9nMFVjTGcranJDVFJ4bjg2MGZ2?= =?utf-8?B?b1dCbjBsMm96bmNneDNid3V5UVdaUzZOZVIyT2kzcG5JaHkxVWc0ZU9WK2JE?= =?utf-8?B?aWZNWEhMNi8zYTZHeG1mRTN5dXJzTlZnR1VBR0dmazc5eTE2dnJqRzR4TEIw?= =?utf-8?B?cHNuVWJqbS83SDRuK2w0djR3bFVFY0xQWnE5UE1GTU5WeldhNU1LdXJER2t3?= =?utf-8?B?UkJXZHJSVWhYL0JMWm1pSnZFYUNtcEZhSkZ0SHNkeXFPdHFBUERsTFdnYlJK?= =?utf-8?B?V0FuSGpCY0hyaE5POFRaVnI2Um9kOGhPZzdVWE84bWFJMmt2WlZ3ekRFWlhq?= =?utf-8?B?cU4vRTZXMncyMmVON2VtajNBY3MxNWw4a3ZBT1hOYTNSN1FSaU1NdXU5RERK?= =?utf-8?B?UE5mTVZuYzZBTmp4VkZXZGduZ2RxMWgxdXpTT0ZDUUxmWjhtRVAxUEVsZ2Fr?= =?utf-8?B?bi9RTzVmMUU2NThzOXg4SnRnbUR6YTVOY2xVL0QxaTEzOUtBVGIvdHM1TXl0?= =?utf-8?B?RHFac3gzbWV3SXErd0VINDg0MHJvcXpOM001enpNc3llZFhZbm96b25rU1NN?= =?utf-8?B?bDVpcGlvalVSSnMvUHJoSWNxTHpYNFZISXgwMXVQcENkQWhLcm1hQjEyZUNL?= =?utf-8?B?aCtoNjFxQUV0cTFJTDQvVHFod3hBVHE2NlZhZ3pxL3pucEVTeFJlQmQrSU1u?= =?utf-8?B?K3o5bkc2SUNLK2hmQklYNlhCZ0x5UENzQlRiRmlIZDJNQnE0ZHlKU2Z3UHlP?= =?utf-8?B?dEU2cnkxdlFQd2JSc3pRQkx0ckVwWm9Ua0drTWlZZGswVWc3Z3dFdWhqM0ZQ?= =?utf-8?Q?vEi/GryS54NP4j9ld6imSOs2V/+uzBDcO7+sE2b?= X-MS-Exchange-CrossTenant-Network-Message-Id: 58a0b147-d0d9-4530-4c38-08d987ecfbc1 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Oct 2021 10:43:35.9777 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +WGbOb2uhbnisgPqRASLOFs06Iv1eh2OTOadGh61aIAB9n2+FsLETt7/UqSa9fT4SWtYEGFryyChycqk1Y/Jrw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4838 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v4 7/7] ethdev: hide eth dev related structures X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/5/2021 11:04 AM, David Marchand wrote: > On Mon, Oct 4, 2021 at 3:59 PM Konstantin Ananyev > wrote: >> >> Move rte_eth_dev, rte_eth_dev_data, rte_eth_rxtx_callback and related >> data into private header (ethdev_driver.h). >> Few minor changes to keep DPDK building after that. > > This change is going to hurt a lot of people :-). > But this is a necessary move. > +1 that it is necessary move, but I am surprised to see how much 'rte_eth_devices' is accessed directly. Do you have any idea/suggestion on how can we reduce the pain for them? > $ git grep-all -lw rte_eth_devices |grep -v \\.patch$ > ANS/ans/ans_main.c > BESS/core/drivers/pmd.cc > dma_ip_drivers/QDMA/DPDK/drivers/net/qdma/qdma_xdebug.c > dma_ip_drivers/QDMA/DPDK/drivers/net/qdma/rte_pmd_qdma.c > dma_ip_drivers/QDMA/DPDK/examples/qdma_testapp/pcierw.c > dma_ip_drivers/QDMA/DPDK/examples/qdma_testapp/testapp.c > FD.io-VPP/src/plugins/dpdk/device/format.c > lagopus/src/dataplane/dpdk/dpdk_io.c > OVS/lib/netdev-dpdk.c > packet-journey/app/kni.c > pktgen-dpdk/app/pktgen-port-cfg.c > pktgen-dpdk/app/pktgen-port-cfg.h > pktgen-dpdk/app/pktgen-stats.c > Trex/src/dpdk_funcs.c > Trex/src/drivers/trex_i40e_fdir.c > Trex/src/drivers/trex_ixgbe_fdir.c > TungstenFabric-vRouter/gdb/vr_dpdk.gdb > > > I did not check all projects for their uses of rte_eth_devices, but I > did the job for OVS. > If you have cycles to review... > https://patchwork.ozlabs.org/project/openvswitch/patch/20210907082343.16370-1-david.marchand@redhat.com/ > > One nit: > >> >> Signed-off-by: Konstantin Ananyev >> --- >> doc/guides/rel_notes/release_21_11.rst | 6 + >> drivers/common/octeontx2/otx2_sec_idev.c | 2 +- >> drivers/crypto/octeontx2/otx2_cryptodev_ops.c | 2 +- >> drivers/net/cxgbe/base/adapter.h | 2 +- >> drivers/net/dpaa2/dpaa2_ptp.c | 2 +- >> drivers/net/netvsc/hn_var.h | 1 + >> lib/ethdev/ethdev_driver.h | 149 ++++++++++++++++++ >> lib/ethdev/rte_ethdev_core.h | 143 ----------------- >> lib/ethdev/version.map | 2 +- >> lib/eventdev/rte_event_eth_rx_adapter.c | 2 +- >> lib/eventdev/rte_event_eth_tx_adapter.c | 2 +- >> lib/eventdev/rte_eventdev.c | 2 +- >> lib/metrics/rte_metrics_telemetry.c | 2 +- >> 13 files changed, 165 insertions(+), 152 deletions(-) >> >> diff --git a/doc/guides/rel_notes/release_21_11.rst b/doc/guides/rel_notes/release_21_11.rst >> index 6055551443..2944149943 100644 >> --- a/doc/guides/rel_notes/release_21_11.rst >> +++ b/doc/guides/rel_notes/release_21_11.rst >> @@ -228,6 +228,12 @@ ABI Changes >> to user, it still counts as an ABI change, as ``eth_rx_queue_count_t`` >> is used by public inline function ``rte_eth_rx_queue_count``. >> >> +* ethdev: Made ``rte_eth_dev``, ``rte_eth_dev_data``, ``rte_eth_rxtx_callback`` >> + private data structures. ``rte_eth_devices[]`` can't be accessible directly > > accessed* > >> + by user any more. While it is an ABI breakage, this change is intended >> + to be transparent for both users (no changes in user app is required) and >> + PMD developers (no changes in PMD is required). >> + >> >> Known Issues >> ------------ > > >