From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 58897A04A4; Thu, 30 Apr 2020 21:41:13 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7FE921DC0A; Thu, 30 Apr 2020 21:41:12 +0200 (CEST) Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by dpdk.org (Postfix) with ESMTP id 733C51DC05 for ; Thu, 30 Apr 2020 21:41:11 +0200 (CEST) Received: from pps.filterd (m0187473.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 03UJXDQl096330; Thu, 30 Apr 2020 15:41:10 -0400 Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 30mguym4yr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 30 Apr 2020 15:41:10 -0400 Received: from m0187473.ppops.net (m0187473.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.36/8.16.0.36) with SMTP id 03UJXVJH097077; Thu, 30 Apr 2020 15:41:08 -0400 Received: from ppma04wdc.us.ibm.com (1a.90.2fa9.ip4.static.sl-reverse.com [169.47.144.26]) by mx0a-001b2d01.pphosted.com with ESMTP id 30mguym4xw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 30 Apr 2020 15:41:08 -0400 Received: from pps.filterd (ppma04wdc.us.ibm.com [127.0.0.1]) by ppma04wdc.us.ibm.com (8.16.0.27/8.16.0.27) with SMTP id 03UJUl58003694; Thu, 30 Apr 2020 19:41:06 GMT Received: from b03cxnp07029.gho.boulder.ibm.com (b03cxnp07029.gho.boulder.ibm.com [9.17.130.16]) by ppma04wdc.us.ibm.com with ESMTP id 30mcu7fxa2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 30 Apr 2020 19:41:06 +0000 Received: from b03ledav003.gho.boulder.ibm.com (b03ledav003.gho.boulder.ibm.com [9.17.130.234]) by b03cxnp07029.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 03UJf5pI47514000 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 30 Apr 2020 19:41:05 GMT Received: from b03ledav003.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C764F6A047; Thu, 30 Apr 2020 19:41:05 +0000 (GMT) Received: from b03ledav003.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 126576A04F; Thu, 30 Apr 2020 19:41:04 +0000 (GMT) Received: from Davids-MBP.randomparity.org (unknown [9.163.83.155]) by b03ledav003.gho.boulder.ibm.com (Postfix) with ESMTP; Thu, 30 Apr 2020 19:41:04 +0000 (GMT) To: Ori Kam , thomas@monjalon.net, Matan Azrad , Shahaf Shuler , Viacheslav Ovsiienko , Beilei Xing , Qi Zhang , Maxime Coquelin , Zhihong Wang , Xiaolong Ye Cc: rasland@mellanox.com, david.marchand@redhat.com, dev@dpdk.org, ferruh.yigit@intel.com References: <1588060706-27316-1-git-send-email-orika@mellanox.com> <1588256535-55626-1-git-send-email-orika@mellanox.com> From: David Christensen Message-ID: Date: Thu, 30 Apr 2020 12:41:04 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <1588256535-55626-1-git-send-email-orika@mellanox.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138, 18.0.676 definitions=2020-04-30_12:2020-04-30, 2020-04-30 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 lowpriorityscore=0 clxscore=1011 mlxlogscore=999 mlxscore=0 suspectscore=0 bulkscore=0 adultscore=0 impostorscore=0 phishscore=0 spamscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2004300147 Subject: Re: [dpdk-dev] [PATCH v2] eal/ppc: fix redefine bool type X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 4/30/20 7:22 AM, Ori Kam wrote: > The AltiVec header file breaks boolean type. [1] [2] > > Currently the workaround was located only in mlx5 device. > Adding the trace module caused this issue to appear again, due to > order of includes, it keeps overriding the local fix. > > This patch solves this issue by resetting the bool type, immediately > after it is being changed. ... > Fixes: 725f5dd0bfb5 ("net/mlx5: fix build on PPC64") > > Signed-off-by: Ori Kam > Signed-off-by: David Christensen > --- > v2: > * Replace alitvec include in all files. > * Address ML comments. > --- Tested-by: David Christensen