From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id F2361A0613 for ; Tue, 24 Sep 2019 20:25:13 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 356262C23; Tue, 24 Sep 2019 20:25:12 +0200 (CEST) Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by dpdk.org (Postfix) with ESMTP id 3F07D1E20; Tue, 24 Sep 2019 20:25:10 +0200 (CEST) Received: by mail-wr1-f68.google.com with SMTP id r3so3025824wrj.6; Tue, 24 Sep 2019 11:25:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=0XhsLl3Q8EMkFylRqcAFtvLhdyhTr5Kz0XOD6IunhkY=; b=TmaQedw2RNJIkQhYjjfRaH1UIGWA71B9G0/RXFiJBOqQ81TzHKjuQ4rAUbVP83vLG/ /w/FmVUB/Fbyu8RkYXA9m/+ORX6uca5YgzX5E1kbLn1ILccg70lMChEBLrP9/bJTbF2F J9MwbWg1iVW5uqxYJgoAdXqQcO961cSWQBU7nwg8iu2YKtWggoCzmOrlrreEC7T1HlZM Z7/qwbH+5125vxdhnYNrFOiBET/Yutm751FTRrc707fSkV8G7JUf+WWMyhE5dyWxeaR7 yCax6QKLlSWd09X6s2l4QG4uEOsmpJVi6q7UQ99nP9Gt8uwyWLi02c4XCHMMvbwgvQAL ks8w== X-Gm-Message-State: APjAAAXC1MR7lHZMcBGDFeYPFN/1uGmEcXGZRYnt/iGASKLhqMNTlToY Wu5V8lO656iR4TiqY2VuWGI= X-Google-Smtp-Source: APXvYqxe8xsixhbjKK3P2cZQYA3HE+wfgIlW64cqsJEzNmmwTaycRrqs19tJk+GOKpdbYBU8P+oEVA== X-Received: by 2002:adf:e9ce:: with SMTP id l14mr3983518wrn.264.1569349509709; Tue, 24 Sep 2019 11:25:09 -0700 (PDT) Received: from localhost ([2a01:4b00:f419:6f00:7a8e:ed70:5c52:ea3]) by smtp.gmail.com with ESMTPSA id e30sm4190977wra.48.2019.09.24.11.25.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Sep 2019 11:25:09 -0700 (PDT) Message-ID: From: Luca Boccassi To: Ferruh Yigit , dev@dpdk.org Cc: stable@dpdk.org Date: Tue, 24 Sep 2019 19:25:08 +0100 In-Reply-To: <20190729123216.64601-1-ferruh.yigit@intel.com> References: <20190729123216.64601-1-ferruh.yigit@intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] igb_uio: fix build on Linux 5.3 for implicit fall through X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, 2019-07-29 at 13:32 +0100, Ferruh Yigit wrote: > build error: > .../dpdk/build/build/kernel/linux/igb_uio/igb_uio.c: > In function =E2=80=98igbuio_pci_enable_interrupts=E2=80=99: > .../dpdk/build/build/kernel/linux/igb_uio/igb_uio.c:230:6: > error: this statement may fall through > [-Werror=3Dimplicit-fallthrough=3D] > 230 | if (pci_alloc_irq_vectors(udev->pdev, 1, 1, .... > .../dpdk/build/build/kernel/linux/igb_uio/igb_uio.c:240:2: > note: here > 240 | case RTE_INTR_MODE_MSI: > | ^~~~ >=20 > The build error is caused by Linux kernel commit in 5.3 that enables > the > "-Wimplicit-fallthrough=3D3" gcc flag. > Commit a035d552a93b ("Makefile: Globally enable fall-through > warning") >=20 > To fix the error, either a gcc attribute can be provided [1] or a > code > comment with some defined syntax need to be provided [2], since there > is > already comments, updated them slightly to match the required syntax > to > fix the build error. >=20 > [1] > "__attribute__ ((fallthrough));" >=20 > [2] > [ \t.!]*([Ee]lse,? |[Ii]ntentional(ly)? )? > fall(s | |-)?thr(ough|u)[ \t.!]*(-[^\n\r]*)? >=20 > Cc:=20 > stable@dpdk.org >=20 >=20 > Signed-off-by: Ferruh Yigit < > ferruh.yigit@intel.com > > > --- > kernel/linux/igb_uio/igb_uio.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Ferruh I'm including this in 17.11.7 since it fixes the build on a number of new distros and it seems simple enough as it just updates the comment for the compiler's benefit. Let me know if there are any objections. --=20 Kind regards, Luca Boccassi