From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 1B02D44115;
	Thu, 30 May 2024 20:46:30 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 099E2402E6;
	Thu, 30 May 2024 20:46:30 +0200 (CEST)
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by mails.dpdk.org (Postfix) with ESMTP id EE09C40289
 for <dev@dpdk.org>; Thu, 30 May 2024 20:46:28 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A499F1424;
 Thu, 30 May 2024 11:46:52 -0700 (PDT)
Received: from [10.57.68.198] (unknown [10.57.68.198])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C649B3F641;
 Thu, 30 May 2024 11:46:27 -0700 (PDT)
Message-ID: <e8f82c5c-2cbb-4789-b259-c3ec81268993@arm.com>
Date: Thu, 30 May 2024 19:46:26 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v5 2/3] dts: constrain DPDK source argument
Content-Language: en-GB
To: =?UTF-8?Q?Juraj_Linke=C5=A1?= <juraj.linkes@pantheon.tech>
Cc: dev@dpdk.org, Jeremy Spewock <jspewock@iol.unh.edu>,
 Paul Szczepanek <paul.szczepanek@arm.com>
References: <20240122182611.1904974-1-luca.vizzarro@arm.com>
 <20240514121023.1957025-1-luca.vizzarro@arm.com>
 <20240514121023.1957025-3-luca.vizzarro@arm.com>
 <CAOb5WZaHWYUP3j5ef86ytf-U8=Gjb-KULAzTLw2wB7WXmPp9jQ@mail.gmail.com>
From: Luca Vizzarro <Luca.Vizzarro@arm.com>
In-Reply-To: <CAOb5WZaHWYUP3j5ef86ytf-U8=Gjb-KULAzTLw2wB7WXmPp9jQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On 30/05/2024 16:41, Juraj Linkeš wrote:
>> -                           [DTS_CFG_FILE] The configuration file that describes the test cases, SUTs and targets.
>> -                           (default: conf.yaml)
>> +                           [DTS_CFG_FILE] The configuration file that describes the test cases, SUTs and targets. (default:
>> +                           /home/lucviz01/dpdk/dts/conf.yaml)
> 
> The path has changed.

whoops! nice catch.

>> +def _parse_tarball_path(file_path: str) -> Path:
>> +    """Validate whether `file_path` is valid and return a Path object."""
>> +    path = Path(file_path)
>> +    if not path.exists() or not path.is_file():
>> +        raise argparse.ArgumentTypeError("The file path provided is not a valid file")
>> +    return path
>> +
>> +
>> +def _parse_revision_id(rev_id: str) -> str:
>> +    """Validate revision ID and retrieve corresponding commit ID."""
>> +    try:
>> +        return get_commit_id(rev_id)
>> +    except ConfigurationError:
>> +        raise argparse.ArgumentTypeError("The Git revision ID supplied is invalid or ambiguous")
> 
> I made the comment about ordering in the other patch with these
> functions in mind, so let's not forget these.

Yes, this are actually in the wrong place. Will move.