From: "Mattias Rönnblom" <hofors@lysator.liu.se>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org, phil.yang@arm.com
Subject: Re: [PATCH v4] testpmd: cleanup cleanly from signal
Date: Thu, 10 Nov 2022 23:06:55 +0100 [thread overview]
Message-ID: <e924047d-6279-cbc7-1128-4119064316bf@lysator.liu.se> (raw)
In-Reply-To: <20221110081412.707599b2@hermes.local>
On 2022-11-10 17:14, Stephen Hemminger wrote:
> On Thu, 10 Nov 2022 08:50:40 +0100
> Mattias Rönnblom <hofors@lysator.liu.se> wrote:
>
>>>>
>>>> Why is select() needed? Wouldn't a blocking read suffice? Or getchar().
>>>
>>> On Linux, signal set SA_RESTART so a simple read is not interrupted.
>>> One option was to use sigaction() which allows controlling flags, but that
>>> won't work on Windows. Using select() works on both.
>>>
>>
>> OK, so select() is used because a signal might interrupt read() on Windows?
>>
>> while (read(0, &c, 1) == -1 && errno == EINTR)
>> ;
>>
>> Would that work?
>
> Try it. On Linux the read never gets interrupted.
I had no doubts about that, but I misunderstood the code and thought
that was the required behavior.
next prev parent reply other threads:[~2022-11-10 22:06 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-14 17:23 [RFC 1/2] testpmd: make f_quit flag volatile Stephen Hemminger
2022-10-14 17:23 ` [RFC 2/2] testpmd: cleanup cleanly from signal Stephen Hemminger
2022-11-06 10:50 ` Andrew Rybchenko
2022-11-08 18:16 ` Stephen Hemminger
2022-11-08 18:53 ` [PATCH v2] " Stephen Hemminger
2022-11-08 20:24 ` [PATCH v3] " Stephen Hemminger
2022-11-09 4:10 ` [PATCH v4] " Stephen Hemminger
2022-11-09 21:46 ` Mattias Rönnblom
2022-11-09 22:53 ` Stephen Hemminger
2022-11-10 7:50 ` Mattias Rönnblom
2022-11-10 16:14 ` Stephen Hemminger
2022-11-10 22:06 ` Mattias Rönnblom [this message]
2022-11-09 17:29 ` [PATCH v5] " Stephen Hemminger
2022-11-10 7:14 ` Andrew Rybchenko
2022-11-10 16:13 ` Stephen Hemminger
2022-11-10 16:53 ` [PATCH v6] " Stephen Hemminger
2022-11-11 8:05 ` Andrew Rybchenko
2022-11-11 16:49 ` Stephen Hemminger
2022-11-11 16:51 ` [PATCH v7] " Stephen Hemminger
2022-11-12 17:28 ` [PATCH v8] " Stephen Hemminger
2023-01-19 15:53 ` Ferruh Yigit
2023-01-25 18:32 ` [PATCH v9] " Stephen Hemminger
2023-01-30 18:48 ` Ferruh Yigit
2023-01-30 20:11 ` Stephen Hemminger
2022-11-06 10:48 ` [RFC 1/2] testpmd: make f_quit flag volatile Andrew Rybchenko
2022-11-08 18:07 ` [PATCH v2] " Stephen Hemminger
2022-11-09 10:11 ` Ruifeng Wang
2022-11-09 10:37 ` Andrew Rybchenko
2023-01-30 20:09 ` [PATCH v10 0/2] testpmd: handle signals safely Stephen Hemminger
2023-01-30 20:09 ` [PATCH v10 1/2] cmdline: handle EOF in cmdline_poll Stephen Hemminger
2023-01-30 22:12 ` Ferruh Yigit
2023-01-31 2:54 ` Stephen Hemminger
2023-01-30 20:09 ` [PATCH v10 2/2] testpmd: cleanup cleanly from signal Stephen Hemminger
2023-01-31 9:30 ` Ferruh Yigit
2023-01-30 22:13 ` [PATCH v10 0/2] testpmd: handle signals safely Ferruh Yigit
2023-02-03 19:14 ` [PATCH v11 0/3] Fix cmdline_poll and testpmd signal handling Stephen Hemminger
2023-02-03 19:14 ` [PATCH v11 1/3] cmdline: make rdline status not private Stephen Hemminger
2023-02-06 2:31 ` fengchengwen
2023-02-03 19:14 ` [PATCH v11 2/3] cmdline: handle EOF in cmdline_poll Stephen Hemminger
2023-02-03 19:14 ` [PATCH v11 3/3] testpmd: cleanup cleanly from signal Stephen Hemminger
2023-02-07 14:49 ` Ferruh Yigit
2023-02-07 14:48 ` [PATCH v11 0/3] Fix cmdline_poll and testpmd signal handling Ferruh Yigit
2023-02-19 17:53 ` Stephen Hemminger
2023-03-11 10:17 ` Thomas Monjalon
2023-03-12 17:18 ` Tal Shnaiderman
2023-03-13 10:34 ` Ling, WeiX
2023-03-13 15:53 ` Stephen Hemminger
2023-03-14 7:05 ` Ling, WeiX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e924047d-6279-cbc7-1128-4119064316bf@lysator.liu.se \
--to=hofors@lysator.liu.se \
--cc=dev@dpdk.org \
--cc=phil.yang@arm.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).