From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2351043A21; Wed, 31 Jan 2024 17:46:23 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C1FAE4026B; Wed, 31 Jan 2024 17:46:22 +0100 (CET) Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam04on2071.outbound.protection.outlook.com [40.107.101.71]) by mails.dpdk.org (Postfix) with ESMTP id F1F9D40269 for ; Wed, 31 Jan 2024 17:46:21 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ch7TzKTKlJTPyv1yjK31oG+IGHu7oCMmKK41FIhnIEyRwmba9Z+YbP0+37kzTCAEOMtagjgHyAdbY2cV0hbh4ABgw9KJ8kew7HRlRmVTr7v5ArD2zrxbIS34gBU1pr2UQ/OhVzALzOCIbh5Sqj+92lA4aS+ucldkGPF3z07bJpQR5c3mQnQGRuJmz4JdnbFo309arWe8NIRW3bzTgURHZODODvu8srJU6SDoszF2DFCfE4HxPlcRCYkA2ay3iCIsZ/dDEG0dTVJObJTbYaLlYmI/k+0Gcy0AbrnAC3RbjBKiH55hEO58okOqvYmlluuCzPqWENqA2WMWsy+ZisKSdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=r5Lh9DRsMTTLHlGL1gYFpotEEhEpT0Y/oj8kj23vFDU=; b=a93Ddx/1bnGcOugm5BkQfKVc46z2hcOfbqvezifIdSrV1wPWdt+hiBID4mwLBUUO1io3cQ5zqalZhLb/WoVq3Ce8jRgoZJEp4Lwi8byx7yoeM9WrsnxzJIiLmQDtDJMg7xRFD+Aizmt5B7s4vyAqgyxyWpqnU1ToZrBQ/ozJsaZzAbHXozY0O/D8VmK/rS3uaCOYsMzOF+ekTcqJGZke5oHk9K1MUicQRxzVYWUrmkoMHdXMNzJwxMI4+fUw6fQSX47tAg6fgWk+saBh59Lh1B+6eQ1uIKVbCKLkQtIh8sKQPA6HOrlpWaQghwUC5G2k0OODXQB6qeZoeY9XVhVasQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=r5Lh9DRsMTTLHlGL1gYFpotEEhEpT0Y/oj8kj23vFDU=; b=KE9KyUuGsh0xLiocsqwCN4h5TUuSnvKfjxvAK1JUZ2QdPul3RQX1TjH6EL1fOmlNjMZltZqcYSUxJbTC/2Sdw7SaOntCVxbarQrsU1n5+8UvzXViKyGSWhvY9+ROmYrXnYcgOeNO/RZQyshZ07Z5HEmSkLd9XPEwgNNRVP7PrA8= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by CY5PR12MB6345.namprd12.prod.outlook.com (2603:10b6:930:22::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7228.37; Wed, 31 Jan 2024 16:46:17 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::815a:45e6:cf5e:479f]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::815a:45e6:cf5e:479f%4]) with mapi id 15.20.7249.023; Wed, 31 Jan 2024 16:46:17 +0000 Message-ID: Date: Wed, 31 Jan 2024 16:46:11 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/3] ethdev: add compare item Content-Language: en-US To: Ori Kam , Suanming Mou , Aman Singh , Yuying Zhang , "NBU-Contact-Thomas Monjalon (EXTERNAL)" , Andrew Rybchenko Cc: "dev@dpdk.org" References: <20231219013337.531548-1-suanmingm@nvidia.com> <20240115091318.1053433-1-suanmingm@nvidia.com> <20240115091318.1053433-3-suanmingm@nvidia.com> <2594409d-5c8d-4347-b724-eece2b775376@amd.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0305.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a5::29) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|CY5PR12MB6345:EE_ X-MS-Office365-Filtering-Correlation-Id: 3bf7f4c9-de9c-4aba-234e-08dc227c24bb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0BUsCsGjjCIRQcgxhQSWOysMxKHDJeYsdiJtbS21P0/DKVqG/wU/91AaBL5Y8gEyGtMUjGARw9ZXLbI6Fl5oS+SxK3640nCK1knNoOvuJuAB25aO7xPZpE+xh6q0uxm2uYkBL49k9CCuTSHqdzWIYsJAQnPMIMVsJ2XRud/FxNAf2SW3G74IoNyVA/+dRK5AA49JxqEn9UsPB0pvRsnyMhuDJKemuL3pVCm8GOSK0oqYiC6h4Ukb8iHnjuA3x5SnSiWZHIDhmeayX3Zo/YWiUjtSpxTja2HHbkfaJseJbp8AoIhsYI4xV0O8F5IOuW0KdPS9WxBtMxT8tpKGHLkdQgH9xEW0n00e104cOaVU0TMe9/ZaCJ1xppM+FIexa3cWpvZ6A48IiFRz4S44BDVa29DGXWl7rT6y659NSkjKJz/8qqtD3lWxNzO3n2650BZpI63mTMH2gbDH1DCIrkqiBJDWknc77xkqQIkuLclywqUVFHf2Ou1CbEOdb7jw26eoAoOq3SUyvBboa+tcqJe9zUkhdaKIJRDBq+j4P2YFqrZE/4IkQqhuX8vR7KTPrOtFctYN7NWpcNi6FHv+Sq+6jKPErkFRusV7d8hT93pi83lFbYqzHz5s6iqQ3lAFhlB3wbADD0KQaYKUsDggRanuZnjdhQ1+8ZD8M0BMVyYC6e1caId+XUzkNu8+ZCZsQO7/jCSyggCZukVuQkc5BrTj0A== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376002)(39860400002)(346002)(396003)(136003)(366004)(230273577357003)(230922051799003)(230173577357003)(186009)(64100799003)(451199024)(1800799012)(8676002)(4326008)(8936002)(44832011)(2906002)(5660300002)(31696002)(86362001)(110136005)(66946007)(66556008)(66476007)(36756003)(6486002)(38100700002)(316002)(6506007)(6512007)(478600001)(83380400001)(6666004)(53546011)(26005)(2616005)(41300700001)(31686004)(21314003)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SXUzNjNRcllxUFY0WWlLZVNnQ0hLOFAxb0dxeXpkd1JJRlpmMTNkZVpJMGpD?= =?utf-8?B?R045TUlXVHNVTHFKRkJscnRJaWMwOXh0ZUI3cFV4cEFzYmh2Y3NocEU1cGJ5?= =?utf-8?B?bkVZRm5SZlFtNlpOSXdlWFVLZ0hBSG9DR0tYdlpRdTJmYXVqWDNOSmRJSnJo?= =?utf-8?B?NlFrR0lGY1hMSDM2Wjk0VHdTMFgyM2gxQnNLN1NqUG00c2NVMm4rbzZ2QnU4?= =?utf-8?B?UXBkZmVjM2lzUEQ0ODluZURRZHVnR0VlK1N1MnZjQW9ucm0wbXFmbzFnUTIx?= =?utf-8?B?L0NQTlp4UGtENit4K2tFbGRSaG5PUHliYll3d2FlRTNuOFRiY0RJMjFwaGNy?= =?utf-8?B?VUxHSDRkS1NhVk54Qitwd1FMUWkrUVFDbUtLd1hDMmNYWkxuWndzV3EzSytm?= =?utf-8?B?Z0hwLzNnazJBQzNUcjdiTUY0S0pLMUFwV25PekhYMmpaRVlvVFBTenJSNEZo?= =?utf-8?B?ZzFranZmRk5ieWpvNnIrV0x1MEREbC9tNTZJL0pvL1ViRzJ1YlhrcllYbGNQ?= =?utf-8?B?WFFxdFJacWxZZHQ4azdONzR1Y2NYc1gyRkY5SGhmdWpDL3FwN1Evalk1RzRz?= =?utf-8?B?Zm5iQ2pXWWpoSG1YQXhacU9pajQ5TGE2dE9vUlJYSHo5cUZMdjNFWVVBUTZn?= =?utf-8?B?Q0lQSDYweEtKc1BRVmlmT0RMSy9ST1hSbGUxOHQybGxiR3dlQWE4QkFVeXZL?= =?utf-8?B?cldyUlNyUGcyWXVQU2tTNEVHTmpPc09PWU8rWXR5d3p3bG9QdkFHaDBUdE82?= =?utf-8?B?aFlPSDRZNXNpSzZQTmpjZ3RJT0szMU1STFQ1T1hHSk54QzVTMWpSSVhsRGY5?= =?utf-8?B?VkFtZ1BYSnpIZkNFRU1jQmczZzB0amt5dHBYek1OUHRncm8yend1YkEzcWtB?= =?utf-8?B?Z0l5UkU3U2RTNkhacU4yREQ2MEJNQUY1K3RSdnBKQ3J3KytDOVl4aWNsVjMy?= =?utf-8?B?Y3FCV3IzdjhuYS9uSEl3T0Vhb0cxWldkZFliTys4QzFtTXZqRWx6YVdQZXMx?= =?utf-8?B?d21zam0rV0toUjRFM2ZnR2NCM29ydUxoTE5BanpZc1hFcVJjaGRYMEQ4L3Vz?= =?utf-8?B?RkNOMmlXSVBZT2UxVUppK0Y3aGtueHNwVGtoTmVYemhUNjUyMGU4K3IveU5y?= =?utf-8?B?d3VJMUtXS0xsSDNYMXFjYjFLcHBQV0FQcjByQmEwMU1PL1IxZVNQOVdqYzlN?= =?utf-8?B?cmlES2dFTWNxUTM2VCtYOGE0V0UwTXBGY2RoTTNSQ3FsOGdNWVVkdCtSUkZi?= =?utf-8?B?Z2Q1UnppVG9uUGlDZlhOd1N4WlBYSU8vbldBRGpvcHROcU5mZzZGck1PNGhk?= =?utf-8?B?aE9wY2xQVTN1bmdNR0t0a1ZqZXlLQTk4QmtKQXN6bU9ieUJGKzR2QTJoMDNZ?= =?utf-8?B?ZHNYc2lXOCtYMExUa0VjUExhUys0NVdiTVptNWp3eksxdTJQcTZiWUJnbHRD?= =?utf-8?B?N2pYdWpZVjZvdWdTVjVVd05BM0tLYUFOOHJyRGNnYnVyREFrTHYwWkFDZHpt?= =?utf-8?B?SEdmYjFHTmVCY0RUMHk4c0QzT2FQa0pEUm01VE1LSi9BUXRGU0lnVHVHaTJ3?= =?utf-8?B?STZPeW9EbDVucnd5cncrNkZrRHlOTUhDam1Ud01kKzZyVW03RDV6VmsrK0VH?= =?utf-8?B?ZEt4OExzNHp0RzV1SjBoWUFKb21TUTZsVGVZczlNT05TRDNiV2ovK1JjTi9E?= =?utf-8?B?Yk9YRGx4d21jVk9aMG42ajlYcVNZRmJUZzJWWUJRakltNHdwODdJenNMK3FV?= =?utf-8?B?T0pCQmVhWmFXZjlNY1duQ3BHTXFuVmZnbmJyMkdWOEpNdklPWVFnY3FkamRJ?= =?utf-8?B?SUdvTC8xZ0VWNjZMUmVPcVlualc5WDVUTHYzTlMzT2pRM3Q5MEVDb1VSUCtY?= =?utf-8?B?N0orT29XNVU5dFMzNStLT1JzN0FCOVg0SXdWbEFTY3o3U0dncCtKTW9Jc0FB?= =?utf-8?B?Q3F0b3Uvd3ZRS3RZRS95bGl0WExUZlVlRnVyc1ZNMExIR3NRejhQOE93Z0R6?= =?utf-8?B?RWlLL1hrTUJDYVQyc3liV3d6WXFsd3ZMQUw5SXR4ODh1TVdMa3ZVbi9lVWxo?= =?utf-8?B?QzFlcnUwMGg5cUFYbVpmaDlNeXM3Rzl2V2tEQ3RtdkUzekJqS2FXYUFkWGJM?= =?utf-8?Q?f2bgosXEZVBNu/AaUxPAPelBb?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3bf7f4c9-de9c-4aba-234e-08dc227c24bb X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jan 2024 16:46:16.9364 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: FBWqJhfMJxlFFFjHRpcvcWCPfEU9ulRnnZAee/zJ0epRkryt5ewM11XFzuBQmVLd X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR12MB6345 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 1/31/2024 3:56 PM, Ori Kam wrote: > Hi > >> -----Original Message----- >> From: Suanming Mou >> Sent: Wednesday, January 31, 2024 4:48 AM >> >> Hi, >> >>> -----Original Message----- >>> From: Ferruh Yigit >>> Sent: Wednesday, January 31, 2024 1:34 AM >>> To: Suanming Mou ; Ori Kam >> ; >>> Aman Singh ; Yuying Zhang >>> ; NBU-Contact-Thomas Monjalon (EXTERNAL) >>> ; Andrew Rybchenko >>> >>> Cc: dev@dpdk.org >>> Subject: Re: [PATCH v3 2/3] ethdev: add compare item >>> >>> On 1/15/2024 9:13 AM, Suanming Mou wrote: >>>> The new item type is added for the case user wants to match traffic >>>> based on packet field compare result with other fields or immediate >>>> value. >>>> >>>> e.g. take advantage the compare item user will be able to accumulate a >>>> IPv4/TCP packet's TCP data_offset and IPv4 IHL field to a tag >>>> register, then compare the tag register with IPv4 header total length >>>> to understand the packet has payload or not. >>>> >>> >>> ack, above sample makes it easier to understand. >>> >>> This patch is adding testpmd commands, can you please provide some >> sample >>> commands in commit log? >>> The more samples are better, as far as I remember there was a testpmd >>> documentation that documents the sample usages, can you please check >> for it? > > [Snip ..] > >>> >>>> +/** >>>> + * @warning >>>> + * @b EXPERIMENTAL: this structure may change without prior notice >>>> + * >>>> + * Field description for packet field. >>>> + */ >>>> +struct rte_flow_field_data { >>>> + enum rte_flow_field_id field; /**< Field or memory type ID. */ >>>> + union { >>>> + struct { >>>> + /** Encapsulation level and tag index or flex item >>> handle. */ >>>> + union { >>>> + struct { >>>> + /** >>>> + * Packet encapsulation level >> containing >>>> + * the field to modify. >>>> + * >>>> + * - @p 0 requests the default >> behavior. >>>> + * Depending on the packet type, it >>>> + * can mean outermost, innermost >> or >>>> + * anything in between. >>>> + * >>>> + * It basically stands for the >>>> + * innermost encapsulation level. >>>> + * Modification can be performed >>>> + * according to PMD and device >>>> + * capabilities. >>>> + * >>>> + * - @p 1 requests modification to be >>>> + * performed on the outermost >> packet >>>> + * encapsulation level. >>>> + * >>>> + * - @p 2 and subsequent values >>> request >>>> + * modification to be performed on >>>> + * the specified inner packet >>>> + * encapsulation level, from >>>> + * outermost to innermost (lower to >>>> + * higher values). >>>> + * >>>> + * Values other than @p 0 are not >>>> + * necessarily supported. >>>> + * >>>> + * @note that for MPLS field, >>>> + * encapsulation level also include >>>> + * tunnel since MPLS may appear in >>>> + * outer, inner or tunnel. >>>> + */ >>>> + uint8_t level; >>>> + union { >>>> + /** >>>> + * Tag index array inside >>>> + * encapsulation level. >>>> + * Used for VLAN, MPLS or >> TAG >>> types. >>>> + */ >>>> + uint8_t tag_index; >>>> + /** >>>> + * Geneve option identifier. >>>> + * Relevant only for >>>> + * >>> RTE_FLOW_FIELD_GENEVE_OPT_XXXX >>>> + * modification type. >>>> + */ >>>> + struct { >>>> + /** >>>> + * Geneve option >> type. >>>> + */ >>>> + uint8_t type; >>>> + /** >>>> + * Geneve option >> class. >>>> + */ >>>> + rte_be16_t class_id; >>>> + }; >>>> + }; >>>> + }; >>>> + struct rte_flow_item_flex_handle >> *flex_handle; >>>> + }; >>>> + /** Number of bits to skip from a field. */ >>>> + uint32_t offset; >>>> + }; >>>> + /** >>>> + * Immediate value for RTE_FLOW_FIELD_VALUE, presented >> in >>> the >>>> + * same byte order and length as in relevant >> rte_flow_item_xxx. >>>> + * The immediate source bitfield offset is inherited from >>>> + * the destination's one. >>>> + */ >>>> + uint8_t value[16]; >>>> + /** >>>> + * Memory address for RTE_FLOW_FIELD_POINTER, memory >>> layout >>>> + * should be the same as for relevant field in the >>>> + * rte_flow_item_xxx structure. >>>> + */ >>>> + void *pvalue; >>>> + }; >>>> +}; >>>> + >>>> >>> >>> I am aware that you are just moving the above struct, but it is nested too >> much >>> which is making it hard to read. >>> >>> As you are touching it, can we extract some structs and make this struct less >>> nested, what do you think? >>> Of course it needs to be done in separate patch, as a preperation/clean-up >> patch >>> before moving it around. >> >> Agree the struct maybe a bit nested. But not sure how it was discussed >> before during the last new member was added... @Ori, Do you have any idea >> about this? >> > > As far as I remember, it was never discussed, > > I think for this series we should keep it as is, and revise it later. > If you don't want to make this set more complex with this, that is OK as long as it is addressed at some point. > Best, > Ori >> And if it is really expected, I believe another new thread is worth for that >> change, better not be in that series. >> Need to discuss the new struct name and other stuff. What do you think? >> >>> >>> <...> >>> >>>> +/** >>>> + * >>>> + * RTE_FLOW_ITEM_TYPE_COMPARE >>>> + * >>>> + * Matches the packet with compare result. >>>> + * >>>> + * The operation means a compare with b result. >>>> + */ >>>> +struct rte_flow_item_compare { >>>> + enum rte_flow_item_compare_op operation; /* The compare >> operation. >>> */ >>>> + struct rte_flow_field_data a; /* Field be compared. */ >>>> + struct rte_flow_field_data b; /* Field as comparator. */ >>>> >>> >>> Variable names 'a' and 'b' are not descriptive although it may be OK since >> there is >>> no significance to the values, but other option can be 'first' and 'second', >> but >>> overall not strong opinion. >> >> Yes, thanks for the suggestion, in fact we also discussed about the name a lot, >> finally we choose the widely used 'a' and 'b' >> >> Thanks >