From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 656D4A0527; Wed, 15 Jul 2020 15:28:23 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 22C031BEB2; Wed, 15 Jul 2020 15:28:22 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 137DE1BEB1 for ; Wed, 15 Jul 2020 15:28:19 +0200 (CEST) IronPort-SDR: E0bn0NHfrFZ8ma6loFtiCPNrVxuGcNtm9dd1GmK5PDGWrCaMQoWRBplL0LWFzJl74shweSCktS Ntn+AlUowQQg== X-IronPort-AV: E=McAfee;i="6000,8403,9682"; a="136598876" X-IronPort-AV: E=Sophos;i="5.75,355,1589266800"; d="scan'208";a="136598876" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Jul 2020 06:28:19 -0700 IronPort-SDR: RuTRz/X+XUQvkNMQh6W2ub4hWK5e5TT5mhfG991+JKrEfLxWODaPJiurjkzG5aJmF+8AF6ntWt c4+TyJPlK4cw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,355,1589266800"; d="scan'208";a="324832727" Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.213.226.44]) ([10.213.226.44]) by FMSMGA003.fm.intel.com with ESMTP; 15 Jul 2020 06:28:18 -0700 To: Stephen Hemminger , dev@dpdk.org References: <20200604210200.25405-1-stephen@networkplumber.org> <20200701202359.17006-1-stephen@networkplumber.org> <20200701202359.17006-26-stephen@networkplumber.org> From: "Burakov, Anatoly" Message-ID: Date: Wed, 15 Jul 2020 14:28:17 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200701202359.17006-26-stephen@networkplumber.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v4 25/27] eal: mark old naming as deprecated X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 01-Jul-20 9:23 PM, Stephen Hemminger wrote: > Use of old RTE_LCORE_FOREACH_SLAVE and rte_get_master_lcore_id() > are marked as deprecated. > > All uses of these in DPDK itself is gone. This will cause warnings > for applications still using them. > > Signed-off-by: Stephen Hemminger > --- > lib/librte_eal/include/rte_launch.h | 4 ++-- > lib/librte_eal/include/rte_lcore.h | 4 +++- > 2 files changed, 5 insertions(+), 3 deletions(-) > > diff --git a/lib/librte_eal/include/rte_launch.h b/lib/librte_eal/include/rte_launch.h > index 9b68685d99d4..8d58ca5302a7 100644 > --- a/lib/librte_eal/include/rte_launch.h > +++ b/lib/librte_eal/include/rte_launch.h > @@ -76,8 +76,8 @@ enum rte_rmt_call_initial_t { > /** > * Deprecated backward compatiable definitions > */ > -#define SKIP_MASTER SKIP_INITIAL > -#define CALL_MASTER CALL_INITIAL > +#define SKIP_MASTER _Pragma("GCC warning \"'SKIP_MASTER' is deprecated\"") SKIP_INITIAL > +#define CALL_MASTER _Pragma("GCC warning \"'CALL_MASTER' is deprecated\"") CALL_INITIAL Presumably this is a generic header, should we introduce GCC-specific things there? > > /** > * Launch a function on all lcores. > diff --git a/lib/librte_eal/include/rte_lcore.h b/lib/librte_eal/include/rte_lcore.h > index 069cb1f427b9..eaa7c0f0b67c 100644 > --- a/lib/librte_eal/include/rte_lcore.h > +++ b/lib/librte_eal/include/rte_lcore.h > @@ -67,6 +67,7 @@ unsigned int rte_get_initial_lcore(void); > * @return > * the id of the initial lcore > */ > +__rte_deprecated > unsigned int rte_get_master_lcore(void); > > /** > @@ -216,7 +217,8 @@ unsigned int rte_get_next_lcore(unsigned int i, int skip_initial, int wrap); > /** > * Backward compatibility > */ > -#define RTE_LCORE_FOREACH_SLAVE(x) \ > +#define RTE_LCORE_FOREACH_SLAVE(x) \ > + _Pragma("GCC warning \"'RTE_LCORE_FOREACH_SLAVE' macro is deprecated\"") \ > RTE_LCORE_FOREACH_WORKER(x) Same as above. > > > -- Thanks, Anatoly