From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id 694C81B2EA for ; Mon, 5 Feb 2018 13:34:05 +0100 (CET) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1-us4.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id 526BD4C006C; Mon, 5 Feb 2018 12:34:03 +0000 (UTC) Received: from [192.168.38.17] (84.52.114.114) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1044.25; Mon, 5 Feb 2018 12:33:58 +0000 To: Bruce Richardson CC: , Ivan Malov References: <1517575438-8609-1-git-send-email-arybchenko@solarflare.com> <1517665594-3303-1-git-send-email-arybchenko@solarflare.com> <1517665594-3303-2-git-send-email-arybchenko@solarflare.com> <20180205123027.GA15752@bricha3-MOBL3.ger.corp.intel.com> From: Andrew Rybchenko Message-ID: Date: Mon, 5 Feb 2018 15:33:54 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180205123027.GA15752@bricha3-MOBL3.ger.corp.intel.com> Content-Language: en-GB X-Originating-IP: [84.52.114.114] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-11.0.0.1191-8.100.1062-23642.003 X-TM-AS-Result: No--17.682000-0.000000-31 X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-MDID: 1517834044-ZfyyxUQZD6-J Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v2 2/2] net/sfc: add support for meson build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Feb 2018 12:34:06 -0000 On 02/05/2018 03:30 PM, Bruce Richardson wrote: > On Sat, Feb 03, 2018 at 01:46:34PM +0000, Andrew Rybchenko wrote: >> From: Ivan Malov >> >> Signed-off-by: Ivan Malov >> Signed-off-by: Andrew Rybchenko >> --- >> v2: >> - use includes to extend include directories set >> - limit to x86 architecture >> - specify include directories in base driver build >> - remove unnecessary optimization level set and driver dir from includes >> >> drivers/net/meson.build | 2 +- >> drivers/net/sfc/base/meson.build | 70 ++++++++++++++++++++++++++++++++++++++++ >> drivers/net/sfc/meson.build | 64 ++++++++++++++++++++++++++++++++++++ >> 3 files changed, 135 insertions(+), 1 deletion(-) >> create mode 100644 drivers/net/sfc/base/meson.build >> create mode 100644 drivers/net/sfc/meson.build >> > Thanks, this looks a lot better. > > Unfortunately, it still doesn't compile on ARM, though that is more an > issue with the drivers/meson.build file, than a bug with your driver > specifically. :-( Right now, the base code libraries are still compiled > even when build = "false" because those targets are provided in the > per-driver meson.build files, rather than managed at the top level one. > To properly fix this, in 18.05 I think we should add support at the > top-level driver file for base directories, since so many drivers use > them. That will move the building of base code to the protection of > "build" flag. > > However, since this set doesn't affect any other components, I'd like to > get this into 18.02. To fix it, the following changes need to be made to > your patch. If you are ok with these, I can add these changes on apply. Yes, these changes are OK for us. Thanks. Andrew. > Regards, > /Bruce > > diff --git a/drivers/net/sfc/base/meson.build b/drivers/net/sfc/base/meson.build > index f8314a9bc..f1e497356 100644 > --- a/drivers/net/sfc/base/meson.build > +++ b/drivers/net/sfc/base/meson.build > @@ -62,9 +62,13 @@ foreach flag: extra_flags > endif > endforeach > > -base_lib = static_library('sfc_base', sources, > - include_directories: includes, > - dependencies: static_rte_eal, > - c_args: c_args) > +if build > + base_lib = static_library('sfc_base', sources, > + include_directories: includes, > + dependencies: static_rte_eal, > + c_args: c_args) > > -base_objs = base_lib.extract_all_objects() > + base_objs = base_lib.extract_all_objects() > +else > + base_objs = [] > +endif >