From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4F639A0C46; Tue, 31 Aug 2021 17:41:28 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1D152406A2; Tue, 31 Aug 2021 17:41:26 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id 6BDED40141 for ; Tue, 31 Aug 2021 17:41:25 +0200 (CEST) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id AC98A7F53D; Tue, 31 Aug 2021 18:41:24 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru AC98A7F53D DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1630424484; bh=v+IEtmalOyGTtFnYjF837Zw60oMrgauag5/NnGRTj2A=; h=Subject:From:To:Cc:References:Date:In-Reply-To; b=Ph0f6+qj5UGpcTrfyDhty9SUEdtTw/JU9LP3eIuJcQG8sWN9LBMTTHFXlWtkNnlgt gQylaRl6Blt+wCcjBUmxPw2daJhGc+3ag25Oz3dEtbExaIHDp+kiQHqTWxwlNIO91h OcvMb6Kl1UzTExgqso5GkbGM1RNBPqpIYSUVQYPQ= From: Andrew Rybchenko To: Ajit Khaparde , Somnath Kotur , John Daley , Hyong Youb Kim , Beilei Xing , Qiming Yang , Qi Zhang , Haiyue Wang , Matan Azrad , Shahaf Shuler , Viacheslav Ovsiienko , Thomas Monjalon , Ferruh Yigit Cc: dev@dpdk.org, Viacheslav Galaktionov References: <20210712161747.958019-1-andrew.rybchenko@oktetlabs.ru> <20210820121817.3510013-1-andrew.rybchenko@oktetlabs.ru> Organization: OKTET Labs Message-ID: Date: Tue, 31 Aug 2021 18:41:24 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210820121817.3510013-1-andrew.rybchenko@oktetlabs.ru> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3] ethdev: fix representor port ID search by name X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 8/20/21 3:18 PM, Andrew Rybchenko wrote: > From: Viacheslav Galaktionov > > Getting a list of representors from a representor does not make sense. > Instead, a parent device should be used. > > To this end, extend the rte_eth_dev_data structure to include the port ID > of the parent device for representors. > > Signed-off-by: Viacheslav Galaktionov > Signed-off-by: Andrew Rybchenko > --- > The new field is added into the hole in rte_eth_dev_data structure. > The patch does not change ABI, but extra care is required since ABI > check is disabled for the structure because of the libabigail bug [1]. > > Potentially it is bad for out-of-tree drivers which implement > representors but do not fill in a new parert_port_id field in > rte_eth_dev_data structure. Do we care? > > May be the patch should add lines to release notes, but I'd like > to get initial feedback first. > > mlx5 changes should be reviwed by maintainers very carefully, since > we are not sure if we patch it correctly. > > [1] https://sourceware.org/bugzilla/show_bug.cgi?id=28060 > > v3: > - fix mlx5 build breakage > > v2: > - fix mlx5 review notes > - try device port ID first before parent in order to address > backward compatibility issue > > drivers/net/bnxt/bnxt_reps.c | 1 + > drivers/net/enic/enic_vf_representor.c | 1 + > drivers/net/i40e/i40e_vf_representor.c | 1 + > drivers/net/ice/ice_dcf_vf_representor.c | 1 + > drivers/net/ixgbe/ixgbe_vf_representor.c | 1 + > drivers/net/mlx5/linux/mlx5_os.c | 17 +++++++++++++++++ > drivers/net/mlx5/windows/mlx5_os.c | 17 +++++++++++++++++ > lib/ethdev/ethdev_driver.h | 6 +++--- > lib/ethdev/rte_class_eth.c | 22 ++++++++++++++++++++-- > lib/ethdev/rte_ethdev.c | 8 ++++---- > lib/ethdev/rte_ethdev_core.h | 4 ++++ > 11 files changed, 70 insertions(+), 9 deletions(-) There is later follow up in v2 review notes which should be addressed. I'll send v4 tomorrow.