From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 2EE601B6C3 for ; Wed, 4 Oct 2017 19:44:21 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga105.fm.intel.com with ESMTP; 04 Oct 2017 10:44:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,478,1500966000"; d="scan'208";a="906745083" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.241.225.26]) ([10.241.225.26]) by FMSMGA003.fm.intel.com with ESMTP; 04 Oct 2017 10:44:19 -0700 To: Thomas Monjalon , Kirill Rybalchenko Cc: dev@dpdk.org, andrey.chilikin@intel.com, beilei.xing@intel.com, jingjing.wu@intel.com References: <1503588634-85735-1-git-send-email-kirill.rybalchenko@intel.com> <1505896926-70362-1-git-send-email-kirill.rybalchenko@intel.com> <13345393.msxc2hlS7D@xps> From: Ferruh Yigit Message-ID: Date: Wed, 4 Oct 2017 18:44:19 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <13345393.msxc2hlS7D@xps> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v2 0/2] ethdev: add support for raw flow type for flow director X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Oct 2017 17:44:22 -0000 On 10/4/2017 5:57 PM, Thomas Monjalon wrote: > 03/10/2017 21:02, Ferruh Yigit: >> On 9/20/2017 9:42 AM, Kirill Rybalchenko wrote: >>> For complex packets use raw flow type with pre-constructed packet buffer >>> instead of creating a packet internally in PMD. > > Sorry for not catching this series before. > > As it has been said several times on this mailing list, > the flow director API is deprecated. > I think everybody here knows that it is going to be replaced > by rte_flow. > > That's why it does not make sense to extend flow director. > We are not going to update PMDs to support a new type > of legacy flow director. > Please focus your efforts on rte_flow. As far as I can see this is not to to extend flow director. But driver uses this struct and adding a new feature into driver requires update in this struct. I guess idea was for new filter functionalities PMD should use rte_flow, that is the new shiny method we have, I see the point here. But I don't see the point of making these structs under use completely immutable. > > >>> Kirill Rybalchenko (2): >>> ethdev: add support for raw flow type for flow director >>> net/i40e: add support for raw flow type for flow director >> >> Series Reviewed-by: Ferruh Yigit >