From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 17DC1423C5; Fri, 13 Jan 2023 17:24:34 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B570C410EF; Fri, 13 Jan 2023 17:24:33 +0100 (CET) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2054.outbound.protection.outlook.com [40.107.244.54]) by mails.dpdk.org (Postfix) with ESMTP id 1B2F240E03 for ; Fri, 13 Jan 2023 17:24:32 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Tt8mUTpbvMOdHgwDu6l4Ed9+87rYiL9WCSIxOKzs0gNoEb/0apkcwMjNU7RA6htZlhgeJQPv3x/VZPmfbv3/oYIwn6qFt0l3N2A8S1ln7u+bsLCKhy4V39K/klhUUJPM/1eHHFEFTiUHamD+NuUDly9WHbTMQq9uCqkrms8AtY5ufsvtl3C/8xmoDtC5ZB9VD2GZgjBdnWqvAsacRqTi5cquZxMQbWkNDHt8iEqOvYVObnLVh4q2P5/sHpxjg4N0Dl477FHoh8B1wMNdIogNW0vOqXsF/TI/vwOrFXuc1AdwZ54eGu/XhYwVlldl9Lv4xtrLRuCLCCrkSp6skKCtzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cLjcnvlCJvr4IzfaB8GeLfRQcS9ZF3YiKbS/zsMfQGk=; b=Avng38mbo7VNxeIpTgEQtmUawM9OsHLLtkLg1b9hXS/vtfy9xakdeiiXCO+5MmoiKHJowo8rz1WlH399iBtXN5mcdeL0zwVEptUKB65sfbTRcSiA4VpRTgQK72CVXnHbZgwv4+BH2vG66mc+20hdxCZp4xG9Or+J0YOMK5WoiIDv3scdYzTU8EhsidlDwiB9PFGKBqIx7F5z8DjZ63QpsCsUyrCJAPmY9LsqJm5I0SXL6Y5Q0gViSSsKeepq9oNyNQrkcEUoMmzUAfRWBt6NxWYa8wlht7XqccFni5bfhkGuEcMbd5Y+r1WskE1RFxYyZ211QIO+cJwDYPaPz+kwGw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cLjcnvlCJvr4IzfaB8GeLfRQcS9ZF3YiKbS/zsMfQGk=; b=aRNDIAyHPlAI4ys/jmUDRIXXOIK4Y+g8bCOMTcWAZwqh3BEmmiUNG+YrnFFqCiPYNveG0cATVgYBPLe3RO/TBn5KdNmaSrhPW4SR1pZMjkHck3IFyB/k8LvZ+jHitbhBXrNbiL0nlcG599oJif1AMuHO4Vsvy2+50hV8LVsppkE= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by DM8PR12MB5432.namprd12.prod.outlook.com (2603:10b6:8:32::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.19; Fri, 13 Jan 2023 16:24:30 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::4807:1f44:5e04:e05a]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::4807:1f44:5e04:e05a%9]) with mapi id 15.20.5986.019; Fri, 13 Jan 2023 16:24:30 +0000 Message-ID: Date: Fri, 13 Jan 2023 16:24:23 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Content-Language: en-US To: Raghav Roy , dev@dpdk.org Cc: jbehrens@vmware.com References: <20221221041917.29569-1-royra@vmware.com> <20221222082434.18336-1-royra@vmware.com> From: Ferruh Yigit Subject: Re: [PATCH] net/vmxnet3: added checks for TCP for RSS Configuration In-Reply-To: <20221222082434.18336-1-royra@vmware.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0350.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:d::26) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|DM8PR12MB5432:EE_ X-MS-Office365-Filtering-Correlation-Id: 2a5a650c-eec0-43d2-e218-08daf582a578 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ATn1J9yPMyzQrdtX9zFqzz+gRfs04sYo/N7F8ynWQRD1AselqdMbyqfCb3POJvc1Mt64OLXfieV4GtLucym0vyHpWqOCuOWGP19L2812T7vvCYIiNtrFkw0F+jwQY819eNCjrnxqPtjEr3VZ37fWDB6wne1fX+91WA0xfz0GGQYApumEoENij2bTlsVDg1EDXvVZRyyZX+KDoqMUKeQ39TS/5qbyMOrWRO+XOCnrB4WzkdbqYtIeXCKouWbWYSoXuaxNcvGDVJX4TV7PoGMxNW7ELdOWirkIQA9hl8ZqdHOHUj1CUGgC6tJbYGuayKtUmTVavWvJTfaOBwZcURf7mbcYX7r60W0wJ3ElI8IkAnZ3Fg7xHX9k9aFg1eAWPv0exCpfOLZPiLUZoKHhAX4gc25xX4zD8o9FZaG4wDgfliTgIneWzlXkUKvr2fSt672oeonqjnEAhyMY+p3mbHPejB5GrnGP0HbnoTxXWIbb+jGFVzuIwmpvDISReXSTH6oGUbaHFxq2ssy8gYu55qLEwyPPOjgYVyQSu42sE0B57xGDZsmuGQVgrhNynGt46tHsYOjrNynjS69VwhHrVMLAU5mJt55dELJWjwBiygY8jQu36PtY9vOcw0+fuNpwDuFzfDrwK5q+vQHTlsJs1mW/8lesurxHGOGZS+P8JkFSTzz8WRSuSjk3Jnq14F/I8H240IWzCEQ6pcHk8Zj7N+WFu+qAldNteaEWYNch6DVnnmI= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(376002)(136003)(39860400002)(396003)(346002)(366004)(451199015)(83380400001)(31696002)(44832011)(86362001)(36756003)(38100700002)(316002)(31686004)(2906002)(8676002)(66946007)(66476007)(66556008)(41300700001)(4326008)(8936002)(5660300002)(53546011)(6506007)(6512007)(26005)(186003)(6666004)(2616005)(6486002)(478600001)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L3VjcURXMnNnRWpYTDc5VG1RdUE2YzJGTW5TRDdWMnp0UW5Gby9NdlhVM3Fs?= =?utf-8?B?UEt4VmJUSDVkWXZkV0VBM2hqckg5dWVyNWpjRmZNQ01vRUlEbVpHMWYxMXFz?= =?utf-8?B?YXdxODNHd1VpQUdubFQxN3BWZFh6cEdkUDM5YW5lNksyUGZGL3NYQjN6d210?= =?utf-8?B?RFFtN0lrSFppZEQ2MVhHdlR4UTlmZ2tOQzlCNkVSR3JZZzFRQ25EZDhLMXRI?= =?utf-8?B?SE16ME1QajJZaHQ5MWdSbHNPUWFZdHdzN1JiR0Fod3R1VEJ2ZXVjRUNZZVFz?= =?utf-8?B?ZzQyUjU5Tytudnl3N2ZSaGNZN0FVblRvaTBpSmtiVEZwVXJ1VXROQy94Q1Rl?= =?utf-8?B?ODVDS0JQczZnVFBWZTB1WENGdGozZU1GUEhTQXdxLzFGZ2ZFNnVjT2dSeWFG?= =?utf-8?B?YVAvRGVTMmlGV1k5ZEQ0Y2lRVmNMelJxVURqdzN6cHlXQi9NYUJqUVlOQXVp?= =?utf-8?B?d2lKRzllcm5GS1FHU1JkWDRuVDdNbDZVQTJucWFOR3lVdmJ4N3NSWjZMT3V4?= =?utf-8?B?eWorcXpsUHlWbVR4QjhQRTJjSVlIeUFJZ0dLcDlhVml3aTdGTEdEd3VIQUE5?= =?utf-8?B?b2ViSXVIVE4vRVphdFREWjQ4ejVzWFVvWmxJVWh0U0lzMWhYK3JqbVZ6dTl1?= =?utf-8?B?a0I0UmliMUprbGNhUklac2ZGcFZSdXB1ZEIrQ1diQmFxYlZPdllLVmhWai81?= =?utf-8?B?QktMcE55SXhlZWJjeVU1amh3QzNmZlhwbWZGYlVVampvdzJlWmU3OVh2QkJL?= =?utf-8?B?QVR3MnpxR296OFlzT0Z4ckkvSTdHc1dEQVhuSFpZaGZTYitSMnV5VU83M0JF?= =?utf-8?B?YUh3UU50Wkh1ekJNUi9DL1BtbUp1R3pJSlpNTEg3TjBTalR1cHlRQzBUK1lE?= =?utf-8?B?YW12VDhYWlNZYlJTMDJTak1lNk00ckl0SjhiZTliZDcveGNQOVUrRHlhWkEz?= =?utf-8?B?Z1hiczFDdnEya1Rmbmc1MHVlMzJwQm5oMEk2Vm9GeTlGNmJjREFhcHdVZUdn?= =?utf-8?B?QkJudEUwWktmZXJrQzBYcTFDODBFUEV2ZFVXRkp1bjRnTVVIdFEvR0RKMmxj?= =?utf-8?B?aGFOVnlrdEIxUGJybm9KZ0JWR2lwQzhqUUhvTktMMS9hV2ZUVlVlZ3dMSWtS?= =?utf-8?B?NGZXQk4zNzNySm0wQTJJSU1zQU8vY0J5akYrZk5VazVOc29GbW5tYWpML0pU?= =?utf-8?B?V1BVekp1UGowNXFlOTVwdDFiVXpxVm9kVmxYQ1dwa2xJZnRDQzUydzFhdElt?= =?utf-8?B?N1lKNmRENEtzQTI4WXV0N3pSVXI4WVVjWTJ5NmhJTjBkcDc5UWJtdzhhakNM?= =?utf-8?B?MFRZNXFvZnlVbkNJMkVmT2F1anpTWlFtaXRxbTRXckdhMzhWUWMxakVmQzdw?= =?utf-8?B?R2Y1c2tLZ0NPUkRvNjNYWW5ERndLeWQ2dlptdm4wWGFETEdUVzJDNlhyRnA1?= =?utf-8?B?REJRWk9TNXVBMERlWVh3WkpzOEVKV0I1dE5qTk9XamZGUWpMU013UEJMbjB4?= =?utf-8?B?RlpxaCtzcnI3VTFmZHM0TUlLWDhqdUU4eTlneUFpbjBUZUQzckNHckc2UnA4?= =?utf-8?B?Y3ZwUkhjTXBISXI2TDN1QTRXS3JJZlpPQkdYWFl3aGFvNGhrYTU4TElNNEdy?= =?utf-8?B?aVgyanJxS0tGajllcmd1eUZqVDYrSmFqdmtTWnNrRlVkZFlIMjBSajdqblFX?= =?utf-8?B?aTJOekUzVkI1SGJ1QklucVZkeTVwbUE3ZlhmQm8rclloN1cveGVFOFE1MzR6?= =?utf-8?B?MkJJNmJrN2xxNTg2OXI1Sk9iOFllemhTSHp6bjJ3VHVEajhVSzRCc2JWT2c3?= =?utf-8?B?bnk0eVdpWHgwZjhsTHRGSTFVeFdLYjVjeU13UDdkaDE3UFZFWmFTekhSd3Ur?= =?utf-8?B?Um42Ty9RQ0paWFo3NDhFcHpEbVZqMllaMVZnMkNMdmw4WUtpSzdzWmQ4QlNJ?= =?utf-8?B?aE9XaXRTODJjR24vUXBUeHprdy9XdjY0NXRmd2QrQWxBSGdRZmZockZtZGcr?= =?utf-8?B?R0lRN1pKeVU4cTJQZVhzd1p3NllsV2ttbHBWT1ltdU4rck13ajd5WUs0Wndh?= =?utf-8?B?UDlya2NEZmhUU2pkOUoyVjRrcUtLYjhXOWdOekRUZldzdnhkNm1idlJDWVlF?= =?utf-8?Q?/AAZVY3H07mXHuV3l1hyGEMKA?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2a5a650c-eec0-43d2-e218-08daf582a578 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jan 2023 16:24:29.9718 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: GM/7i0Y7kjj5+qJm1SRSLlDxQZF1gF1DAH7eLiVqTP4zlCb+tcHacyEXoIAfQUHP X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR12MB5432 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 12/22/2022 8:24 AM, Raghav Roy wrote: > Added checks for TCP in vmxnet3_rss_configure() > This check ensures the hashType for RSS, when enabled > just for UDP, is not NONE. > Mandatory hash functions for v4 already added in the past: Commit 52ec00fd1474 ("net/vmxnet3: fix RSS setting on v4") Now this commit adds it for all versions, why it was fine in the past but it is needed now? @Jochen, can you please help reviewing this patch? > Signed-off-by: Raghav Roy > --- > drivers/net/vmxnet3/vmxnet3_rxtx.c | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/vmxnet3/vmxnet3_rxtx.c b/drivers/net/vmxnet3/vmxnet3_rxtx.c > index a875ffec07..e8407c9b2e 100644 > --- a/drivers/net/vmxnet3/vmxnet3_rxtx.c > +++ b/drivers/net/vmxnet3/vmxnet3_rxtx.c > @@ -1412,6 +1412,13 @@ vmxnet3_rss_configure(struct rte_eth_dev *dev) > dev_rss_conf = hw->rss_conf; > port_rss_conf = &dev->data->dev_conf.rx_adv_conf.rss_conf; > > + if ((port_rss_conf->rss_hf & VMXNET3_MANDATORY_V4_RSS) != > + VMXNET3_MANDATORY_V4_RSS) { > + PMD_INIT_LOG(WARNING, "RSS: IPv4/6 TCP is required for vmxnet3 RSS, " > + "automatically setting it"); > + port_rss_conf->rss_hf |= VMXNET3_MANDATORY_V4_RSS; > + } > + ` #define VMXNET3_MANDATORY_V4_RSS ( \ RTE_ETH_RSS_NONFRAG_IPV4_TCP | \ RTE_ETH_RSS_NONFRAG_IPV6_TCP) ` Can you please describe why IPv4/6 TCP hash function is required for driver? And what is the impact, I mean what is the observed behavior without this patch, if RSS is failing without this change patch needs to be fix patch and please describe since when RSS is failing. > /* loading hashFunc */ > dev_rss_conf->hashFunc = VMXNET3_RSS_HASH_FUNC_TOEPLITZ; > /* loading hashKeySize */ > @@ -1419,6 +1426,7 @@ vmxnet3_rss_configure(struct rte_eth_dev *dev) > /* loading indTableSize: Must not exceed VMXNET3_RSS_MAX_IND_TABLE_SIZE (128)*/ > dev_rss_conf->indTableSize = (uint16_t)((MAX_RX_QUEUES(hw)) * 4); > > + > if (port_rss_conf->rss_key == NULL) { > /* Default hash key */ > port_rss_conf->rss_key = rss_intel_key; > @@ -1446,6 +1454,5 @@ vmxnet3_rss_configure(struct rte_eth_dev *dev) > dev_rss_conf->hashType |= VMXNET3_RSS_HASH_TYPE_IPV6; > if (rss_hf & RTE_ETH_RSS_NONFRAG_IPV6_TCP) > dev_rss_conf->hashType |= VMXNET3_RSS_HASH_TYPE_TCP_IPV6; > - Please drop unrelated/unimportant syntax changes. > return VMXNET3_SUCCESS; > }