From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3A3F6A0C43; Mon, 18 Oct 2021 18:47:59 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CFE2C40142; Mon, 18 Oct 2021 18:47:58 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id 1E0DA40141 for ; Mon, 18 Oct 2021 18:47:56 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10141"; a="209085637" X-IronPort-AV: E=Sophos;i="5.85,382,1624345200"; d="scan'208";a="209085637" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Oct 2021 09:47:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,382,1624345200"; d="scan'208";a="566132105" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by FMSMGA003.fm.intel.com with ESMTP; 18 Oct 2021 09:47:43 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Mon, 18 Oct 2021 09:47:42 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Mon, 18 Oct 2021 09:47:42 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Mon, 18 Oct 2021 09:47:42 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.175) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Mon, 18 Oct 2021 09:47:42 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=b7JIjkQRpBxpv80Dl7Z5f2Jbd6FIKjJbuVCWxOIbWtCO1N2P0CXV42If0iGcbd6G/QTDyt4zbOyOE83+JBZujMFMBb/PzHOwx+qtP4EYvsSLFC6LNuPb9EnCVL6TONDk+wBNxkoEo8cV256AoN2tke057pjepCmXFo2bgq94orVlKXWnz8wbgiKLHOCf3WOZYmEv/SVPk0Utf4WAOq7VRGQFqVb7OCOaHB1Hc3UUbcoQ2TdYK4WmFj3whsjKGgRYVtpdwcyPASjx9q+/0V/X0MXgxZegF2+CfyRo+J2AfU2qw2wiyat6760kflTITn127HKm2HvoimBC9BsMyJOAOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TmebiyLdzkM/vMy0DMA+th9IuQTH4OZSTvT1A96pEn8=; b=Bqrdz9Q/xeVOpYx5G1860o2dRxDZTojZlxHljHkiYKP7tTQ3lWpkd9s4fD8f8iAcbW1CfnymiS7tgK1+nj1gEhw7NM+9ImpFFHRyCFJDYJsvA3dHWJ3bsZMN3EUEUEyGXLtwR28qXxP7Tq1r1L42tW3nXTl0kGGYV/qo0LEpixOomzldDGE9lMN1Ju/tBG7eqhmE1NURKblv6C9m3junjxpD9myjH93jN+V3gVds7LxDdAiFOGeT/f7Hty1ls0ZfEzxwk4PeoSxIiTLmbE1rCbmQ9wr5ffE3xNzfdUm/FwNPlo/14ayuEeazE1HMCtxJiD3Spx8J7MSiJX09Itwc2Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TmebiyLdzkM/vMy0DMA+th9IuQTH4OZSTvT1A96pEn8=; b=sxOVB41EMlN+JDXBDt8aZBfMGhVIlD9J/Wwlan0hybmwJNDMHa/qzR++lYWNhgZniHbJXLQVU+CBOUR6cjEeL8AMiNnDgTr1ZOGBVVgKEd1Leip4H6c7da2x2kcA0IcxXef6s+BT9276GXd2A0bp9aEo5XWmp83v8PlLeQpb2jo= Authentication-Results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB5176.namprd11.prod.outlook.com (2603:10b6:510:3f::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.17; Mon, 18 Oct 2021 16:47:32 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c%5]) with mapi id 15.20.4608.018; Mon, 18 Oct 2021 16:47:32 +0000 Message-ID: Date: Mon, 18 Oct 2021 17:47:19 +0100 Content-Language: en-US To: Ali Alnubani , Konstantin Ananyev , "dev@dpdk.org" , "jerinj@marvell.com" , Ajit Khaparde , Raslan Darawsheh , "Andrew Rybchenko" , Qi Zhang , Honnappa Nagarahalli CC: "xiaoyun.li@intel.com" , "anoobj@marvell.com" , "ndabilpuram@marvell.com" , "adwivedi@marvell.com" , "shepard.siegel@atomicrules.com" , "ed.czeck@atomicrules.com" , "john.miller@atomicrules.com" , "irusskikh@marvell.com" , "somnath.kotur@broadcom.com" , "rahul.lakkireddy@chelsio.com" , "hemant.agrawal@nxp.com" , "sachin.saxena@oss.nxp.com" , "haiyue.wang@intel.com" , "johndale@cisco.com" , "hyonkim@cisco.com" , "xiao.w.wang@intel.com" , "humin29@huawei.com" , "yisen.zhuang@huawei.com" , "oulijun@huawei.com" , "beilei.xing@intel.com" , "jingjing.wu@intel.com" , "qiming.yang@intel.com" , Matan Azrad , Slava Ovsiienko , "sthemmin@microsoft.com" , NBU-Contact-longli , "heinrich.kuhn@corigine.com" , "kirankumark@marvell.com" , "mczekaj@marvell.com" , "jiawenwu@trustnetic.com" , "jianwang@trustnetic.com" , "maxime.coquelin@redhat.com" , "chenbo.xia@intel.com" , NBU-Contact-Thomas Monjalon , "mdr@ashroe.eu" , "jay.jayatheerthan@intel.com" References: <0211007112750.25526-1-konstantin.ananyev@intel.com> <20211013133704.31296-1-konstantin.ananyev@intel.com> <13c451b3-e138-810d-2250-18d30dce8f99@intel.com> From: Ferruh Yigit X-User: ferruhy In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DB6PR0301CA0050.eurprd03.prod.outlook.com (2603:10a6:4:54::18) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DB6PR0301CA0050.eurprd03.prod.outlook.com (2603:10a6:4:54::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.14 via Frontend Transport; Mon, 18 Oct 2021 16:47:24 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b4f6c9c6-8851-451b-ce2a-08d99256fad0 X-MS-TrafficTypeDiagnostic: PH0PR11MB5176: X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: nOJqPkEVrnVBot52nQjZEnuaEHFkJYQf+0FzFrgaI7v3dEHqAcFQPEjoxgRR9VrcyfiTAf4U5T9yjHolj8xm5Vu9hvXGxlj9AVu/UkK1Jinmsixm3x7r6c1i6bLQ58UzmRO7wXW8K4ekgA1sMWuRH/5TuYskAhbHvgbVnZsxMzT+nSqOD7jQ4T5T8xP5cvsDE74gbNS8Ahtz4sMk7xeYNadQW+axgU9dEULmLWXiVBpadgEBGNDA18ocLATCxwOdzeDOV6cKJeGkY4mVLG2dKfs8+9OjzwOh3wBwYtLmUu67oUDnVVz8mDAU6tuBn8kyrFWMUGgHnjHt7OzR3gnGq+J2A2HbnBAfflPtuknKgBhS42AA/OvZ+lqIrb3FzyWqeLkLPjuyRMK8+a0OEuqq1yl3Q2XJvIUMoDBoRlUcrQSYHLHoNC0sFDC2CYLcPuCl3gwgwq2gzjbxuzLHX2LUYvae4Qy742pUEaaycFId0HMZN36VtzhILuoRNlP/ZQS9o1/1anSc+KDTsTUWY1t0B4mdkEAwYLZNCzIRWfQEy5kEqb72hqu1fFfmZv7wKeD06EDsRmqngCFuIrcnUNTB4IMAT+dB8PgdrPYOlcKdJGP/hS8ZVtINOgL0hwszpWVj8RI7Pk2SuHbHFEWb5SpbfGX4e2+WscL5eTNlmB1pF7JDQMQkDkcbkX+tD3tbIYvTOURbnW0BeuZSGvmHojRZydNw4gklpUBGIJW3bhtARYQHW53bs7th4XE9e50vvJVDcv89YGBarLyQy8Kq9x/6ypMZ6Y/N/bdt5YwlpIqMxEYucmNY+vYedZHP1hrcpbGFQ5pPvwQfYDONfGIr/4+6fA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(82960400001)(36756003)(83380400001)(26005)(186003)(508600001)(66946007)(38100700002)(316002)(7406005)(966005)(6486002)(956004)(7416002)(110136005)(53546011)(8676002)(45080400002)(2906002)(8936002)(107886003)(16576012)(5660300002)(66556008)(66476007)(6666004)(54906003)(31696002)(86362001)(31686004)(4326008)(2616005)(44832011)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ekdmQjZ6RFpxeVFRMVd3Q2tvV3BhV0U1MXIyNTlPK2Ewa0xXTGVuV3ZQL3Vk?= =?utf-8?B?aHpUck11enRBQVI1QzZVaEhudkdaVHl0SkVIVExVUUUwb0o0MFphbVcxeCtp?= =?utf-8?B?cWtYUEFjTWNUU0FrVFhrem5vSXM0THA1dTFMeGE2Sm5KbVpJdk8zaVFqd3cy?= =?utf-8?B?L3NpYm42cUlIU1I2bWtjSVVTQ3BoSFg4VGRVR0l3dFZWMkNmVnRSWmR4bmI0?= =?utf-8?B?ZHFtMm5jVUZqcHVoQUJWdzBzNkNWL0JiVWVTeG5lSHJQQkM5NU9yWHQxd3Vm?= =?utf-8?B?L0JJQmhvUCtIdkdrWE50RnZwaHNJVE1GcmZuMVRXY1BHVFNFWFFtVjNtTE9t?= =?utf-8?B?RHF5TWVVUkxrNTRnek01dWpzUE9EK0Q5TVJ2VGl0OWgxRzlHVmRjbHl3ZFVn?= =?utf-8?B?WEhmM05wRGZEdHYvNnF1QTNua1EzTU0raHQrWjZZdWFzQW14K0F5K2RyUnZ6?= =?utf-8?B?RUhSZVNkdW1uZUprNlJMUEE0b3RBcHNLWTd1bHkyczlpaXJOQkFOQ0pycERy?= =?utf-8?B?cVpYeXhhOWNrcDlHTThTQTlqT3NmbXJ5NFFyeEJ3UmkwaVRuNVB3SGxCWFJz?= =?utf-8?B?OXVvNHZvTkZuQTdLKyt6LzMvVXRsVGtlVmdDUzBrSVh2bklmZjg2ejh2YS96?= =?utf-8?B?TUk3Y3c2SHZudmM2bjJFVU1nNFZDaVlDRkRwdmZPOHlxdnh3RkVWSi9Yam9n?= =?utf-8?B?bjB0QXlwVHlrYUdaSExtdUZlU00yNmZqMU5hYVVKMmNTbUJuUUVhQVFHYVhV?= =?utf-8?B?eHN1eGpKcUdEQkVUUFJwRGF3a2NkTlhraDRLNGNIditmZy9odll4NVRub1lj?= =?utf-8?B?ZGRXNzVmbVhsL1ZTVjBEenBsdWxCcHFkelVhaUVjV1IrNXhBb0dzWXVsV0xY?= =?utf-8?B?TlNGb1pHbm9lRGU4VndUbEYyTFd3WXRLOGs2cmVRK0t3UElqd1B3cXdTQzhY?= =?utf-8?B?VWVRVXlNMWxSNlJRa3VDTURZZVpMZi81VGlkSEhUQ0hDWXh5QnJRLzljZU1w?= =?utf-8?B?NTFGVFd1SDlBaGJmd0M1SFVqbXlFMU13UGlNVENaekpxK1FkZjd2QTFiTDVH?= =?utf-8?B?VXB4dFNrTWJVbHZmeThxNGsyQkMyYnVid09Bb3Exd2U3b3pwbFRLNnN1MkxU?= =?utf-8?B?dHpnck5aV2Ezenh0cDNtY0s4L3JMR0FycmFYZmdnSG1BOEgzUUtrdHJTSktl?= =?utf-8?B?Z0dodDJMU081VXBhWE8rQWxVVFBYa0ZVb0d5d3B3WDQ2dTRLcXpNcHhqeWtH?= =?utf-8?B?YVZ5NWhyWkpyamNtU0VYMEFOSjB0SGtFMjFURlkrMDZVbWl3d2dJTmdLdEh5?= =?utf-8?B?M2I4Q2xTcXkvemxPWWVld0dMYnRvR1JEbzdydkNZNjZHMU5va3VQVm1LMndE?= =?utf-8?B?TUlKUHR2QnJYT2VzenpESXVXUzhMZ05SeFdibS8zN25OOVhiMWxWejlzeWhH?= =?utf-8?B?U1FtSE1TMzB0eWlJT3BYVFJESlpHZjlMSVZDTkhSVXZRVUJweENYSlFQb1U1?= =?utf-8?B?UVpXRkpSd25SRmpXSGFYMWV3QVVCR2p2VTh2SmJkcXdJY3VTcnJlb1lQTEF3?= =?utf-8?B?b0RJaWFvb3REbm5lblc1WnRPcUtCb3IyWkVSSHBYVHhFTEZoK0d0clUwVzZR?= =?utf-8?B?ZUtOYzJudU5xK1oxb0tBY0twdHBRV0pyZDVyUEpXUERUZmxhQXk2VjJ2T3R2?= =?utf-8?B?RDlERlE5QmN1YXRaeStCMytQaERWUFZGZUhmdS9OMXorZkRPZEtHQ1l1VFV6?= =?utf-8?Q?5/ipc018gy9JgSXEGGWJc9gGzNnPnhmRJ/7SaHg?= X-MS-Exchange-CrossTenant-Network-Message-Id: b4f6c9c6-8851-451b-ce2a-08d99256fad0 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2021 16:47:32.6917 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 6wAUlV+nJj8X3eAeThHV5dX4F3BkupUz5XruliK/10ceZnfaggqC3uvRjebh6jckjKYIgAMdEnQ8IxDd3/B6ow== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5176 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v6 0/6] hide eth dev related structures X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/18/2021 5:04 PM, Ali Alnubani wrote: >> -----Original Message----- >> From: dev On Behalf Of Ferruh Yigit >> Sent: Wednesday, October 13, 2021 11:16 PM >> To: Konstantin Ananyev ; dev@dpdk.org; >> jerinj@marvell.com; Ajit Khaparde ; Raslan >> Darawsheh ; Andrew Rybchenko >> ; Qi Zhang ; >> Honnappa Nagarahalli >> Cc: xiaoyun.li@intel.com; anoobj@marvell.com; jerinj@marvell.com; >> ndabilpuram@marvell.com; adwivedi@marvell.com; >> shepard.siegel@atomicrules.com; ed.czeck@atomicrules.com; >> john.miller@atomicrules.com; irusskikh@marvell.com; >> ajit.khaparde@broadcom.com; somnath.kotur@broadcom.com; >> rahul.lakkireddy@chelsio.com; hemant.agrawal@nxp.com; >> sachin.saxena@oss.nxp.com; haiyue.wang@intel.com; johndale@cisco.com; >> hyonkim@cisco.com; qi.z.zhang@intel.com; xiao.w.wang@intel.com; >> humin29@huawei.com; yisen.zhuang@huawei.com; oulijun@huawei.com; >> beilei.xing@intel.com; jingjing.wu@intel.com; qiming.yang@intel.com; >> Matan Azrad ; Slava Ovsiienko >> ; sthemmin@microsoft.com; NBU-Contact-longli >> ; heinrich.kuhn@corigine.com; >> kirankumark@marvell.com; andrew.rybchenko@oktetlabs.ru; >> mczekaj@marvell.com; jiawenwu@trustnetic.com; >> jianwang@trustnetic.com; maxime.coquelin@redhat.com; >> chenbo.xia@intel.com; NBU-Contact-Thomas Monjalon >> ; mdr@ashroe.eu; jay.jayatheerthan@intel.com >> Subject: Re: [dpdk-dev] [PATCH v6 0/6] hide eth dev related structures >> >> On 10/13/2021 2:36 PM, Konstantin Ananyev wrote: >>> v6 changes: >>> - Update comments (Andrew) >>> - Move callback related variables under corresponding ifdefs (Andrew) >>> - Few nits in rte_eth_macaddrs_get (Andrew) >>> - Rebased on top of next-net tree >>> >>> v5 changes: >>> - Fix spelling (Thomas/David) >>> - Rename internal helper functions (David) >>> - Reorder patches and update commit messages (Thomas) >>> - Update comments (Thomas) >>> - Changed layout in rte_eth_fp_ops, to group functions and >>> related data based on their functionality: >>> first 64B line for Rx, second one for Tx. >>> Didn't observe any real performance difference comparing to >>> original layout. Though decided to keep a new one, as it seems >>> a bit more plausible. >>> >>> v4 changes: >>> - Fix secondary process attach (Pavan) >>> - Fix build failure (Ferruh) >>> - Update lib/ethdev/verion.map (Ferruh) >>> Note that moving newly added symbols from EXPERIMENTAL to DPDK_22 >>> section makes checkpatch.sh to complain. >>> >>> v3 changes: >>> - Changes in public struct naming (Jerin/Haiyue) >>> - Split patches >>> - Update docs >>> - Shamelessly included Andrew's patch: >>> https://patches.dpdk.org/project/dpdk/patch/20210928154856.1015020- >> 1-andrew.rybchenko@oktetlabs.ru/ >>> into these series. >>> I have to do similar thing here, so decided to avoid duplicated effort. >>> >>> The aim of these patch series is to make rte_ethdev core data structures >>> (rte_eth_dev, rte_eth_dev_data, rte_eth_rxtx_callback, etc.) internal to >>> DPDK and not visible to the user. >>> That should allow future possible changes to core ethdev related structures >>> to be transparent to the user and help to improve ABI/API stability. >>> Note that current ethdev API is preserved, but it is a formal ABI break. >>> >>> The work is based on previous discussions at: >>> https://www.mail-archive.com/dev@dpdk.org/msg211405.html >>> https://www.mail-archive.com/dev@dpdk.org/msg216685.html >>> and consists of the following main points: >>> 1. Copy public 'fast' function pointers (rx_pkt_burst(), etc.) and >>> related data pointer from rte_eth_dev into a separate flat array. >>> We keep it public to still be able to use inline functions for these >>> 'fast' calls (like rte_eth_rx_burst(), etc.) to avoid/minimize slowdown. >>> Note that apart from function pointers itself, each element of this >>> flat array also contains two opaque pointers for each ethdev: >>> 1) a pointer to an array of internal queue data pointers >>> 2) points to array of queue callback data pointers. >>> Note that exposing this extra information allows us to avoid extra >>> changes inside PMD level, plus should help to avoid possible >>> performance degradation. >>> 2. Change implementation of 'fast' inline ethdev functions >>> (rte_eth_rx_burst(), etc.) to use new public flat array. >>> While it is an ABI breakage, this change is intended to be transparent >>> for both users (no changes in user app is required) and PMD developers >>> (no changes in PMD is required). >>> One extra note - with new implementation RX/TX callback invocation >>> will cost one extra function call with this changes. That might cause >>> some slowdown for code-path with RX/TX callbacks heavily involved. >>> Hope such trade-off is acceptable for the community. >>> 3. Move rte_eth_dev, rte_eth_dev_data, rte_eth_rxtx_callback and >> related >>> things into internal header: . >>> >>> That approach was selected to: >>> - Avoid(/minimize) possible performance losses. >>> - Minimize required changes inside PMDs. >>> >>> Performance testing results (ICX 2.0GHz, E810 (ice)): >>> - testpmd macswap fwd mode, plus >>> a) no RX/TX callbacks: >>> no actual slowdown observed >>> b) bpf-load rx 0 0 JM ./dpdk.org/examples/bpf/t3.o: >>> ~2% slowdown >>> - l3fwd: no actual slowdown observed >>> >>> Would like to thank everyone who already reviewed and tested previous >>> versions of these series. All other interested parties please don't be shy >>> and provide your feedback. >>> >>> Konstantin Ananyev (6): >>> ethdev: allocate max space for internal queue array >>> ethdev: change input parameters for rx_queue_count >>> ethdev: copy fast-path API into separate structure >>> ethdev: make fast-path functions to use new flat array >>> ethdev: add API to retrieve multiple ethernet addresses >>> ethdev: hide eth dev related structures >>> >> >> For series, >> Reviewed-by: Ferruh Yigit >> >> No performance regression detected on my testing. >> >> I am merging the series to next-net now which helps testing, >> but before merging to main repo it will be good to get more >> ack and test results (I can squash new tags later). >> >> @Jerin, @Ajit, @Raslan, @Andrew, @Qi, @Honnappa, >> Can you please test this set for any possible regression? >> >> Series applied to dpdk-next-net/main, thanks. >> > > Tested (on dpdk-next-net/main) single and multi-core packet forwarding performance with testpmd on both ConnectX-5 and ConnectX-6 Dx. I didn't see any noticeable regressions. > Thanks! At this stage I am putting set to pull request for main repo. Last day for anyone who wants to test the set.