From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <luca.boccassi@gmail.com>
Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com
 [209.85.128.67]) by dpdk.org (Postfix) with ESMTP id 429534F9B
 for <dev@dpdk.org>; Wed,  6 Mar 2019 14:25:24 +0100 (CET)
Received: by mail-wm1-f67.google.com with SMTP id x10so5845326wmg.2
 for <dev@dpdk.org>; Wed, 06 Mar 2019 05:25:24 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to
 :references:content-transfer-encoding:user-agent:mime-version;
 bh=2K7oGetHE1njOW0q9/Zvzr92u0oAJ1cnw/BTcBDj+jE=;
 b=l0ZMPQVsbgVU654BQmoIFS63Eq/YQrm9XI2hQd1Lh94lVq15n8PFHd3FTDb9pCv7ky
 2R/gCIxAXPq6W9TQjBNogUIgRBZ0uLUQKAiaDrcn4iBJB+Bv0khQZA8Bqbj7iygCCWpy
 uh/VfWJ+iKVJDowr3LJzvc7D3ufSW1X+md8kMQzudl/w+tYUUuhXbs0rL/yRCDhEc/z4
 rt6ozwL4JB+LXZTYqV26fgr6c69d6pnqBgnoS326tOFOVZyQ1oJUteYbhsByKP0XGmcL
 cm/hbgSNXLStvDLrf2D+bQsTwpa/M92wm3q41RtSVMwWiOzwpKIaocX+ueYbijrP4nS0
 eZGQ==
X-Gm-Message-State: APjAAAXlMMUR5FCGXGzwuIzmToDlFqDKl3wWSrjTUI9ul3GrpyLf5+gR
 vCkWRcZRkGkCCOJGYExrljo=
X-Google-Smtp-Source: APXvYqxusZmGPyMKHeGwUeVueR+hS7GcQdObB3yanH1TTnqNe9hFY9toRRcRwhtaRsz9ivB+Gp0zfA==
X-Received: by 2002:a7b:c08a:: with SMTP id r10mr2344949wmh.112.1551878723640; 
 Wed, 06 Mar 2019 05:25:23 -0800 (PST)
Received: from localhost ([2a01:4b00:f419:6f00:b00c:66c8:99df:336])
 by smtp.gmail.com with ESMTPSA id y8sm813190wrm.8.2019.03.06.05.25.21
 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
 Wed, 06 Mar 2019 05:25:22 -0800 (PST)
Message-ID: <ea00c17399f7ff7a92537ce53068cf231e336827.camel@debian.org>
From: Luca Boccassi <bluca@debian.org>
To: Rastislav =?UTF-8?Q?=C4=8Cernay?= <cernay@netcope.com>
Cc: dev <dev@dpdk.org>
Date: Wed, 06 Mar 2019 13:25:21 +0000
In-Reply-To: <CAGS_BLmdKdviXXHPpUa7-KsJtZOvS0QLG-ssQ=VRxBwBAjnhAg@mail.gmail.com>
References: <1551185824-5501-2-git-send-email-cernay@netcope.com>
 <1551451054-111249-1-git-send-email-cernay@netcope.com>
 <130a4780434ea30138a7c98f5689da143c73a8a1.camel@debian.org>
 <CAGS_BLmdKdviXXHPpUa7-KsJtZOvS0QLG-ssQ=VRxBwBAjnhAg@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.30.5-1 
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v3] net/nfb: new netcope driver
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 06 Mar 2019 13:25:25 -0000

On Wed, 2019-03-06 at 15:51 +0100, Rastislav =C4=8Cernay wrote:
> >=20
> > --Why is -lfdt added? I don't see any symbols from libfdt used in
> > the
> > --rest of the patch?
> >=20
>=20
> Hi,
> libnfb is dependent on fdt and there is a special case, where some
> functions are defined in header (netcope/rxmac.h, netcope/txmac.h).
> So if one wants to use functions, from these headers fdt needs to be
> linked
> manually, not just through nfb. I also added fdt to meson.build
> so it is little clearer, however if libnfb is installed libfdt is
> always
> installed too.

This is a perfect use case for pkg-config. Please consider shipping a
libnfb.pc file in libnfb, so that you can define a Libs.private: -fdt
and users don't have to worry about these things themselves.

--=20
Kind regards,
Luca Boccassi