From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 971EDA0577; Tue, 14 Apr 2020 11:07:22 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D44861C2A8; Tue, 14 Apr 2020 11:07:21 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 8B3F71C2A8 for ; Tue, 14 Apr 2020 11:07:19 +0200 (CEST) IronPort-SDR: QjjSFW8aLRZtBYZ8sTkDclo8ASWBHiOsiXkxCK4CAO69ogOqMEvkI6K1i/wooG1UoMxaGW9f2D WMuTbhO8DRJw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Apr 2020 02:07:18 -0700 IronPort-SDR: xXw73TSVrXpUHS/Zb2eSIFszYmq5UCHmqFc/MfV8SX9QG6uGpH3cMg2G701/CuZeMjew5D9vW2 xiLjr4DCb+Dg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,382,1580803200"; d="scan'208";a="241930369" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.252.18.191]) ([10.252.18.191]) by orsmga007.jf.intel.com with ESMTP; 14 Apr 2020 02:07:14 -0700 To: Slava Ovsiienko , "dev@dpdk.org" Cc: Thomas Monjalon , "bernard.iremonger@intel.com" References: <1561553317-16777-1-git-send-email-viacheslavo@mellanox.com> <1584625851-10291-1-git-send-email-viacheslavo@mellanox.com> <1584625851-10291-2-git-send-email-viacheslavo@mellanox.com> <9f95eb9a-c7c3-17c6-afc6-0a0d20847e08@intel.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata= mQINBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABtCVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+iQJUBBMBCgA+AhsDAh4BAheABQsJCAcDBRUK CQgLBRYCAwEAFiEE0jZTh0IuwoTjmYHH+TPrQ98TYR8FAl1meboFCQlupOoACgkQ+TPrQ98T YR9ACBAAv2tomhyxY0Tp9Up7mNGLfEdBu/7joB/vIdqMRv63ojkwr9orQq5V16V/25+JEAD0 60cKodBDM6HdUvqLHatS8fooWRueSXHKYwJ3vxyB2tWDyZrLzLI1jxEvunGodoIzUOtum0Ce gPynnfQCelXBja0BwLXJMplM6TY1wXX22ap0ZViC0m714U5U4LQpzjabtFtjT8qOUR6L7hfy YQ72PBuktGb00UR/N5UrR6GqB0x4W41aZBHXfUQnvWIMmmCrRUJX36hOTYBzh+x86ULgg7H2 1499tA4o6rvE13FiGccplBNWCAIroAe/G11rdoN5NBgYVXu++38gTa/MBmIt6zRi6ch15oLA Ln2vHOdqhrgDuxjhMpG2bpNE36DG/V9WWyWdIRlz3NYPCDM/S3anbHlhjStXHOz1uHOnerXM 1jEjcsvmj1vSyYoQMyRcRJmBZLrekvgZeh7nJzbPHxtth8M7AoqiZ/o/BpYU+0xZ+J5/szWZ aYxxmIRu5ejFf+Wn9s5eXNHmyqxBidpCWvcbKYDBnkw2+Y9E5YTpL0mS0dCCOlrO7gca27ux ybtbj84aaW1g0CfIlUnOtHgMCmz6zPXThb+A8H8j3O6qmPoVqT3qnq3Uhy6GOoH8Fdu2Vchh TWiF5yo+pvUagQP6LpslffufSnu+RKAagkj7/RSuZV25Ag0EV9ZMvgEQAKc0Db17xNqtSwEv mfp4tkddwW9XA0tWWKtY4KUdd/jijYqc3fDD54ESYpV8QWj0xK4YM0dLxnDU2IYxjEshSB1T qAatVWz9WtBYvzalsyTqMKP3w34FciuL7orXP4AibPtrHuIXWQOBECcVZTTOdZYGAzaYzxiA ONzF9eTiwIqe9/oaOjTwTLnOarHt16QApTYQSnxDUQljeNvKYt1lZE/gAUUxNLWsYyTT+22/ vU0GDUahsJxs1+f1yEr+OGrFiEAmqrzpF0lCS3f/3HVTU6rS9cK3glVUeaTF4+1SK5ZNO35p iVQCwphmxa+dwTG/DvvHYCtgOZorTJ+OHfvCnSVjsM4kcXGjJPy3JZmUtyL9UxEbYlrffGPQ I3gLXIGD5AN5XdAXFCjjaID/KR1c9RHd7Oaw0Pdcq9UtMLgM1vdX8RlDuMGPrj5sQrRVbgYH fVU/TQCk1C9KhzOwg4Ap2T3tE1umY/DqrXQgsgH71PXFucVjOyHMYXXugLT8YQ0gcBPHy9mZ qw5mgOI5lCl6d4uCcUT0l/OEtPG/rA1lxz8ctdFBVOQOxCvwRG2QCgcJ/UTn5vlivul+cThi 6ERPvjqjblLncQtRg8izj2qgmwQkvfj+h7Ex88bI8iWtu5+I3K3LmNz/UxHBSWEmUnkg4fJl Rr7oItHsZ0ia6wWQ8lQnABEBAAGJAjwEGAEKACYCGwwWIQTSNlOHQi7ChOOZgcf5M+tD3xNh HwUCXWZ5wAUJB3FgggAKCRD5M+tD3xNhH2O+D/9OEz62YuJQLuIuOfL67eFTIB5/1+0j8Tsu o2psca1PUQ61SZJZOMl6VwNxpdvEaolVdrpnSxUF31kPEvR0Igy8HysQ11pj8AcgH0a9FrvU /8k2Roccd2ZIdpNLkirGFZR7LtRw41Kt1Jg+lafI0efkiHKMT/6D/P1EUp1RxOBNtWGV2hrd 0Yg9ds+VMphHHU69fDH02SwgpvXwG8Qm14Zi5WQ66R4CtTkHuYtA63sS17vMl8fDuTCtvfPF HzvdJLIhDYN3Mm1oMjKLlq4PUdYh68Fiwm+boJoBUFGuregJFlO3hM7uHBDhSEnXQr5mqpPM 6R/7Q5BjAxrwVBisH0yQGjsWlnysRWNfExAE2sRePSl0or9q19ddkRYltl6X4FDUXy2DTXa9 a+Fw4e1EvmcF3PjmTYs9IE3Vc64CRQXkhujcN4ZZh5lvOpU8WgyDxFq7bavFnSS6kx7Tk29/ wNJBp+cf9qsQxLbqhW5kfORuZGecus0TLcmpZEFKKjTJBK9gELRBB/zoN3j41hlEl7uTUXTI JQFLhpsFlEdKLujyvT/aCwP3XWT+B2uZDKrMAElF6ltpTxI53JYi22WO7NH7MR16Fhi4R6vh FHNBOkiAhUpoXRZXaCR6+X4qwA8CwHGqHRBfYFSU/Ulq1ZLR+S3hNj2mbnSx0lBs1eEqe2vh cA== Message-ID: Date: Tue, 14 Apr 2020 10:07:12 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v2 1/3] app/testpmd: add profiling flags set command X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 4/13/2020 8:56 AM, Slava Ovsiienko wrote: > Hi, Ferruh > >> -----Original Message----- >> From: Ferruh Yigit >> Sent: Thursday, April 9, 2020 14:56 >> To: Slava Ovsiienko ; dev@dpdk.org >> Cc: Thomas Monjalon ; >> bernard.iremonger@intel.com >> Subject: Re: [PATCH v2 1/3] app/testpmd: add profiling flags set command >> >> On 3/19/2020 1:50 PM, Viacheslav Ovsiienko wrote: >>> This commit is preparation step before adding the separated profiling >>> of Rx and Tx burst routines. The new testpmd command is introduced: >>> >>> set fwdprof (flags) >>> >>> This command controls which profiling statistics is being gathered in >>> runtime: >>> >>> - bit 0 - enables profiling the entire forward routine, counts the ticks >>> spent in the forwarding routine, is set by default. Provides the >>> same data as previous implementation. >>> >>> - bit 1 - enables gathering the profiling data for the transmit datapath, >>> counts the ticks spent within rte_eth_tx_burst() routine, >>> is cleared by default, extends the existing statistics. >>> >>> - bit 2 - enables gathering the profiling data for the receive datapath, >>> counts the ticks spent within rte_eth_rx_burst() routine, >>> is cleared by default, extends the existing statistics. >>> >>> The new counters for the cycles spent into rx/tx burst routines are >>> introduced. The feature is engaged only if >>> CONFIG_RTE_TEST_PMD_RECORD_CORE_CYCLES configured to 'Y'. >> >> Hi Slava, >> >> Thanks for improving the testpmd performance measuring, unfortunately >> these features are not documented at all, unless I miss it, and now you are >> improving it but still there is no documentation. >> >> Would you mind adding a section for performance measures, document how >> to enable and use it, and how to read the output? > > OK, I'll update the documentation either and explain the new extended stats. > >> >>> >>> Signed-off-by: Viacheslav Ovsiienko >> >> <...> >> >>> +#ifdef RTE_TEST_PMD_RECORD_CORE_CYCLES void >>> +set_fwdprof_flags(uint16_t pf_flags) { >>> + printf("Change forward profiling flags from %u to %u\n", >>> + (unsigned int) fwdprof_flags, (unsigned int) pf_flags); >> >> To reduce the 'RTE_TEST_PMD_RECORD_CORE_CYCLES' define usage, what do >> you think have it only in this function, if it is defined work as expected and if >> not print an error and don't update anything? > Agree, it would simplify, going to fix. > >> >> <...> >> >>> @@ -647,6 +647,28 @@ Regexes can also be used for type. To change log >>> level of user1, user2 and user3 >>> >>> testpmd> set log user[1-3] (level) >>> >>> +set fwdprof >>> +~~~~~~~~~~~ >>> + >>> +Set the flags controlling the datapath profiling statistics:: >>> + >>> + testpmd> set fwdprof (flags) >> >> What do you think a little longer command 'fwdprofile", which is more clear I >> think. > Yes, it is clearer, but longer to type 😊 > If you insist on - I will extend, please, let me know your final opinion. In the scope of this patch it may look OK, but if you look all testpmd commands without knowing the code, 'fwdprof' may not be clear what it is. I am for making it more clear. > >> >> And what about having another command to show existing value, right now it >> is 'set' only? > Do you mean it would be good to add "show fwdpro/fwdprofile" ? Yes.