From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 42C1443E43; Thu, 11 Apr 2024 13:38:23 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CBDD74029C; Thu, 11 Apr 2024 13:38:22 +0200 (CEST) Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam04on2042.outbound.protection.outlook.com [40.107.101.42]) by mails.dpdk.org (Postfix) with ESMTP id CD55040268 for ; Thu, 11 Apr 2024 13:38:20 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JiQucECZLNoGhbnVz4j6KjWx6V1eKo/wRXDGLN0cuUyzBeh5eP6FDQBHrDPGaw8473HwDeUxhI4eJdMaLaufk5YT0MFkksrzw2e8dAFaH2agToZy+PQj7OHeZdSC9tGz11stzI764wVvuHL/UK7I0f+6ewamySTG7Np+WdH9Nn0SbObMSqKzplIXvASGMdMSTtddKGhbf7f0k4I9e2/T259A8UqVqf3wrlY50u6HM0r9vSI7MyDnhDUtcsHrwenC8Yv90ZsdecEHF0Uwmj73zc0WqOMmMV+XWeJocEWdP50tzPbAt3pItr0GLJdEmrMu7IZ7AKtu/XN2GGPqaYSbxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZBnSKdszBUVfoqHfC1vI9NTnK1jhVCk88fK4E5hyb5o=; b=m49dkH7p/V+xKz0WZ5lpK4Tif4N2nxQ3acn7JbjN3Zstl48YEgCog/aOm0nWDRhmsUXZejulZWyef9D4pyiF52Rt1WSMcY8f1UnMkNgfTKLgS3xbS+O0ioSb9RmVtqA5L8FHG0MgBt34coHnR6rUHN1dm5AKgmUr6RXlSK9GONA7OjBJsGRY+gk1GJq6986RDQ9CvJlQoWIYaLL0gPz0cB3SmyAQXoQuRrsiy8UbTLQ64SV1zazl/sr2+x+xJj96VhUj//28owthUSGVW69NU3DmKkk3AABtNf3PNYQSmmtoxQ0M/MT03a8SzWDptSTiq8OjOQ5loJxs78B2wzBopg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZBnSKdszBUVfoqHfC1vI9NTnK1jhVCk88fK4E5hyb5o=; b=Eay0AZenPDBinPy9PW+gDgmcDXUIfiuh4xq4fxX2vmlhqXML6T6nYd3YVGU6gRoU9FP1976wkf+C70bPFiwO9G/o+TFgNm/rmYRAr66m6l1OFwgoCXXr883ryQqk0EFaIAYJviCFUz1DhV6iD/RzCCemWSx+FV+hWzp9n+4kKpI= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by MW4PR12MB7335.namprd12.prod.outlook.com (2603:10b6:303:22b::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.46; Thu, 11 Apr 2024 11:38:18 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::282f:29d3:cac1:cde3]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::282f:29d3:cac1:cde3%7]) with mapi id 15.20.7409.053; Thu, 11 Apr 2024 11:38:18 +0000 Message-ID: Date: Thu, 11 Apr 2024 12:38:13 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] net/netvsc: fix number Tx queues > Rx queues To: Alan Elder , Long Li , Andrew Rybchenko Cc: "dev@dpdk.org" , stephen References: Content-Language: en-US From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: CWLP265CA0327.GBRP265.PROD.OUTLOOK.COM (2603:10a6:401:57::27) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|MW4PR12MB7335:EE_ X-MS-Office365-Filtering-Correlation-Id: e50c7c5c-a92b-42b1-5a63-08dc5a1be1f2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +zHCMPWz3NTW6a8RQmTXbtIHZ6WGS5/20rmOjo0iepXxHDl/cSNXouuAIKA0JBN8lE4ddWGYSJDz9UAdEANE/GSbVvIIyFTz9yta8nW3x6U+aCgiz5LD4AoWCvN1t6KridIiCK1SoboolXpbooJv69WciEGYOTUyDIzf6pXMuKj6fXQz5GnKZk/Wvp2VyQrr1wKOCFMZb7h7hijlRzQqsJRX1wSs/C3PCt7fOveiRi3+YlwHSulYgXardsRVh3jpCtwu8paESN4f7PWYDa9y8HoQfngObb3q6lk2wadDi3SQCkR0UHL9A8OtflecVK0GpT50DTyAnPxnXqynD6Y6xfX5VEnx3XvZowO3Gk0KlV7uGIEAs7QaYKxIZwfdn9/S0FUKn8bVhzUTrz9j0iX0gRzX2e6ZlDSL73818XaT6SHNWiMzCtL/CxQX6bZ9Mzv/l4jd4RCHVzW/kOjpRRVLF7caCAfZrx9hO2Q69+wPc0/RuRvHUJMmWm1gQnEaXnwMJQ5DgAI5Cm3Ub0z5VRXkL0lfmqbHPItDDGYii2HhnCI0yOQQwQgBtd8C1QGKkteFq+Ckh0byj+VEDpzWpcw04EZbt+n1jZJbKKY2Nj1r1FSN5lO4d7/NY6dvLVEvsk8NOYm3YrJ5D6MgfIxc66a0VqCzPKsINnoaskG71BgMKdU= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366007)(376005)(1800799015); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bnE4RGNId2JOMFAyTmJYendDSnJOTXJ6SlRtWlVzQlFUd2l3RW9qQk1nellm?= =?utf-8?B?bnFiUERCSFl2TEsxWjFLZDFOdTFEWmVKeVFYcnVsbmFJcnBTVEFiTXJ0ZG85?= =?utf-8?B?V0QyalFnaTRrbEZaKzYxK1NlZjZmY3NncnNWWXdLSk1WOU9YZDhldTBmUWtE?= =?utf-8?B?TVlrb2twcGxpTEFRUUdXS0lLZHVsMzVHMVV5RzJxZHNZT1hHc1dRZ0RxaENT?= =?utf-8?B?V3RIS1pJdjNTcUtWeTgzTTRnZmQvZm5wWFlXVS8za3BUQmh5NzlRdDNFZjFr?= =?utf-8?B?cngyclh1U0UxWCtsZlN5Rm8wTnBReFpHSGkyc1pCZXRPNkFLODRobzRUb3U5?= =?utf-8?B?QVBvWlR6eTMzblpJcWU1T0F2WXg2bWlkN0RXTU9Xazg0M2pERXpuRkZRUEdO?= =?utf-8?B?NjRXZWdpVWxHV2kxU2ZuRzduQ2pwbmtCWTV0M3hnU1RFWHpuOXRmbGdkaVJ3?= =?utf-8?B?RlZ1enFVZEY4YUpIaStPaERjRFF6dEJYNStUVWZ2WEYyZXl0aFN5NmQrNEpl?= =?utf-8?B?Y1pqS3FVS1M5UmFjWGhqOU9tTGUrcHhvVEhoS3ovOFYyVCsyNVhqMWIyV1Vn?= =?utf-8?B?cjlRV2JoT2NUZVNMQy81MDUvS0RaU3ZhL1NoR0lhbDhuR2c1UktrUDVnNkti?= =?utf-8?B?VmpaTWdQaEdldVhJWmpiZTlFVzBWUzNuKytNbUNGM2hlTSswRFBkaDhYT1Fh?= =?utf-8?B?QVNiQmlUOU1RVDE0OXpIUmJFMmZFYzJQaUFjOWVxZ21ENVdsRHNhcHhiYkg0?= =?utf-8?B?dkpPZ1laQlNFbFB5R1NITjB5eFF1UFMrWHpaQVJoOWpaVk1lYlRSWHBGcWdO?= =?utf-8?B?WFBxT2I0Q2ZoZzdxdk5lRG5GOUw0VGVnU2xKdlJXTjFWSVRUM0IxU3J1R0pj?= =?utf-8?B?WjhMSERqVjJWVmpseXNIamwxSmh1THpjM1VXcDVwcmhCWVZoNnArb0pUVHpD?= =?utf-8?B?RVBiM2J5RXdmSmpCY3JjTEp3bG1ocFpEcjY4eG5qTTZQZ3NLS3F4cnB4WGcy?= =?utf-8?B?UllreHhmWG93WkZnTjR2VE5mMStzU1czNTV2eHhSNlI2T1JjUjBZTkxBa0NH?= =?utf-8?B?a1dyRVN4V0JBenBWMjk3WHR3Z3BiSHlpVFdGakJGYUJsMm9lazNld2NkWUxi?= =?utf-8?B?OUphQ2dvZTBUWktWY2JKRWFMNDZRTlZ0eElscDB4UFpteVV5RkVHUVhDZ0Rj?= =?utf-8?B?Qm9rYlVZTGNGRnFiWGZEZ2tQWWJESVR4OHY2WEdSTkFzNTg5SXdMSTRQMzBV?= =?utf-8?B?dmxsaHBJMlpNSVcrY3VNdGFKenFqc3c5OUczVG1GRWtYbzRQcEJJeXAyY3Ru?= =?utf-8?B?OVZMNUVxVHNhMi9BSmVpZFp3MHRvL2h5ckRmclVyMVE1YWpKTCt1WnlOaWc5?= =?utf-8?B?bkRRdC92TXkxcWk1cTBDRTU2Y05oeTAvbXFoaGdNa0lWaXloWm1FZS9HT2pC?= =?utf-8?B?cmFMRnI0U1lURVRwYWRjcnF2eVBQUUE1VTZIZDdJMWpZencxeEJFK1A3QThH?= =?utf-8?B?R2NoR2wxbFMzbHVpK0pXZCtQbDRvTHFyTnBYZXBlalBKZk12cjEvUE1hZlp0?= =?utf-8?B?UU5sRjhLb2lEM1ZacnlrZnFISzRtemlQSWlVMFlMcGNOd0tuaU9zQ0pUbFhP?= =?utf-8?B?azc2Y2pveWRhSHhscjVPNkE0QXh6a1pqcUhRRTdOSlZ3L3phbXhUdkpVTTkv?= =?utf-8?B?alBDYkZuSFVGTTJyNU1zYzAwU2p3WXZMTW55V2xKNmovYWVNVEtKM3VET2hm?= =?utf-8?B?QWNzMjdhVTdMY2h1bDJBKzNVcktwa0twUFo1bTlyYi9PdTJvbnRVd0JVcjRZ?= =?utf-8?B?N2I1cGFjYklJeDZJU2w1UHlOTk8vZ204V2FwSkV4UTJLcTJNNzI5amVGY1p1?= =?utf-8?B?RlZKWFU2NWNFckd0OEIybGdzMHNkT3E4Nk5rOThVcmhuUElUSHpwenl0OFlr?= =?utf-8?B?L0NFbldTaDQ1anQ2bnZMbnhqeUZpakduQ3h2Y0w3TGU1TVNUaUxuSFZvOHlW?= =?utf-8?B?cE8ra3JNWU1jbkRoWFpQOTNNMGdQc3FydDhlUWVwc3BEcUIrYk84Y1UxZnZ1?= =?utf-8?B?bXAycWlUYXo0cStpb0xSamJ0YXRMcndTTDh0NTNoL3dzT2RNdGZxMW12Rm4w?= =?utf-8?Q?NPaLwBZtQzhcFW670OEplor+U?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: e50c7c5c-a92b-42b1-5a63-08dc5a1be1f2 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2024 11:38:18.3992 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: UbxHpoFo9nb/ePyBwbKdGuB6Z+n71M4TtIxL28rFYXAm2LPZB9jeaqd3EfxXFLux X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB7335 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 3/19/2024 2:16 PM, Alan Elder wrote: > The previous code allowed the number of Tx queues to be set higher than > the number of Rx queues. If a packet was sent on a Tx queue with index >> = number Rx queues there was a segfault. > This commit fixes the issue by creating an Rx queue for every Tx queue > meaning that an event buffer is allocated to handle receiving Tx > completion messages. > > mbuf pool and Rx ring are not allocated for these additional Rx queues > and RSS configuration ensures that no packets are received on them. > > Fixes: 4e9c73e96e83 ("net/netvsc: add Hyper-V network device") > Cc: sthemmin@microsoft.com > Cc: stable@dpdk.org > > Signed-off-by: Alan Elder > Hi Alan, What is the root cause of the crash, is it in driver scope or application?