From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id DF2C92C5 for ; Tue, 21 Aug 2018 10:52:22 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Aug 2018 01:52:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,269,1531810800"; d="scan'208";a="66632135" Received: from nikhilr-mobl1.amr.corp.intel.com (HELO [10.106.138.14]) ([10.106.138.14]) by orsmga007.jf.intel.com with ESMTP; 21 Aug 2018 01:52:16 -0700 To: Jerin Jacob Cc: olivier.matz@6wind.com, dev@dpdk.org, nikhil.rao@intel.com References: <1534479652-80182-1-git-send-email-nikhil.rao@intel.com> <1534479652-80182-2-git-send-email-nikhil.rao@intel.com> <20180819104534.GB11085@jerin> From: "Rao, Nikhil" Message-ID: Date: Tue, 21 Aug 2018 14:22:15 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.0 MIME-Version: 1.0 In-Reply-To: <20180819104534.GB11085@jerin> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 2/4] eventdev: add caps API and PMD callbacks for eth Tx adapter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Aug 2018 08:52:23 -0000 On 8/19/2018 4:15 PM, Jerin Jacob wrote: > -----Original Message----- >> Date: Fri, 17 Aug 2018 09:50:50 +0530 >> From: Nikhil Rao >> To: jerin.jacob@caviumnetworks.com, olivier.matz@6wind.com >> CC: dev@dpdk.org, Nikhil Rao >> Subject: [PATCH v2 2/4] eventdev: add caps API and PMD callbacks for eth Tx >> adapter >> X-Mailer: git-send-email 1.8.3.1 >> >> >> The caps API allows the application to query if the transmit >> stage is implemented in the eventdev PMD or uses the common >> rte_service function. The PMD callbacks support the >> eventdev PMD implementation of the adapter. >> >> Signed-off-by: Nikhil Rao >> --- >> + >> static inline int >> rte_event_dev_queue_config(struct rte_eventdev *dev, uint8_t nb_queues) >> { >> @@ -1275,6 +1300,15 @@ int rte_event_dev_selftest(uint8_t dev_id) >> return RTE_EVENT_MAX_DEVS; >> } >> >> @@ -1295,6 +1329,9 @@ struct rte_eventdev * >> >> eventdev = &rte_eventdevs[dev_id]; >> >> + if (eventdev->txa_enqueue == NULL) > > Is this check required, it will be always NULL. Right? if so, > Can't we write eventdev->txa_enqueue directly? > >> + eventdev->txa_enqueue = rte_event_tx_adapter_enqueue; >> + > The thought was that if the PMD supports txa_enqueue then it wouldn't be NULL. Thanks for the review, Nikhil