DPDK patches and discussions
 help / color / mirror / Atom feed
From: Jeff Guo <jia.guo@intel.com>
To: alvinx.zhang@intel.com, dev@dpdk.org
Cc: beilei.xing@intel.com, wenzhuo.lu@intel.com
Subject: Re: [dpdk-dev] [PATCH] net/e1000: fix port hotplug for multi-process
Date: Tue, 12 May 2020 11:03:26 +0800	[thread overview]
Message-ID: <ea409976-9245-6e78-199a-a85ac74bc8d8@intel.com> (raw)
In-Reply-To: <20200429063724.17284-1-alvinx.zhang@intel.com>

hi, alvin


On 4/29/2020 2:37 PM, alvinx.zhang@intel.com wrote:
> From: Alvin Zhang <alvinx.zhang@intel.com>
>
> Enable detach device on secondary process.
>
> Fixes: b9eee2cb8c29 (e1000: support port hotplug)
> Cc: bernard.iremonger@intel.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Alvin Zhang <alvinx.zhang@intel.com>
> ---
>   drivers/net/e1000/em_ethdev.c  | 2 +-
>   drivers/net/e1000/igb_ethdev.c | 4 ++--
>   2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/e1000/em_ethdev.c b/drivers/net/e1000/em_ethdev.c
> index 188cda3..902b1cd 100644
> --- a/drivers/net/e1000/em_ethdev.c
> +++ b/drivers/net/e1000/em_ethdev.c
> @@ -321,7 +321,7 @@ static int eth_em_set_mc_addr_list(struct rte_eth_dev *dev,
>   	PMD_INIT_FUNC_TRACE();
>   
>   	if (rte_eal_process_type() != RTE_PROC_PRIMARY)
> -		return -EPERM;
> +		return 0;
>   


I guess you mean pass through the process of the RTE_PROC_SECONDARY case 
when detach device, but what about the other case like RTE_PROC_INVALID 
or RTE_PROC_AUTO ?


>   	eth_em_close(eth_dev);
>   
> diff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/igb_ethdev.c
> index 520fba8..a5551e8 100644
> --- a/drivers/net/e1000/igb_ethdev.c
> +++ b/drivers/net/e1000/igb_ethdev.c
> @@ -923,7 +923,7 @@ static int igb_flex_filter_uninit(struct rte_eth_dev *eth_dev)
>   	PMD_INIT_FUNC_TRACE();
>   
>   	if (rte_eal_process_type() != RTE_PROC_PRIMARY)
> -		return -EPERM;
> +		return 0;
>   
>   	eth_igb_close(eth_dev);
>   
> @@ -1044,7 +1044,7 @@ static int igb_flex_filter_uninit(struct rte_eth_dev *eth_dev)
>   	PMD_INIT_FUNC_TRACE();
>   
>   	if (rte_eal_process_type() != RTE_PROC_PRIMARY)
> -		return -EPERM;
> +		return 0;
>   
>   	igbvf_dev_close(eth_dev);
>   

  parent reply	other threads:[~2020-05-12  3:03 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-29  6:37 alvinx.zhang
     [not found] ` <b3a05966a7494824abb3e92f83729b32@intel.com>
2020-05-08  3:32   ` Mei, JianweiX
2020-05-12  3:03 ` Jeff Guo [this message]
2020-05-12  3:44   ` Zhang, AlvinX
2020-05-12  4:01     ` Jeff Guo
2020-05-12  5:23 ` Ye Xiaolong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ea409976-9245-6e78-199a-a85ac74bc8d8@intel.com \
    --to=jia.guo@intel.com \
    --cc=alvinx.zhang@intel.com \
    --cc=beilei.xing@intel.com \
    --cc=dev@dpdk.org \
    --cc=wenzhuo.lu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).