From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-f67.google.com (mail-lf1-f67.google.com [209.85.167.67]) by dpdk.org (Postfix) with ESMTP id 89D08326C for ; Wed, 19 Sep 2018 17:14:03 +0200 (CEST) Received: by mail-lf1-f67.google.com with SMTP id q22-v6so5447610lfa.13 for ; Wed, 19 Sep 2018 08:14:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=9iVHeY/Htqc9MUb4eqrb/wuMKlNkMSMaALtTrtBSZZo=; b=L3IToMP9a2V5wAh8LYSSLs9Pjw/mSmdgVFz7I4j+HBZAukHPHOUAFe0hhaQWVrw9Zn Mw3uV7MQ7UsnDVd5sw4cw2zvG+hhPl774HFjFAEHOyvDwOr7mko4Mlf2fJY0XulKlvEF U47EWqat1gBv9O5eBwh8iuIFYdGd7TSsHrbCPRNp3LKtkAla1Szc18y9LTBzrAkwRyyz K3m82gYc8kFhxMYT8M9nT5NNuFLg04COmQEerLyqDvjU5gSJ2OwDb9KL7lWRP/P5gwwT D6hCYMEdb+0cLq1Jp/q3uG9VCNesRlbbzj6fWbvuARYgKE6x5USMKCyXnMl7WCUAt14w VR+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=9iVHeY/Htqc9MUb4eqrb/wuMKlNkMSMaALtTrtBSZZo=; b=MDmle0bT/2Qi2cJHOulgUKWXTjYp2L2OVexb5OWkhycqell+eTQgU+GC5Y/Hpdk33+ wByqO0zPKp1RyrWtFQOhyKyN+S5hmIlb/JmJj911vN8pZtt0FIO2MFjn7QJAA682v8Dq 6huJgznHPkx/DMvCLo4TBOwHpTysRVGbw+upP+KO01bin/Ay94EJ29a+jw9kpOwmfVSI WgY3jnRAVuDcVY0iH6RPBESt/ElcX73FqIhHQHUfExKWD6F6stHPzoMV49ADCz/9L+qB gbBseJPysgqVAPovmycy5892WdFwN6xAuA31L1WUGdJSOFLqzG3N0GCdSW79zejCau+A poZg== X-Gm-Message-State: APzg51AMB1/h8hLmcAUBT9QUEGTQgDnS2bhotffmrdfmI0DHtap6hz+X +N/jifSmwMEJ8ggA7eGdMomXg19ynf0= X-Google-Smtp-Source: ANB0VdafbF/nLmmmBA4YSCjL96QEHMtLCHXL71Z1QCtRnWTNZEcQRFeUzBIYnZMy61nUW/gSmdjvcw== X-Received: by 2002:a19:109e:: with SMTP id 30-v6mr1713656lfq.96.1537370042823; Wed, 19 Sep 2018 08:14:02 -0700 (PDT) Received: from [10.0.0.72] (31-172-191-173.noc.fibertech.net.pl. [31.172.191.173]) by smtp.gmail.com with ESMTPSA id g5-v6sm4051193ljg.54.2018.09.19.08.14.01 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 19 Sep 2018 08:14:01 -0700 (PDT) To: dev@dpdk.org References: <1535718368-15803-1-git-send-email-amo@semihalf.com> <1535720386-18775-1-git-send-email-amo@semihalf.com> <1535720386-18775-2-git-send-email-amo@semihalf.com> <26dc727f-8386-3261-0712-fb3f20566a20@intel.com> From: Andrzej Ostruszka Message-ID: Date: Wed, 19 Sep 2018 17:14:01 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <26dc727f-8386-3261-0712-fb3f20566a20@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 1/8] net/mvneta: add neta PMD skeleton X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Sep 2018 15:14:03 -0000 On 14.09.2018 18:23, Ferruh Yigit wrote: > On 8/31/2018 1:59 PM, Andrzej Ostruszka wrote: [...] > For link status feature "link_update" eth_dev_ops needs to be implemented, > please either implement it or remove feature. (I saw this done later, please > add this on relevant patch) > >> +MTU update = Y > > For mtu update feature "mtu_set" eth_dev_ops needs to be implemented, > please either implement it or remove feature. (I saw this done later, please > add this on relevant patch) > >> +Jumbo frame = Y >> +Promiscuous mode = Y > > Promiscuous mode support is not enabled. (I saw this done later, please add > this on relevant patch) > >> +CRC offload = Y >> +L3 checksum offload = Y >> +L4 checksum offload = Y > > Claiming L3 & L4 cksum offload also requires data path implementation to take > care mbuf.ol_flags flags. (I saw this is done in next patch, please add this > line in next patch) > Also I can see these are presented as capabilities but shouldn't this > information passed to musdk somehow? Are they always enabled? > >> +Packet type parsing = Y > > Similar to above, dev_supported_ptypes_get() is implemented but this also > requires data path implementation that fills mbuf->packet_type. (I saw this is > done in next patch, please add this line in next patch) > >> +Basic stats = Y > > Basic stats collection is not implemented in this patch. (I saw this done > later, please add this on relevant patch) I have moved documentation of features to relevant patches. > There is a limit to number of "iface" in code, does it make sense to document it? I don't think so - there won't be a board supporting more than 4 ports. >> +RTE_PMD_REGISTER_VDEV(net_mvneta, pmd_mvneta_drv); >> +RTE_PMD_REGISTER_ALIAS(net_mvneta, eth_mvneta); > > No need to provide alias for new PMDs Removed. So "eth_XXX" naming is just legacy - I see it in many drivers that they are available both as "net_XXX" and "eth_XXX". Best regards Andrzej