From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5CB3EA0C45; Wed, 22 Sep 2021 14:28:44 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4C07F41198; Wed, 22 Sep 2021 14:28:43 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id 3467541196 for ; Wed, 22 Sep 2021 14:28:42 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1632313721; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5hWAanIm0CHAFMNRLjDdzAnXhxpGPVbnZhzFXIPmZAE=; b=JADDhElK3cZHgSTk9mcWt2sXNVdfX8rWiTDMO1FEUJk5ei5mY8/CFEnMdxMfVGyOWMz3fr 69cVZkvxH7Vs0BtSweOwdkVmr5nLFJ9xIUoiqF4kknugLTkLMPryKzipIE5s3GXsUMVHj5 VFFWinpfGcwItHqH0cnEnDU103pVqIg= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-199-7GW6v8zSMxK9Pnw4qn1pFA-1; Wed, 22 Sep 2021 08:28:40 -0400 X-MC-Unique: 7GW6v8zSMxK9Pnw4qn1pFA-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D84AE1084683; Wed, 22 Sep 2021 12:28:38 +0000 (UTC) Received: from [10.39.208.17] (unknown [10.39.208.17]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BC8076B55D; Wed, 22 Sep 2021 12:28:05 +0000 (UTC) Message-ID: Date: Wed, 22 Sep 2021 14:28:03 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0 To: Andrew Rybchenko , dev@dpdk.org, chenbo.xia@intel.com, amorenoz@redhat.com, david.marchand@redhat.com, ferruh.yigit@intel.com, michaelba@nvidia.com, viacheslavo@nvidia.com, xiaoyun.li@intel.com Cc: stable@dpdk.org, nelio.laranjeiro@6wind.com, yvugenfi@redhat.com, ybendito@redhat.com References: <20210922095742.229262-1-maxime.coquelin@redhat.com> <20210922095742.229262-2-maxime.coquelin@redhat.com> <7238dea1-f48f-26e1-60ce-025853b4dae4@oktetlabs.ru> From: Maxime Coquelin In-Reply-To: <7238dea1-f48f-26e1-60ce-025853b4dae4@oktetlabs.ru> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 1/5] net/virtio: add initial RSS support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/22/21 13:20, Andrew Rybchenko wrote: > On 9/22/21 12:57 PM, Maxime Coquelin wrote: >> Provide the capability to update the hash key, hash types >> and RETA table on the fly (without needing to stop/start >> the device). However, the key length and the number of RETA >> entries are fixed to 40B and 128 entries respectively. This >> is done in order to simplify the design, but may be >> revisited later as the Virtio spec provides this >> flexibility. >> >> Note that only VIRTIO_NET_F_RSS support is implemented, >> VIRTIO_NET_F_HASH_REPORT, which would enable reporting the >> packet RSS hash calculated by the device into mbuf.rss, is >> not yet supported. >> >> Regarding the default RSS configuration, it has been >> chosen to use the default Intel ixgbe key as default key, >> and default RETA is a simple modulo between the hash and >> the number of Rx queues. >> >> Signed-off-by: Maxime Coquelin > > RSS may be configured on rte_eth_dev_configure() stage > using eth_conf->rx_adv_conf.rss_conf. It looks like the > patch does not handle it. > Good catch, I indeed missed that part. I'll post a v3 including its support. Thanks, Maxime