From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 770C84265E; Thu, 28 Sep 2023 11:33:39 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6192440273; Thu, 28 Sep 2023 11:33:39 +0200 (CEST) Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam02on2045.outbound.protection.outlook.com [40.107.212.45]) by mails.dpdk.org (Postfix) with ESMTP id ECA0740273 for ; Thu, 28 Sep 2023 11:33:33 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=f9FS2rhVk71ETejK0S2mzTWK5c5u93QLjIBxBu7Bn+a9Ip3eLYD+dLqNmoXiEJJ69tpHwxt4ySreV1sKtKYNhiLsUNxljOWTh08D5u712SDSkhFFeNPIzkiLBL2X/14F1BiaNK93UjIPZ0fMOKFepiYGuXwG2Tuc6Ye9MbQjCAnuCqlVLoxK5D0PI8J3IZqRXYIHguqH9Xbt9K3L6YBEVloAHvJCd/i6zyIzjp6ivPglcXvoWayi0LD+RIHViodAGXY+Nq7xl9PcoTdUiXUqoNbvvZdms8lRuIYQv98aPamBRPHoV4LWRwXOHftJoNjmt7IbYUZyIJG4bGZzsjIFfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cerT9SzK8tmQ8pk+l0ozlLeoBhZ8zgBuCpOHnCaLFaY=; b=KETb4ELZKL9PU8pfnbygUsgVq/FZ7B5/OuFcA08zT1OlwedI7ycjPM5ENfIXobEAlm91o1SEMhnnU0SKnT4dm3fhYj6xjRxNb1uOwqc6af2X3+RzJ5wuLQf0W2OP4KK26L6gygTDzMUBL55djUkglSmFgCwwIWDeFwuu588EAnrZr1prLShLmWMOFa/n0tdUqS0gKHpdIUHLWoLt/WGPSl+2r95iqZ1XgYFIo3vMo0niiPHNc6FLB4OF8SQXIccz9QuV5+o5UsRKG5plEsmW4B8j1WSjLfq2YhkL0Fd8BqGgUd2BWlF5KpYbDg3CUqdvnfAkq0SxcSYVLVbJj4sczA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cerT9SzK8tmQ8pk+l0ozlLeoBhZ8zgBuCpOHnCaLFaY=; b=VR7XPbDUb7lXZKDgcjWAjcTuXl1GTDQr4ib5fqnsotAiXnBFzSdbv/ABvdQZf/PR4MZmmGWGI8jL/WNCXWYNDzNfv9Bhyvy0IAOv381YURm9jM6UNusYbqZJBT/PJaKAJ9dKG3H+yiT8zw/nZ+M54gNoH8YfhieaAj4Rpu5dVXs= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by CH0PR12MB5106.namprd12.prod.outlook.com (2603:10b6:610:bd::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6838.22; Thu, 28 Sep 2023 09:33:32 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::102f:c69b:d3e5:7fe8]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::102f:c69b:d3e5:7fe8%4]) with mapi id 15.20.6838.024; Thu, 28 Sep 2023 09:33:32 +0000 Message-ID: Date: Thu, 28 Sep 2023 10:33:26 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 00/10] add the support of ipsec offload Content-Language: en-US To: Chaoyong He , "dev@dpdk.org" Cc: oss-drivers References: <20230925060644.1458598-1-chaoyong.he@corigine.com> <20230926024959.207098-1-chaoyong.he@corigine.com> <7911db10-b4d7-4a41-a9dd-0595bb0805ce@amd.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJjb9DJBQkC+3/YAAoJEFRTPtCK Km/6d94P/irGq3mPa7LamXMIioQ8i6ppMSjpr8g+SxH9RnzbmoUjUY6hVzCpXYxEejiJHubg 7lwD+bOocYpiU8Pe0UncVBhIPNk/dIWQAyH0IWK1nd+hOnjxHv3AQpP80Be2o1mUn3oq/b+B QYiyvvre2gIugYq0hzLcG7z4zREeT+Nl0DMDfnLx+Tj2FAOHrOfudUqjdr/VjF5PoTK0bxnb Brqulp0I0ft7hNsufhzf+TlqaB5l0eQO4gDo5xGTP97TT1cGYsXVMsyDhHqW6P3cuj8kkLkO Ch4oq8OLL8GElgRy5y5svU6CJu3f8hT9aiqIoaRpfNv6N8iEk6g4/HNN+uydb9YCA+1pbwBx skmDhtxQrmXpI+Fmfq0aX2NmqHcy6JR8Ekm/nfwLAW/aDpwoMImVN5pPXtOBSjYi4pj7hiJk UA0ZFi8HCW+fic85p8MXn1GPDmbO82Mm3JVJ1uJNAzGsBbW5SP1ol6+XTeaSxcmzFlrDs8vL XQJMRTpcG6Pti7GbbsOtldvmxRQpq9PmCgQg9IrPXpMoaKE3WwtiSiCALs0kYj4F+hhgAfjI RsOuaAJTnKYW31pC/QdroMNAEqIpLveql03jj+xD9ntJIVAsXiCitsLIXzKP0L5tcHkoVLC3 NAjVYq6XkAEssPF4mMRLoEwpvxOytHe1BCJoRl0YA0aQzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmNv0PAFCQL7f/8ACgkQVFM+0Ioqb/oU9hAAisAJJ09j/kiEeA1HGKUg3DyFnYW22zRL z1IHYmcHQanMx4+FAwsb1bonVldQMIYNJ9z69UNIU16zIqLZt3D5QK7Je5F5q4NZgfP2jtjX rc3jyu0PuDerFZQyxNcYhhmlF9JO9NV976WYbBAM3AAr0TDohUk+YicYTKab+ZHYOABXbqHX qi+bzDCH1vKBDfpJviprthhK1tIABUK5lsp9aFwFU2jfu2J3XX3pwQhPMjtn2C4v37XUnOqM SJPr2HLU27IW5I3BBpJn7dZE/BkmDmnceHF8E4tRlXCQ/cf81+eErL832sfhVJo1MpubKh3B j89ZLmw0cDXZP2hqlC9vdXnoWWHI8PDPkiw9z11yLrT9Wd4cTJTjFV49Z9G96rgnOtWDcZ1J xHBAnXYQ7V2k9abY+ZqY1PtAPr/smqzQfPHXyTAhRVZp2f3yQmj7UqB07FJuLQjJ4CGk97Qx ///qeSg7D8x/sGEA8Yp2jgIj6u7tspuz+RgBYrWpfI0VIHhWED0jNXzqztrVX18CzA6r0ReY SG+CSyycKkco6UI9ZeUrXFwnoUJqIJY9wTJo5gD9EgGIbItv3qWTq29dihLYpzd6dqB708k7 4RBz9051oLaFVGkguFw/tXmA17nx+c2uR5jx8wb4j68umG2X++0dSta5eHAVhmtXvrqPW6Ku 3FQ= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P265CA0055.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2af::11) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|CH0PR12MB5106:EE_ X-MS-Office365-Filtering-Correlation-Id: c0ac7d30-ae3d-4bee-4d60-08dbc005fae8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GbtwazDns8/UiG7z3qlLntaIE1MDlCAUFRY1S1/4f1lXipaxgMWEhk5kpyVwh7KZyVS0LwDzC1RbvNO3jsTFgDdyl7Tn5DO2a/17KAbzntch029MUpXqC+G8ktjwVFchvV1Nb7m3Q6ciuPU4n5nMSEEoGFxDGwus+HT53LDofmfK9cuQQv1SLAkrNTwnRF9J+A+tqZtMyzqv9T97eeykJ0/K9idEsTNxRbJrSe4q+tu9HKiCfb7azBCFJ0y+ITsvwelTMqhQM5cyZMIWuwm6m5lkzFhfQOM8xtEhhUupSWJ513mRHKsmR9eH5ldIuF544J3OCXPBlshneECi3uS7r2yMluQEMJ5EJ8CaiIdipMShCiKRw/i/5ThobIA6RmNEO/nnOFn+uhfTWtsJyLTDMskWLe5i46ywsvKbebv1BuZED03pezVEBvdFG2OBvt8Zq0LxqJBDZGDUOJ52ziJLTwXvJeiDGQPBvEzSenEzaQfTeMpbO/x4F5u5lFXzJ7zuzM1RSU7mG1f+HcePBV3PIA/JwsOFBWitQDPTHls/du+tJyur8Vu3uwHfitM4EYsZUuiqmIyepOdRWV0yWRgBX4SwoktVotCXYnmQf1zCNDi1vyr8ozT12yJrMTZeMC9fEIdS6uMOZNY0oYNF5ePMbA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(396003)(366004)(39860400002)(136003)(376002)(346002)(230922051799003)(64100799003)(451199024)(186009)(1800799009)(83380400001)(26005)(2616005)(8676002)(8936002)(44832011)(5660300002)(4326008)(6512007)(53546011)(6506007)(6486002)(31686004)(6666004)(38100700002)(478600001)(86362001)(110136005)(66946007)(66476007)(316002)(41300700001)(66556008)(36756003)(31696002)(2906002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OG5HUk5qUldxS093NWdYRmlGN3lEK2taZno4RXVUc1hMdzloekx3Rk1sR0hv?= =?utf-8?B?RmN6V0JWc3MrVDI0bWVNVExOOEdmVmFpNVY3aEFLVGxGSW1GZHpVR1ZoZGZs?= =?utf-8?B?aTZiU3JjSFZkekdGa2FBTHFXRjl2d1R3UGxJMHVabkJkbjVDdkZERGVzZDJ6?= =?utf-8?B?T1R5eDFnN1h4QmVsd3BHcjlyK3hzQ0YzRUZldklwVUVMMkVGbms1eUFoQ2hT?= =?utf-8?B?VWlrU3QxRzJSdkg5cTBRbmFIc3owMGF5STBxUkZ6SnlrSElKT1pNN0JKMzI3?= =?utf-8?B?VmxRNGRFNWtJb0VGNDI0UmE1cVZOczdZUUJDWkh1eG5pdm1iZjFsVFdpUnhF?= =?utf-8?B?cWQ3eXlPZ1BRVlM5cW1PcWljZzIwcDJ5ZEhOT0hCWlRZQlgvZWZCMU5RYnoy?= =?utf-8?B?L0xNWjZqN3lldTBxa1hPenBxTC9OTmNkbEVveU9qTGdkb0VQeTR3dTd2Zytk?= =?utf-8?B?Vlc5R3RuejBsRFd0RnVTRFhTZXdURzJFTVMvUmw3dU0welV3OVgzdTc5SWJW?= =?utf-8?B?cUxwOUIrdXY1WG4vZ3RIY3ZRWmFsMjBpWmp2ZTk2a0dTb0RLUGN3RThvSUdw?= =?utf-8?B?aUsxYWNTSzBTTzVwNm1GMzhJMis5enhkbnF4c2lacnVRREJPWlZUYTZhaEtz?= =?utf-8?B?TmJ6L2ludSsxNXRRRGwyK1pCZ1J0dm9jdUlwVVdVY1ZzRmQ1eG9HTzV5bXhp?= =?utf-8?B?VmNuSDN6V3lVcEJHM2xrL2hzV3JhZWoxaW9ULzRndzZlZStuTVNLUlRuaCtE?= =?utf-8?B?YlBLWmdNSGFkMzJUc3lLWDV6LzN1VzB3Z3BVRHlydmcvMzFvNEFDR0lVWTJI?= =?utf-8?B?K2ZESXQ4c2xZR1dyd05hZE5QbFJDcXp1QVVYOTFpMUplWXAwZ3FVc2gxdWdM?= =?utf-8?B?aGJCQktrd2h1b2ttMGMyVFVzcmtKUWYrc2VQSXJJdDd3MS95THRwREJVY0NM?= =?utf-8?B?VzE5WDJpWC9BZEdncGxReEtzTVZyUTl2azM2YW54YXZYRFFXRVRMWmlKYlJy?= =?utf-8?B?dUludnk1eUJtZzljaU5OVitGdDA5RTVlaHlDQ01YU3hLVVRRSWxxNmRMSU1R?= =?utf-8?B?YXFWRHdXaks3SjRFNm4yWTJ5VDJYZm9tckIyenZQaUxjdHM5MWRveHpEZzI3?= =?utf-8?B?Q0hUb0ovajMrY3NRVnFvU24ydlNEd0gzdWZEWGMrYUtCbzI1NCtZRzR0OXN4?= =?utf-8?B?M280bVExSHpEOCtLeS9ZaWY5em5wb1dvaXlTblBLSGlqUDRtTXQ1byttU25h?= =?utf-8?B?eDJPeTl0N0Z2clNrNFFvUlJPRE1TbCs0ZUdReEJGc3d2Z0VnRGtaN0FGYkhM?= =?utf-8?B?eVpQdE9yenJMbUlnWEhhSDVlU3I5S0pXME43R1RLNWp3MEhiOXFxZDBDZzJr?= =?utf-8?B?WG1Wd3VOWXg2TWExVWxTYkhHVFpVRXpqYVZpSDlUVlJPdDk1aEMwUW5BOUY2?= =?utf-8?B?RHFBNWZhRVlpNTMxZlA2MUxNUC90d1R6MytZK1pUOGR1SGZEcDlSdDhZNW9y?= =?utf-8?B?WWVJTDJhNUJmWm5qUG5iN2RZQ2hUZW5hVkhJcEFPVWFZUGZUdkxiK0JraTBw?= =?utf-8?B?TmN3NmJHQlNFdmVRSFBFTmloZldKeE5sNVZrR2ZJZ2gxNVdwYXdnZXZEVFd1?= =?utf-8?B?Z2gwT29rbHRocU8vNmZhV2g0RjlyOGFwLzVEWXlhZzA3cXBZNkgrVjdxT09U?= =?utf-8?B?aW9OWkh3aEY1dkxxdnV3a0xEWWR5Q1BtQnY1dEdYMjZwdUNwNWw1L1Iwc1Fx?= =?utf-8?B?K1JkUlpXdW9oOGcrOU1teEQ1aytySFlHTzBodkI0SENGVmNBS0s5T1dlMGZm?= =?utf-8?B?T2RFMTYxREQ4bVVlWFZWdWxYSCt4amJjTGZJcmNLOUlaWmkrWndGVzh0QWpT?= =?utf-8?B?bFdYV2NuTkorcTU2SlJLVlh6cnhlcXlCSGlQSWZGaTdENWY4clVLVlNMK1Y2?= =?utf-8?B?VzRzNTdOWW5wVEhhWHhvMzZza3VOcG1rSnU4QmJvekxlWCttSGRwQTRZeG1x?= =?utf-8?B?WXJiVFQwem5nbDJRck1zTTVGRWdsUkcvWnBZWDBKaTZ5dFZ2V0QwR3VlWjQ1?= =?utf-8?B?MWZtTE1KcE1kMU5Cc2lwUEZFY2xrYjFMQld6ay93ZllkWUsrY0VUc3Nwdkpm?= =?utf-8?Q?/TxNesNaJ5CQ+ua5wDyV1y3Z9?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: c0ac7d30-ae3d-4bee-4d60-08dbc005fae8 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Sep 2023 09:33:32.1350 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 4Yi/hRB7YzHBwXD8nHT3+XXtLc+cgFCwU9yc9DXQN3UY0n+YaQN+nOh5A644ubHm X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB5106 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 9/28/2023 3:05 AM, Chaoyong He wrote: >> On 9/26/2023 3:49 AM, Chaoyong He wrote: >>> This patch series add the support of ipsec offload feature, includes: >>> * Implement the communication channel between PMD and firmware through >>> mailbox. >>> * Implement the ipsec offload related APIs based the security framework. >>> * Implement the ipsec packets process logics in the data path. >>> >>> --- >>> v2: >>> * Fix one spell error cause check warning. >>> * Try to fix one compile error in Alpine environment of CI. >>> --- >>> >>> Chang Miao (2): >>> net/nfp: initialize IPsec related content >>> net/nfp: create security session >>> >>> Shihong Wang (8): >>> mailmap: update contributor entry >>> net/nfp: add TLVs capability parsing >>> net/nfp: add mailbox to support IPsec offload >>> net/nfp: get security capabilities and session size >>> net/nfp: get IPsec Rx/Tx packet statistics >>> net/nfp: update security session >>> net/nfp: support IPsec Rx and Tx offload >>> net/nfp: destroy security session >>> >> >> Hi Chaoyong, >> >> Patchset looks good, but adding ipsec support to driver seems significant enough >> to document in the release notes, what do you think? > > Yeah, I agree. I will try to add that in the next version. > A separate commit for that or squash that into the final commit of this patch series, > which one you think is better? > Squashing to the most relevant commit it better, this creates a link between the documentation and the code which is useful when back tracing a feature in the git history.