From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 49519DE0 for ; Tue, 18 Apr 2017 10:20:45 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 75E8E6AAF4; Tue, 18 Apr 2017 08:20:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 75E8E6AAF4 Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=maxime.coquelin@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 75E8E6AAF4 Received: from [10.36.112.20] (ovpn-112-20.ams2.redhat.com [10.36.112.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BCB224F9A0; Tue, 18 Apr 2017 08:20:43 +0000 (UTC) To: Yuanhan Liu , dev@dpdk.org References: <1492414024-18413-1-git-send-email-yuanhan.liu@linux.intel.com> From: Maxime Coquelin Message-ID: Date: Tue, 18 Apr 2017 10:20:41 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <1492414024-18413-1-git-send-email-yuanhan.liu@linux.intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Tue, 18 Apr 2017 08:20:44 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH] vhost: fix use after free X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Apr 2017 08:20:45 -0000 On 04/17/2017 09:27 AM, Yuanhan Liu wrote: > A "return" is missing on error, which could lead to a "use after free" > issue (about var "conn"). > > Fixes: 65388b43f592 ("vhost: fix fd leaks for vhost-user server mode") > Coverity issue: 143476 > > Reported-by: John McNamara > Signed-off-by: Yuanhan Liu > --- > lib/librte_vhost/socket.c | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Maxime Coquelin Thanks! Maxime