From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B48B8A2F6B for ; Tue, 8 Oct 2019 20:33:07 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9A43B1C0B6; Tue, 8 Oct 2019 20:33:06 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 4315C1C0B5 for ; Tue, 8 Oct 2019 20:33:04 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Oct 2019 11:33:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.67,272,1566889200"; d="scan'208";a="196674832" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.10]) ([10.237.221.10]) by orsmga003.jf.intel.com with ESMTP; 08 Oct 2019 11:33:02 -0700 To: kirankumark@marvell.com, Wenzhuo Lu , Jingjing Wu , Bernard Iremonger , John McNamara , Marko Kovacevic Cc: dev@dpdk.org References: <20190903033928.26123-1-kirankumark@marvell.com> From: Ferruh Yigit Openpgp: preference=signencrypt Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata= mQINBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABtCVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+iQJUBBMBCgA+AhsDAh4BAheABQsJCAcDBRUK CQgLBRYCAwEAFiEE0jZTh0IuwoTjmYHH+TPrQ98TYR8FAl1meboFCQlupOoACgkQ+TPrQ98T YR9ACBAAv2tomhyxY0Tp9Up7mNGLfEdBu/7joB/vIdqMRv63ojkwr9orQq5V16V/25+JEAD0 60cKodBDM6HdUvqLHatS8fooWRueSXHKYwJ3vxyB2tWDyZrLzLI1jxEvunGodoIzUOtum0Ce gPynnfQCelXBja0BwLXJMplM6TY1wXX22ap0ZViC0m714U5U4LQpzjabtFtjT8qOUR6L7hfy YQ72PBuktGb00UR/N5UrR6GqB0x4W41aZBHXfUQnvWIMmmCrRUJX36hOTYBzh+x86ULgg7H2 1499tA4o6rvE13FiGccplBNWCAIroAe/G11rdoN5NBgYVXu++38gTa/MBmIt6zRi6ch15oLA Ln2vHOdqhrgDuxjhMpG2bpNE36DG/V9WWyWdIRlz3NYPCDM/S3anbHlhjStXHOz1uHOnerXM 1jEjcsvmj1vSyYoQMyRcRJmBZLrekvgZeh7nJzbPHxtth8M7AoqiZ/o/BpYU+0xZ+J5/szWZ aYxxmIRu5ejFf+Wn9s5eXNHmyqxBidpCWvcbKYDBnkw2+Y9E5YTpL0mS0dCCOlrO7gca27ux ybtbj84aaW1g0CfIlUnOtHgMCmz6zPXThb+A8H8j3O6qmPoVqT3qnq3Uhy6GOoH8Fdu2Vchh TWiF5yo+pvUagQP6LpslffufSnu+RKAagkj7/RSuZV25Ag0EV9ZMvgEQAKc0Db17xNqtSwEv mfp4tkddwW9XA0tWWKtY4KUdd/jijYqc3fDD54ESYpV8QWj0xK4YM0dLxnDU2IYxjEshSB1T qAatVWz9WtBYvzalsyTqMKP3w34FciuL7orXP4AibPtrHuIXWQOBECcVZTTOdZYGAzaYzxiA ONzF9eTiwIqe9/oaOjTwTLnOarHt16QApTYQSnxDUQljeNvKYt1lZE/gAUUxNLWsYyTT+22/ vU0GDUahsJxs1+f1yEr+OGrFiEAmqrzpF0lCS3f/3HVTU6rS9cK3glVUeaTF4+1SK5ZNO35p iVQCwphmxa+dwTG/DvvHYCtgOZorTJ+OHfvCnSVjsM4kcXGjJPy3JZmUtyL9UxEbYlrffGPQ I3gLXIGD5AN5XdAXFCjjaID/KR1c9RHd7Oaw0Pdcq9UtMLgM1vdX8RlDuMGPrj5sQrRVbgYH fVU/TQCk1C9KhzOwg4Ap2T3tE1umY/DqrXQgsgH71PXFucVjOyHMYXXugLT8YQ0gcBPHy9mZ qw5mgOI5lCl6d4uCcUT0l/OEtPG/rA1lxz8ctdFBVOQOxCvwRG2QCgcJ/UTn5vlivul+cThi 6ERPvjqjblLncQtRg8izj2qgmwQkvfj+h7Ex88bI8iWtu5+I3K3LmNz/UxHBSWEmUnkg4fJl Rr7oItHsZ0ia6wWQ8lQnABEBAAGJAjwEGAEKACYCGwwWIQTSNlOHQi7ChOOZgcf5M+tD3xNh HwUCXWZ5wAUJB3FgggAKCRD5M+tD3xNhH2O+D/9OEz62YuJQLuIuOfL67eFTIB5/1+0j8Tsu o2psca1PUQ61SZJZOMl6VwNxpdvEaolVdrpnSxUF31kPEvR0Igy8HysQ11pj8AcgH0a9FrvU /8k2Roccd2ZIdpNLkirGFZR7LtRw41Kt1Jg+lafI0efkiHKMT/6D/P1EUp1RxOBNtWGV2hrd 0Yg9ds+VMphHHU69fDH02SwgpvXwG8Qm14Zi5WQ66R4CtTkHuYtA63sS17vMl8fDuTCtvfPF HzvdJLIhDYN3Mm1oMjKLlq4PUdYh68Fiwm+boJoBUFGuregJFlO3hM7uHBDhSEnXQr5mqpPM 6R/7Q5BjAxrwVBisH0yQGjsWlnysRWNfExAE2sRePSl0or9q19ddkRYltl6X4FDUXy2DTXa9 a+Fw4e1EvmcF3PjmTYs9IE3Vc64CRQXkhujcN4ZZh5lvOpU8WgyDxFq7bavFnSS6kx7Tk29/ wNJBp+cf9qsQxLbqhW5kfORuZGecus0TLcmpZEFKKjTJBK9gELRBB/zoN3j41hlEl7uTUXTI JQFLhpsFlEdKLujyvT/aCwP3XWT+B2uZDKrMAElF6ltpTxI53JYi22WO7NH7MR16Fhi4R6vh FHNBOkiAhUpoXRZXaCR6+X4qwA8CwHGqHRBfYFSU/Ulq1ZLR+S3hNj2mbnSx0lBs1eEqe2vh cA== Message-ID: Date: Tue, 8 Oct 2019 19:33:01 +0100 MIME-Version: 1.0 In-Reply-To: <20190903033928.26123-1-kirankumark@marvell.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] app/test-pmd: add support for tx and rx desc statu X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/3/2019 4:39 AM, kirankumark@marvell.com wrote: > From: Kiran Kumar K > > Adding support to check TX and RX descriptor status. +1 to the command > > Signed-off-by: Kiran Kumar K > --- > app/test-pmd/cmdline.c | 111 ++++++++++++++++++++ > doc/guides/testpmd_app_ug/testpmd_funcs.rst | 8 ++ > 2 files changed, 119 insertions(+) > > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c > index b6bc34b4d..c22d041c3 100644 > --- a/app/test-pmd/cmdline.c > +++ b/app/test-pmd/cmdline.c > @@ -18728,6 +18728,115 @@ cmdline_parse_inst_t cmd_show_tx_metadata = { > }, > }; > > +/* *** display rx/tx descriptor status *** */ > +struct cmd_show_rx_tx_desc_status_result { > + cmdline_fixed_string_t cmd_show; > + cmdline_fixed_string_t cmd_port; > + cmdline_fixed_string_t cmd_keyword; > + cmdline_fixed_string_t cmd_status; > + portid_t cmd_pid; > + portid_t cmd_qid; > + portid_t cmd_did; > +}; > + > +static void > +cmd_show_rx_tx_desc_status_parsed(void *parsed_result, > + __attribute__((unused)) struct cmdline *cl, > + __attribute__((unused)) void *data) > +{ > + struct cmd_show_rx_tx_desc_status_result *res = parsed_result; > + int rc; > + > + if (!rte_eth_dev_is_valid_port(res->cmd_pid)) { > + printf("invalid port id %u\n", res->cmd_pid); > + return; > + } > + > + if (!strcmp(res->cmd_keyword, "rx")) { > + rc = rte_eth_rx_descriptor_status(res->cmd_pid, res->cmd_qid, > + res->cmd_did); > + if (rc < 0) { > + printf("Invalid queueid = %d\n", res->cmd_qid); > + return; > + } > + if (rc == RTE_ETH_RX_DESC_AVAIL) > + printf("Desc status = AVAILABLE\n"); > + else if (rc == RTE_ETH_RX_DESC_DONE) > + printf("Desc status = DONE\n"); > + else > + printf("Desc status = UNAVAILABLE\n"); > + } else if (!strcmp(res->cmd_keyword, "tx")) { > + rc = rte_eth_tx_descriptor_status(res->cmd_pid, res->cmd_qid, > + res->cmd_did); > + if (rc < 0) { > + printf("Invalid queueid = %d\n", res->cmd_qid); > + return; > + } > + if (rc == RTE_ETH_TX_DESC_FULL) > + printf("Desc status = FULL\n"); > + else if (rc == RTE_ETH_TX_DESC_DONE) > + printf("Desc status = DONE\n"); > + else > + printf("Desc status = UNAVAILABLE\n"); > + } > +} > + > +cmdline_parse_token_string_t cmd_show_rx_tx_desc_status_show = > + TOKEN_STRING_INITIALIZER(struct cmd_show_rx_tx_desc_status_result, > + cmd_show, "show"); > +cmdline_parse_token_string_t cmd_show_rx_tx_desc_status_port = > + TOKEN_STRING_INITIALIZER(struct cmd_show_rx_tx_desc_status_result, > + cmd_port, "port"); > +cmdline_parse_token_num_t cmd_show_rx_tx_desc_status_pid = > + TOKEN_NUM_INITIALIZER(struct cmd_show_rx_tx_desc_status_result, > + cmd_pid, UINT16); > +cmdline_parse_token_string_t cmd_show_rx_desc_status_keyword = > + TOKEN_STRING_INITIALIZER(struct cmd_show_rx_tx_desc_status_result, > + cmd_keyword, "rx"); > +cmdline_parse_token_string_t cmd_show_tx_desc_status_keyword = > + TOKEN_STRING_INITIALIZER(struct cmd_show_rx_tx_desc_status_result, > + cmd_keyword, "tx"); > +cmdline_parse_token_string_t cmd_show_rx_tx_desc_status_status = > + TOKEN_STRING_INITIALIZER(struct cmd_show_rx_tx_desc_status_result, > + cmd_status, "status"); > +cmdline_parse_token_num_t cmd_show_rx_tx_desc_status_qid = > + TOKEN_NUM_INITIALIZER(struct cmd_show_rx_tx_desc_status_result, > + cmd_qid, UINT16); > +cmdline_parse_token_num_t cmd_show_rx_tx_desc_status_did = > + TOKEN_NUM_INITIALIZER(struct cmd_show_rx_tx_desc_status_result, > + cmd_did, UINT16); > +cmdline_parse_inst_t cmd_show_rx_desc_status = { > + .f = cmd_show_rx_tx_desc_status_parsed, > + .data = NULL, > + .help_str = "show port rx status", > + .tokens = { > + (void *)&cmd_show_rx_tx_desc_status_show, > + (void *)&cmd_show_rx_tx_desc_status_port, > + (void *)&cmd_show_rx_tx_desc_status_pid, > + (void *)&cmd_show_rx_desc_status_keyword, > + (void *)&cmd_show_rx_tx_desc_status_qid, > + (void *)&cmd_show_rx_tx_desc_status_did, > + (void *)&cmd_show_rx_tx_desc_status_status, > + NULL, > + }, > +}; > + > +cmdline_parse_inst_t cmd_show_tx_desc_status = { > + .f = cmd_show_rx_tx_desc_status_parsed, > + .data = NULL, > + .help_str = "show port tx status", Please add new command to the help string, in 'cmd_help_long_parsed()' > + .tokens = { > + (void *)&cmd_show_rx_tx_desc_status_show, > + (void *)&cmd_show_rx_tx_desc_status_port, > + (void *)&cmd_show_rx_tx_desc_status_pid, > + (void *)&cmd_show_tx_desc_status_keyword, > + (void *)&cmd_show_rx_tx_desc_status_qid, > + (void *)&cmd_show_rx_tx_desc_status_did, > + (void *)&cmd_show_rx_tx_desc_status_status, > + NULL, > + }, > +}; Instead of creating two 'cmdline_parse_inst_t', you can use 'TOKEN_STRING_INITIALIZER' with '#' to add multiple value, like "rxq#txq", there are multiple sample in testpmd. > + > /* ******************************************************************************** */ > > /* list of instructions */ > @@ -19016,6 +19125,8 @@ cmdline_parse_ctx_t main_ctx[] = { > #endif > (cmdline_parse_inst_t *)&cmd_config_tx_metadata_specific, > (cmdline_parse_inst_t *)&cmd_show_tx_metadata, > + (cmdline_parse_inst_t *)&cmd_show_rx_desc_status, > + (cmdline_parse_inst_t *)&cmd_show_tx_desc_status, > (cmdline_parse_inst_t *)&cmd_set_raw, > NULL, > }; > diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst b/doc/guides/testpmd_app_ug/testpmd_funcs.rst > index 67f4339ca..a708c5ccf 100644 > --- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst > +++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst > @@ -254,6 +254,14 @@ Display information for a given port's RX/TX queue:: > > testpmd> show (rxq|txq) info (port_id) (queue_id) > > +show desc status(rxq|txq) > +~~~~~~~~~~~~~~~~~~~~~~~~~ > + > +Display information for a given port's RX/TX descriptor status:: > + > + testpmd> show port (port_id) (rx|tx) (queue_id) (desc_id) status Better to use 'rxq' or 'txq' for consistency. and some variables has keyword before them, like "port 0", some doesn't like , I think better to add a keyword for 'desc_id', something like 'desc' perhaps. > + > + > show config > ~~~~~~~~~~~ > >