From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B411143215; Fri, 27 Oct 2023 14:39:26 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A4EFF42D45; Fri, 27 Oct 2023 14:39:26 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id E201E402DF for ; Fri, 27 Oct 2023 14:39:08 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1698410349; x=1729946349; h=message-id:date:subject:to:cc:references:from: in-reply-to:mime-version; bh=TcA1koSVdB2tdrxBSC5TWUisrSjORoNSdtZ0ClaOsF8=; b=e0bT4E9rhuNKdE2DSrtqj3CmfvL2XTglPI1GCohxSZ3rmPlMD3soUA5U cdQH47FsYkSCFDh0H5j8zF/jcxptmL/jULwxhECHCRTCv3onwO/vJCNXg e8rbGMmXIqhoHoLjNLJyKknysIS6dQj+VOwaDJkWkvGG3j7PiUvvDuU+0 1iPwXB0O1QfgiuXoVqfw1t8r/HS7Cb8Eu0L6bb3YontedWMz9H8QIiLQM y1WbwvcixQJJ2BjFBUnbi4BwKVygOewWmL+wV7amH0IQ4ObOT9y6ae2qR ncoyH43fx1hBNJMQ+QIZScFgtmzCYIVWrZUQ/6kDFHqR/CT+eBcTFDjKy g==; X-IronPort-AV: E=McAfee;i="6600,9927,10875"; a="387582096" X-IronPort-AV: E=Sophos;i="6.03,256,1694761200"; d="scan'208,217";a="387582096" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Oct 2023 05:38:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10875"; a="903263933" X-IronPort-AV: E=Sophos;i="6.03,256,1694761200"; d="scan'208,217";a="903263933" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga001.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 27 Oct 2023 05:35:34 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Fri, 27 Oct 2023 05:38:02 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Fri, 27 Oct 2023 05:38:02 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34 via Frontend Transport; Fri, 27 Oct 2023 05:38:02 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.100) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.34; Fri, 27 Oct 2023 05:38:01 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NRy5qWqahGkktKfrWOUiiXLqdiuGdJTmtPDzm00x7DdTdMFG0tcnv5sy0uOATmC+RJhonxm8A5lxNLj0H7Q9LxrykKKqK7k8hoL+cazLtcgvcWHYFRkm4OvXpnfqGCz9rccQ/D4QWjG/tryAkREVU1rc/r5xK64qD8Ns6BfsQs8M2xoc5Nyz0juskTVA8Zxm1lcbADvMTWSCW3hsfsljk2j3w1pbHXYHdJB80RwRfgpXHwcqw3xoJupZWlk38V0n78AVBiJEK7NXjz6fduacWetLyz8i6dwLU9h/daazhiCNk9nsvsjJu4Oyuwg1uq2RKIkNk7r2zEy72T1ODMLTDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mKYNs5W+DfKpdX0qiIfwI5lzoepWKr4aC10sAEpxqLY=; b=LXFFgDBRuMYG/xjGVeASg9dCTICe8106U8tX8nOs1CVT3eJYaYSBvsiBuHBEbJqDfMNFwzjm4B/Gj8xbavfdBQQbpnv09IOdKRoYdPXDGkCIdIcQVcqbHflFxtYgKocWpTFjSjxyckXknw3/vRMWMphP8wMUfgIeC9orqdLYdmIbmJA1/L3C3RMFQ7qn7wEhwkpY7H1qw0iHbcoM/mMw4O6x/IWwle3I6OPpf3dRiZGSDjvXo33owUX7LHO16PpRxkUUKZiHS+8P37HdXjKV96n7OJ5lPfXCWjTyCfEsbaUyVfXKrZ4+Wy7NHTscfBC4ePQq/yarM/dHEgbtrSgzhQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from BN8PR11MB3795.namprd11.prod.outlook.com (2603:10b6:408:82::31) by CH3PR11MB8211.namprd11.prod.outlook.com (2603:10b6:610:15f::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.33; Fri, 27 Oct 2023 12:37:59 +0000 Received: from BN8PR11MB3795.namprd11.prod.outlook.com ([fe80::3390:6a69:9f97:acf7]) by BN8PR11MB3795.namprd11.prod.outlook.com ([fe80::3390:6a69:9f97:acf7%6]) with mapi id 15.20.6933.023; Fri, 27 Oct 2023 12:37:58 +0000 Content-Type: multipart/alternative; boundary="------------PSl87xcvSHErV8nvyRs5ta4p" Message-ID: Date: Fri, 27 Oct 2023 13:37:53 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH] examples/l3fwd-power: fix to configure the uncore env Content-Language: en-US To: "Kelly, Karen" , Sivaprasad Tummala , , CC: , , , References: <20231026151959.1458112-1-sivaprasad.tummala@amd.com> <2d53680a-cde3-45cf-b353-81637ec4f7e2@intel.com> From: "Hunt, David" In-Reply-To: <2d53680a-cde3-45cf-b353-81637ec4f7e2@intel.com> X-ClientProxiedBy: DU2PR04CA0343.eurprd04.prod.outlook.com (2603:10a6:10:2b4::29) To BN8PR11MB3795.namprd11.prod.outlook.com (2603:10b6:408:82::31) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8PR11MB3795:EE_|CH3PR11MB8211:EE_ X-MS-Office365-Filtering-Correlation-Id: 4914629a-45fe-42ef-83c7-08dbd6e98d03 X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: kF3p4rlLj/OZ2R79Hkx3C3OxbMxSfJiY01CcvMpeU29ZUgXKRVbNGsfjuMwPlrvo6Zufv8vjz5LTW+p5dVZ52LDjKPCACIbiL3fdnQ3JL6S6H8XZNI9LlNecfIXs6a/XS/oocIfDbCHxTOM9BGpkvqa9qetoBF1sZzd/z0WIWqgSgtImj57loanzqPLovdyf52TrzIsn654+JQm81gO/sECzJolT8VW2RpUE3CM2Xg7KrJfZkGYEj8BNpvYI1PZh14XZTB8l207R+37VQdMn4e8D+p1EpEOLZFdd5bQxXPWc4gZY+G977RkeI9e6KsrBRwzBm/Y7Sux1XHccA7RObjsMEuLcd2OXarQ3kMkgkWotTgAf1Bh2kOY8EWwT7OJo4mTwmLVNdj14tdNWJ5Q95LQ3ZvbFNWeSsfyRMDZJxXCya9Kh1IF4NSDs7zd3r4bVe/IV1SiuTbZXenOM96I2IH4qcpZD/KUCYRNRpLWvDi9Iq9U08YUPhRjjPTjLp6lKwVEh+ZA9AfjcUEMsGqGINwPVOFtmgSdNmsnHXrhEOd9i/p3nLp43uypU5UZN+5eRrL1RpmcmYawCoGjnp0hVCzmSPe35wCcu9XQzvdMxpEtbt7dUGwOP+VCXYabBobDjfj4s7xsNnuW0OGH4P3UNfQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN8PR11MB3795.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(396003)(366004)(136003)(346002)(376002)(39860400002)(230922051799003)(1800799009)(186009)(451199024)(64100799003)(86362001)(2906002)(38100700002)(41300700001)(6506007)(316002)(66556008)(66476007)(66946007)(478600001)(82960400001)(110136005)(6666004)(6512007)(53546011)(6486002)(83380400001)(36756003)(5660300002)(31696002)(2616005)(8676002)(4326008)(8936002)(26005)(33964004)(31686004)(45980500001)(43740500002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dEdocTB3SWhVN1J0Nk5RTms2bXpsRVE2RkpYNTBZM0lzbnJrN2NkMW9KaDFF?= =?utf-8?B?UFhBekJEVDVVLzl1ZVVGSHU5RENncGlSNi8xZEg2d0V4MVNBVER1cFpRVEFz?= =?utf-8?B?WTZEWHpqOWpvUElsMXFhL3VRNnBTbzlQa3NIcXByZGdLYmtoajRRTnkvaDli?= =?utf-8?B?TkFsbjFQdmp1dXNBV2p1aVhEV05iZ0NiS3NjSWRsUUJzdE9Fb3lVbElEV2Z2?= =?utf-8?B?RjRBK2F3M2t3aDBiRzJrZXNodmd1MzZuSVM4aFpiSXgrUEpvNmJLb3dMRDNp?= =?utf-8?B?N0Q1Zys2MlFRUnBzSisxUkNTc0ovd0JEeTRCbHpzUEFvTlVvcFBOb0RHVTlh?= =?utf-8?B?UXdQYTFMVHRrYTVCZFVTTEhLd2lLM1Vzb2d3Z3RYc0pqUjJHb0djQU9xMkFa?= =?utf-8?B?WWZmNnFiZ1ZVU1JueXhnb1g2ZWFtNytsN0dPQ3lBV1hrbUlwcWRLNlZzc0hV?= =?utf-8?B?a093RHM2a0ZSV2FpSkRGYTVGYzlQcWQ5YklJREN3bVUzY2V6S3Y4V3hZaisz?= =?utf-8?B?STlqbzdjOGVGSjl1QU5ZZFgweVlXN1dTUWJDUGJJdDlueGNTTm96N25EWUtR?= =?utf-8?B?Z09kU2Mza0RnL3kwd3czd3FsQmdwbUkzSHZtMHVPMU9yaGtubGltdXZicHZa?= =?utf-8?B?Tm82ZTlTUnlHNDZCSDhHL3dWTDY4NkZtaVZocytBNExRUk9NN21qNzFZK0g4?= =?utf-8?B?UUhsOHFCSXFkanM5YkJ0eG5DUkFWWkRVNGR3bXY2eEdQN0tnaXpCMys1WVBG?= =?utf-8?B?VkVnV2p5RGEvdlVVZFN6L1RIV3hiMzBxV0hUYTdLS1VzTzVKMnZFWFhjT0RK?= =?utf-8?B?NnZYekxuMzhlN0QxQTdwVFJVeEZ1Vmc1NmN4VEw3K3JxVG1vWUR3dW5JMENP?= =?utf-8?B?K3V4TVRtWGxpL0FQeTl1Mlhwek9GaEFMTHR0NE0rWW1iQUpRdTVhMmk3RzlO?= =?utf-8?B?a3VaWUlRdmhHM1lmNEh4eFBseE44bjJabmNOVnVaalhqZE1OZTR1WkNVUnpa?= =?utf-8?B?c2prMTUxTjNNRkU1dGZKYUI3ak1PNzZRZzBEdHJUVWFxL0kyams4em5NWFR4?= =?utf-8?B?bEU5S3RoRm5LMm1NeTV1N3RJWm5VOWdkN0l1bkJrdW9GWUIrL05lMXpwYVhH?= =?utf-8?B?Qy9CM2QzcHYweU1IdXNiajBra2VBR2U2TjJxYnlWTWNYZ0JYb0t5TUFMVHZq?= =?utf-8?B?WUN4VUFoeGNnZ3FkZGhkUC9jckdLU2xjY0JoQllMdUFaM1BVdDJLc2pNckJv?= =?utf-8?B?MVphQ254eWZSTWxUdkxkVTZoRkROK3FzT05nZkVlTU4rbVdxS0dIclgyZmxP?= =?utf-8?B?ajV1ZzBFT2ZLcHdOaEtKSTBEWnRPT0ZVdnZwS1d4Tlgyc2NkWUJoKy9DRmI5?= =?utf-8?B?RWtqVlFvK293TWN3N0lxVWVqMXBPYmNwWGFoV1hMRmM4OFQyZE9vWHpuQ3NP?= =?utf-8?B?WkFXM2ZWWTVvRUtrTythYU54ZGxaQkc1L2tzRCtoWWJvczQxRnNsM01nOVpl?= =?utf-8?B?QWlhNkw1YjRJS0cza001c0Z3b0FWRFovVXNHV2Q3TWlKeE1rZjJmNCtIaVhI?= =?utf-8?B?NHk0TDhVdHlXVnE4ZWFtV1RXNFRWQUxNTmdmU1pZSmhwRHF6TXNTTXZBeUlR?= =?utf-8?B?T1BsV3E2Ukkxbm1BMVBaQ3hDWlNDN0p1QlRJajA2emVBYnlZNjBseVJvYmJv?= =?utf-8?B?K1NIcDhhVkxFK3ZjQ2NLc0hicmM3blU1MnFDZXJpd09remdLSURFeEY0WGdo?= =?utf-8?B?V1dHQ0FmOUFRa0I0UDgzY0x1N04rQXJzZUlSWC9KR1BTVWcreEJOYzNXUDhN?= =?utf-8?B?cXVoU0VrRHkwSGRYY0VPUklZelRSdldRNE5TOThFd1loZWZGd21UUDViRWRJ?= =?utf-8?B?NzJHWVdIZDlBcFBTUStGZ29WNDJFaHkzSmxwZFhoQm5rb1NCSlMxdlRUOGtD?= =?utf-8?B?aENxYkwxdzRJM3B6NFIrOE1TUmE2Q0RpUlk3a3ZkKzBEVzMzVUE3SW5vcVJt?= =?utf-8?B?RmxpTjNCZWVtM2p4Rlg1M1k4Y1JhV0xQZmJyWU5TeEtDbXJUS1FoM0hJMzRS?= =?utf-8?B?Q08yUWVBZGpwak93ZHZHMEtkek56KzNEU3ZCRFd6Z01Xb0RNdUZreG4ybWl4?= =?utf-8?Q?qsk0GyLxJSioFpPqnqPV3m4g1?= X-MS-Exchange-CrossTenant-Network-Message-Id: 4914629a-45fe-42ef-83c7-08dbd6e98d03 X-MS-Exchange-CrossTenant-AuthSource: BN8PR11MB3795.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Oct 2023 12:37:58.6538 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: HKEXqzi+UWdCxECloH4fPCXvqhX7wOX2+TfUl8sqgEt7pAmswzohdqlDhreodhNEX/b+4boAV4c9czaMAkRQMA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB8211 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --------------PSl87xcvSHErV8nvyRs5ta4p Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit Hi Sivaprasad, Karen, On 27/10/2023 13:36, Kelly, Karen wrote: > > > On 26/10/2023 16:19, Sivaprasad Tummala wrote: >> Updated the l3fwd-power app to configure the uncore env before invoking >> any uncore APIs. With auto-detection in 'rte_power_uncore_init()' it is >> too late because other APIs already called. >> >> Bugzilla ID: 1304 >> Fixes: ac1edcb6621a ("power: refactor uncore power management API") >> Cc:karen.kelly@intel.com >> >> Signed-off-by: Sivaprasad Tummala >> --- >> examples/l3fwd-power/main.c | 6 ++++++ >> lib/power/rte_power_uncore.c | 7 +++++++ >> lib/power/rte_power_uncore.h | 9 +++++---- >> 3 files changed, 18 insertions(+), 4 deletions(-) > Ran on my system, bug is resolved after applying this patch. > > Tested-by: Karen Kelly > Acked-by: David Hunt --------------PSl87xcvSHErV8nvyRs5ta4p Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: 7bit

Hi Sivaprasad, Karen,

On 27/10/2023 13:36, Kelly, Karen wrote:


On 26/10/2023 16:19, Sivaprasad Tummala wrote:
Updated the l3fwd-power app to configure the uncore env before invoking
any uncore APIs. With auto-detection in 'rte_power_uncore_init()' it is
too late because other APIs already called.

Bugzilla ID: 1304
Fixes: ac1edcb6621a ("power: refactor uncore power management API")
Cc: karen.kelly@intel.com

Signed-off-by: Sivaprasad Tummala <sivaprasad.tummala@amd.com>
---
 examples/l3fwd-power/main.c  | 6 ++++++
 lib/power/rte_power_uncore.c | 7 +++++++
 lib/power/rte_power_uncore.h | 9 +++++----
 3 files changed, 18 insertions(+), 4 deletions(-)
Ran on my system, bug is resolved after applying this patch.

Tested-by: Karen Kelly <karen.kelly@intel.com>


Acked-by: David Hunt <david.hunt@intel.com>

--------------PSl87xcvSHErV8nvyRs5ta4p--