From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 76DF5A0352; Mon, 7 Feb 2022 18:28:43 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5FB5F410FD; Mon, 7 Feb 2022 18:28:43 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id E886B410F6 for ; Mon, 7 Feb 2022 18:28:40 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644254921; x=1675790921; h=message-id:date:to:cc:references:from:subject: in-reply-to:content-transfer-encoding:mime-version; bh=As9DY6pAC01/KzJURgJA9zBKHTjnp96uB+2yBMjxwQk=; b=M9UPVzaD5PFYccbt7Y38RQjWx+5EKtD2W38y1e/CzmzQbDXi6gL4ogxn rgJ/e+rI6evdvAZnx6M7rM6jVxhSeFM9zvk+I1xm1/aVCUy8QI09wwhId DcI+sruxBaCjG+kyafS37KnZKO2ZvFUIO1Sx5aMn1SNofvelMcQ42H5sH kL7gCbkGoFRxwqGL2sSsaAIRHc0dOYLC4xJ3IFA9Il1tVwynZ7GpCmnjT Og32CpQCISs9dXcUyNKnoK+TKT/+7tv+oaq2Y9D/XKUEo9xA0FHDYZAp3 CNGmcaupoy3Bh5Hx/K79tgCYJp6ZV7YUjoV2aSNlLLm0tHD8R+g3deO15 w==; X-IronPort-AV: E=McAfee;i="6200,9189,10250"; a="228735739" X-IronPort-AV: E=Sophos;i="5.88,350,1635231600"; d="scan'208";a="228735739" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Feb 2022 09:28:40 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,350,1635231600"; d="scan'208";a="540197923" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga008.jf.intel.com with ESMTP; 07 Feb 2022 09:28:39 -0800 Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Mon, 7 Feb 2022 09:28:39 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Mon, 7 Feb 2022 09:28:39 -0800 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.49) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Mon, 7 Feb 2022 09:28:38 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NpP5sWPepzb/RLOdJ4XarsA+GNEn7Nf2vFEg3eYYCKEZYakcHANva4QEME69bmiF5WRJ4Pp9k9glVn7tjqMigRZZTBb4zaSNTFa+tS2jR811k0z6pIJZZQUJ3P6ELQv9rKSrg9jyR4hnV34K4rxjaVW8LIuyLSgHwkhOwq6GXEmQrQJ/x+ck28jK+na5vmvPg+nsD0lzUGselaIYgPvOTSBaqCNaGU8DLCuOd+orI50Vbax7841FGLRZApf3gzTqGDrHyzZaJ6f1Dd2YuY68X1oXQJA8Ucwnd7eqPp9RiijLQoR3ml40WFerDWWPXhZtvEzpUE76HaP2MBVrAMKJjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=g8r5hvaZA0JfVOyGOQ4WHdosh2uh0zKY2shIsUYbwTQ=; b=fd2echVWheuCD2jNRF3q4ggz3GEAtZ6O+ZUGsoIALia17Bse14RRqsGlUxiqrt0DhqZudZDMdxrSfQANcr8Irdac/ToLE7e/ANAcrtiRO1t93ndLQ2+MmTsXvS5BVB/uv+K2Ay14HCv1Rj4BjkpFbk8q5vezS4UfJR8tR2utXpHqix/kflQ5nwJj9qAAbtRPWxJja5rV9G8+VYRYCJyDq4VvnadNZhFblNNMZ33+rvu/8Llq3DTsVuPDpYRMPrLJM3+bjZuM+F+ZNLw+s784AvI3uBuDIKogqBTwggl3TJBJUqW+XC58rBuxdOuduHXNpduDNUl4T3KG+LYIwEKtmQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by BYAPR11MB2661.namprd11.prod.outlook.com (2603:10b6:a02:c5::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.17; Mon, 7 Feb 2022 17:28:32 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::5046:8550:928d:850e]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::5046:8550:928d:850e%7]) with mapi id 15.20.4951.019; Mon, 7 Feb 2022 17:28:32 +0000 Message-ID: Date: Mon, 7 Feb 2022 17:28:26 +0000 Content-Language: en-US To: Stephen Hemminger , Akhil Goyal CC: , , , , , , , , , , , References: <20220130175935.1947730-1-gakhil@marvell.com> <20220204221334.3551574-1-gakhil@marvell.com> <20220204221334.3551574-3-gakhil@marvell.com> <20220207092330.49a0ba8a@hermes.local> From: Ferruh Yigit Subject: Re: [PATCH v4 2/3] ethdev: add mbuf dynfield for incomplete IP reassembly X-User: ferruhy In-Reply-To: <20220207092330.49a0ba8a@hermes.local> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P123CA0052.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1::16) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e8890bb4-ea39-4b69-b207-08d9ea5f435b X-MS-TrafficTypeDiagnostic: BYAPR11MB2661:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4714; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Z+GfRBaE2IzPiF58f+GoxDcHZd3gAj50wd+GkhQsA37WeWWzr8yAJlsDp30e29WysuHaE+aH7aER9vIGScWdvCaLH+bWnmuiZKL45hDAmGTohoiMgYWWIkSx8DOb8JyLPt8zPF5O35a/H0FE01T0Q5UW1N9FbV3ytvqgSxBfzAZoNQIHmMAPfu0UTJsm3MH2CKGN36P4QM3em/l3ipGNXPKgb87YO1izJTBIX+SN2hV6jwXxrDiWhmkqLCmqquq3fDLT+cJtWtHCiieUYYg9Ng5m6h/xAphRk1Ux0jtr3Owfvc5BbbWPtfWtK1nRHE+w1qILidF/PlYIa82z79aySLI0v0YOla+SPBXYpB/DlcS79AyLG8i2H8LK7YuqG553eGqc1DYl3ADf4yo6CjNFdgt48Y5QXQZkHghr4zxrXRYBhrcW1Q/H08tOFQreJWtHW/1NjFeU0OhC9/wDmno5KY+xLP5X8WYAaf8zsKrfZo/RSv+JcjBkfgC0tTqCiCkKLR3Qm3vCZgMhZxsuMWWwrtrtQvOe+erJa63oJelgT2VrL62Oz7BXO00WjQdELtYgLoxrPZ9fkCzgtSMnL9j34k0FedLNZU123ESu6Oz3tIhJ1KBTWBaBokbgIeDAzLNVa5wqrR+FLdEqosgeSdyFwBBhO2WrxCv8fSLDcIu9sywpbPb8pgNUUJvngEnAxGGdkUaVNaq2/8HSCLrjj7OiqA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(55236004)(53546011)(508600001)(8676002)(6506007)(6666004)(6512007)(8936002)(66946007)(36756003)(2616005)(26005)(186003)(66476007)(31686004)(66556008)(86362001)(44832011)(316002)(7416002)(2906002)(6486002)(38100700002)(31696002)(5660300002)(82960400001)(110136005)(4744005)(4326008)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RHFoaTVidy9BVjQ3dnYzanJCKytaVVNZTVUwSjB1YUV4TTBkTGpaeWRVTnlh?= =?utf-8?B?SHVTb2lLTEhTUHFhTjllOGRMQWMyTXUyOGxMSDB2alFONUtCN05rdVpzKzJ2?= =?utf-8?B?WWhRV3A4V3h0dEtxYXZyWDJFRkZZT3dUV1NYMGkvazNFajNQaGJwNy9rMlE0?= =?utf-8?B?UjVXVmRvclRncWJwWDZxUmQwZUN3cWVVOW5EK1J3ckVHZkJMUkd0L2x6UFRI?= =?utf-8?B?eVRLRy84Tis1ZGg3THVmb1U4T2d4alRRN2JBemlncjFQejBxQ3FUMG9XVUpk?= =?utf-8?B?amZnS3ZYUDAxcE9JdExyeGxEbFV4WlE5enl2ZWx3M1p0REViODl0VE5aQzlT?= =?utf-8?B?aVNNTjR4OUNOcGhpY01SbXFmb3VPc1NNWUJPYnVoQkdQYWpRM0I0TjFZVUtt?= =?utf-8?B?dFVNWm13UU5DVXcxRUF6UlRIclhPQ0RRV0FoVzR0YUxzVEo2dG9haDdaTnZE?= =?utf-8?B?cUhVTFM2K2FIakFZZUFLVXprSFBTQTB3Q00xZkVwV0VJYWxZdGtGdC9PaWI1?= =?utf-8?B?US9FRnBoYllIamlXMzVCVE1tUkFEbW5FMWF0aDhZZXh2aWNNelo4TTh1bzlN?= =?utf-8?B?YTZQRGJPc1FZdk9nYUEyRy9aenhRQS9aTUd2TjVRTmJLSThlMEZ1OG53UHVn?= =?utf-8?B?TEZFVzNLcmpSRHVmdTF1TGlvR2RwNHdlTnVMK3NBaU8yY1kyU3lJaTN0Vmoz?= =?utf-8?B?UnpJMjBhWEw1NDBJZ2RDY0M2MzR1a1RoTURaQmJHd2N3cDFvbUxjNS9GRDhF?= =?utf-8?B?aEhSbTZURlBsM2tabmVuVTJ6V0RjYXBsQlEwMWVtOWxiZzRsQ09RL0wra01p?= =?utf-8?B?dUIrRTh6SDY4VzhtTUp0U2hPRmN5NTRSdnVUdVlPdStyT0RncndranpSWEhX?= =?utf-8?B?SDBjVXMzZllyWVZSZHFFMFdCVnh3eHg1OWJkZ0xZS05vTjhnSFAyMHRnTlU3?= =?utf-8?B?YkhyK2tUSjZ4VFA4UFdVNVpMQ2krdFZKOXUweThWOFcrdGhSZEtWWDR6aks5?= =?utf-8?B?WmZicE9ad3lKWmlLazJkRjB5V3VuRmJublNoODFtUGEyanp6djhISWRmK3VO?= =?utf-8?B?WmtVQ0RBRkFFajIyWWRHc096OFd2aUtxcG1PMkJiQUQ4YWM3RFJXVEpYRU5s?= =?utf-8?B?ZzNCTkZPK3B2S2RrdjhtMWkyZWhESnNuL1E3dEUxeVRPSEdoTnd2N1h1RW9C?= =?utf-8?B?emVKV2hET3psYnQ5aEg4K3ZFemNTUG9LYUhZN0FOWHJxNG9xUmtNWXZkRmFj?= =?utf-8?B?ZVBwUG5YcW8rZWVPOTU2bUdhRGpSUERUajg2cHZIVStkSXVLNmRyc2pJSjl0?= =?utf-8?B?RUNYZHZzT0dRSXhrTk56Ry9kRDRUYkNIUnNoNFo1VDBJR2pBV1lpbDNGNERj?= =?utf-8?B?Qk50R09aaWtmdmtZZUpYUFoySHVMMXVmeFVpVm1PMzdReUU1K1dkMExuTDc2?= =?utf-8?B?b2xIWmNZcFhwNDFQUG5FM0xpby9wRFV4L0ZNZ2NVbEhlYnFXZ3ZhWjM2eWZl?= =?utf-8?B?RzFhSU5PQlA2QXdWbnJPMnlob2tjeVdRVTBNSUZ4ZE8zSm9palJ2TXdzRGlK?= =?utf-8?B?RDVDenFFbWFZMU5RdWhKc1R6OHV5QkRaMG5xbFdsNVZ6V1ltZzJFRGFwMHpa?= =?utf-8?B?M0o4MmxjNkdtT1pVRVJLSi9nOEtLMFpubVllYlZFZC94Yit6YnlOTmRYTjJ2?= =?utf-8?B?emZmU04vT2Y4RkZLY2JmTkdkaElFSjc4L1ExK2E4WTdJc1lFbXZLV3VGQjZH?= =?utf-8?B?RVhZWGpCSE9tSTdKcTZlWVZrTzFOcmMyaWZVUDB4WUpzdjVwVXlpc3J3TURC?= =?utf-8?B?RlVudzZnVjRHdlZWOUhsNldja2tuTUEvUkJEWHVKTmY2M2Z3SldlL1VNMERC?= =?utf-8?B?bjlhUmxRTkxwKzJqNUZIMjIrTVZUWHdUbUxYNmx0UERXWVcwajgyem1pQ3c3?= =?utf-8?B?MDhvd3NlRTRSdHBuRTU3MldlVDdvcG4vUENmRnp1elAvTnZ6d1VSYitUUlBj?= =?utf-8?B?OHZnaTgrVFRzSlRTYlExbUFnSHdXaysvTmxZazY4eS8ybTcwZ2tGSHBvYWxs?= =?utf-8?B?MXN5VFFycUZEMTBXZGw2VFR2ejdDbjQwOUU4RVBhN04yYVRNNFRHaWlnMk9O?= =?utf-8?B?elMwcDhyWnRwSCsxdHJxOU5XQzdpL3VTMG84UlNWeUxDZysvNFhhK20rUnA5?= =?utf-8?Q?0HmJIA4Mqqzx5RW/dE7mvd0=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: e8890bb4-ea39-4b69-b207-08d9ea5f435b X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2022 17:28:32.5010 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: q6B5MA7sSpbUsHdfiEZ/L6nQqswpulNbFKmcBFM19MjOaevUF66xKBtaxS24mHn9JCj9u/CMcBiQmq9MXlEnIA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB2661 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/7/2022 5:23 PM, Stephen Hemminger wrote: > On Sat, 5 Feb 2022 03:43:33 +0530 > Akhil Goyal wrote: > >> +/** >> + * @internal >> + * Register mbuf dynamic field and flag for IP reassembly incomplete case. >> + */ >> +__rte_internal >> +int >> +rte_eth_ip_reass_dynfield_register(int *field_offset, int *flag); > > Maybe use RTE_INIT() constructor for this? Dynfiled should be registered only when users asks for the feature.