From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 80758A0524; Tue, 13 Apr 2021 01:55:04 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2DB1A160877; Tue, 13 Apr 2021 01:55:04 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id F16D74067E for ; Tue, 13 Apr 2021 01:55:01 +0200 (CEST) IronPort-SDR: 1UTNNOGr5ROTSWsqIf+tc37QBRhV44XsB/1tZLhwXaJyVG6BLGhNqABpBU26TA2Kasjb9vLE59 FqhAw9o814yg== X-IronPort-AV: E=McAfee;i="6200,9189,9952"; a="279605486" X-IronPort-AV: E=Sophos;i="5.82,216,1613462400"; d="scan'208";a="279605486" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Apr 2021 16:54:59 -0700 IronPort-SDR: uaIY3MYgs/l0ninbcAtE/RWWlarTBzkXP2S1EcZJgX6O3okAfCAJ6+B3ueY35RPzJSDMZBp2Qr 1BQSNJkV9bRA== X-IronPort-AV: E=Sophos;i="5.82,216,1613462400"; d="scan'208";a="398559454" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.218.133]) ([10.213.218.133]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Apr 2021 16:54:56 -0700 To: Li Zhang , dekelp@nvidia.com, orika@nvidia.com, viacheslavo@nvidia.com, matan@nvidia.com, shahafs@nvidia.com, cristian.dumitrescu@intel.com, lironh@marvell.com Cc: dev@dpdk.org, thomas@monjalon.net, rasland@nvidia.com, roniba@nvidia.com References: <20210408035849.1755493-1-lizh@nvidia.com> <20210410072445.1872769-1-lizh@nvidia.com> From: Ferruh Yigit X-User: ferruhy Message-ID: Date: Tue, 13 Apr 2021 00:54:55 +0100 MIME-Version: 1.0 In-Reply-To: <20210410072445.1872769-1-lizh@nvidia.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v3 0/4] Support PPS(packet per second) on meter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 4/10/2021 8:24 AM, Li Zhang wrote: > Currently meter algorithms only supports rate is bytes per second(BPS). > Add packet_mode flag in meter profile parameters data structure. > So that it can meter traffic by packet per second. > > When packet_mode is 0, the profile rates and bucket sizes are > specified in bytes per second and bytes > when packet_mode is not 0, the profile rates and bucket sizes are > specified in packets and packets per second. > > Add the necessary checks to the existing drivers implementing > the rte_mtr API to makes sure that profiles with > packet_mode set to TRUE are rejected. > > RFC ("adds support PPS(packet per second) on meter") > https://patchwork.dpdk.org/project/dpdk/patch/20210125012023.1769769-2-lizh@nvidia.com/ > > Depends-on: series=15998 ("Add ASO meter support in MLX5 PMD") > https://patchwork.dpdk.org/project/dpdk/list/?series=15998 > Above patch is mlx5 patch, but this driver doesn't update mlx5, is above dependency correct? And there is apply errors in the set, that is preventing CI to run on it, can you please rebase on latest master to enable CI? > V2: create a unified patch that contains both the series with > the API changes and the series with the necessary error checks in the drivers. > > V3: Fix comments from Matan and Cristian. > > Li Zhang (4): > ethdev: add packet mode in meter profile structure > app/testpmd: add meter profile packet mode option > net/softnic: check meter packet mode > net/mvpp2: check meter packet mode > > app/test-pmd/cmdline_mtr.c | 40 ++++++++- > doc/guides/rel_notes/release_21_05.rst | 12 +++ > doc/guides/testpmd_app_ug/testpmd_funcs.rst | 31 +++---- > drivers/net/mvpp2/mrvl_mtr.c | 6 ++ > drivers/net/softnic/rte_eth_softnic_meter.c | 8 ++ > lib/librte_ethdev/rte_mtr.h | 90 ++++++++++++++++++--- > 6 files changed, 159 insertions(+), 28 deletions(-) >