From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2180543BDB; Mon, 26 Feb 2024 03:41:25 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DFA31402B2; Mon, 26 Feb 2024 03:41:24 +0100 (CET) Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by mails.dpdk.org (Postfix) with ESMTP id 052E840271 for <dev@dpdk.org>; Mon, 26 Feb 2024 03:41:23 +0100 (CET) Received: from mail.maildlp.com (unknown [172.19.163.174]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4TjlGd4cVszLpKS; Mon, 26 Feb 2024 10:40:41 +0800 (CST) Received: from kwepemd100004.china.huawei.com (unknown [7.221.188.31]) by mail.maildlp.com (Postfix) with ESMTPS id CA2AF1402E2; Mon, 26 Feb 2024 10:41:19 +0800 (CST) Received: from [10.67.121.175] (10.67.121.175) by kwepemd100004.china.huawei.com (7.221.188.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.2.1258.28; Mon, 26 Feb 2024 10:41:19 +0800 Message-ID: <eaff7f54-e192-b0a4-98e5-7ac5d0d99a65@huawei.com> Date: Mon, 26 Feb 2024 10:41:15 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v3 1/7] ethdev: support report register names and filter To: Stephen Hemminger <stephen@networkplumber.org> CC: <dev@dpdk.org>, <lihuisong@huawei.com>, <fengchengwen@huawei.com>, <liuyonglong@huawei.com>, <huangdengdui@huawei.com>, <ferruh.yigit@amd.com> References: <20231214015650.3738578-1-haijie1@huawei.com> <20240220105823.570841-1-haijie1@huawei.com> <20240220105823.570841-2-haijie1@huawei.com> <20240220071315.1fef0848@hermes.local> From: Jie Hai <haijie1@huawei.com> In-Reply-To: <20240220071315.1fef0848@hermes.local> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.121.175] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To kwepemd100004.china.huawei.com (7.221.188.31) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On 2024/2/20 23:13, Stephen Hemminger wrote: > On Tue, 20 Feb 2024 18:58:17 +0800 > Jie Hai <haijie1@huawei.com> wrote: > >> This patch adds "filter" and "names" fields to "rte_dev_reg_info" >> structure. Names of registers in data fields can be reported and >> the registers can be filtered by their names. >> >> The new API rte_eth_dev_get_reg_info_ext() is added to support >> reporting names and filtering by names. And the original API >> rte_eth_dev_get_reg_info() does not use the name and filter fields. >> A local variable is used in rte_eth_dev_get_reg_info for >> compatibility. If the drivers does not report the names, set them >> to "offset_XXX". >> >> Signed-off-by: Jie Hai <haijie1@huawei.com> >> --- >> doc/guides/rel_notes/release_24_03.rst | 9 +++++++ >> lib/ethdev/rte_dev_info.h | 11 ++++++++ >> lib/ethdev/rte_ethdev.c | 36 ++++++++++++++++++++++++++ >> lib/ethdev/rte_ethdev.h | 28 ++++++++++++++++++++ >> lib/ethdev/version.map | 1 + >> 5 files changed, 85 insertions(+) > > Could you add support to DPDK ethtool for displaying these? > . Hi, Stephen, Thanks for your review. The app proc-info and ethtool already support dump registers with the rte_eth_dev_get_reg_info API. For the use of the new API, I think it's better to discuss whether to add or replace the API of the two apps after the API of the new version is applied. Best Regards, Jie Hai