From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F28B7A0C41; Sun, 12 Sep 2021 14:54:52 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7539540041; Sun, 12 Sep 2021 14:54:52 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id E5C324003D for ; Sun, 12 Sep 2021 14:54:50 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1631451290; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Fjae3Cucg+0e64/WkUjC7SFMLMsxk+zqMiNQqCfwqXo=; b=OIX40E4EtNxhAYCsyPldirMX3O5EdRRSxX8JKsh4hL+Dr9zad5w7ym4Gd04AK1v1jMYBDz y+I3ToNqSuu3u/XtwMAC1R1jIF+ZCvFtp8Mxr+nr1vkr88aUTKn0EDaEP8lSY12V8DDJ+V 2A9j7eau0pqNhZgYLAzOa8QoZFsLZzo= Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-246-ovH7E0HvN6-xJHtW7BqRqA-1; Sun, 12 Sep 2021 08:54:49 -0400 X-MC-Unique: ovH7E0HvN6-xJHtW7BqRqA-1 Received: by mail-qk1-f199.google.com with SMTP id h10-20020a05620a284a00b003d30e8c8cb5so38902745qkp.11 for ; Sun, 12 Sep 2021 05:54:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=Fjae3Cucg+0e64/WkUjC7SFMLMsxk+zqMiNQqCfwqXo=; b=WCpFsEV7Ly7dp9d2EPmzgp/Z36sIaov111biEgiIKg3zljFI7HoS9rCTEZt0XsQZE1 0hbXio92fXMulbPlyB73Uf4BZWl3ErI8YNlDWU814d5GObLtCnKrv7bGxVs2r7hKVvu5 4bNb42DX9HxrZWazbxlWC1k7RIKvaEtmWjKY33Nqlyimfepk3oEUt8j+AUA2PSfMtkcq fLT7RjIcGIwFqnWw8SwKgCn5K4YAC7Czia3BFxTg51VD+COo99INoE3SE98mJmk+VfRl bqy00zEOSpXa4h47qBgKvQiG0bDMOCUjNCcTaUEQW1M4bV39rlM3GMy9QovhbjBapCUH 9QIw== X-Gm-Message-State: AOAM532POFg6baGd23onowvKj5Zsu0FSL2amlFbOnF/ZKR4vYykD8Pmj c+1wWIvSyVW6eiqwKEkeiamVRaBJp5bGVMDW52Ntaq7WBsjFsrNZvMqG3BPbNVJ9vhnG6fO1der N5ng= X-Received: by 2002:a0c:80ce:: with SMTP id 72mr5885157qvb.39.1631451288448; Sun, 12 Sep 2021 05:54:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy3U6KR5WpSHCAzxzCaWQgQoPgQE/UJn9VdcHpSQBpJP6rzHD5HxHjaBbGuo5iXyKREwm/iFg== X-Received: by 2002:a0c:80ce:: with SMTP id 72mr5885146qvb.39.1631451288247; Sun, 12 Sep 2021 05:54:48 -0700 (PDT) Received: from localhost.localdomain (075-142-250-213.res.spectrum.com. [75.142.250.213]) by smtp.gmail.com with ESMTPSA id u7sm2522954qtc.75.2021.09.12.05.54.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 12 Sep 2021 05:54:47 -0700 (PDT) To: Nicolas Chautru , dev@dpdk.org, gakhil@marvell.com Cc: thomas@monjalon.net, hemant.agrawal@nxp.com, mingshan.zhang@intel.com, arun.joshi@intel.com References: <1631063741-28631-1-git-send-email-nicolas.chautru@intel.com> <1631063741-28631-7-git-send-email-nicolas.chautru@intel.com> From: Tom Rix Message-ID: Date: Sun, 12 Sep 2021 05:54:45 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <1631063741-28631-7-git-send-email-nicolas.chautru@intel.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=trix@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH v3 6/6] bbdev: reduce warning level for one scenario X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/7/21 6:15 PM, Nicolas Chautru wrote: > Queue setup may genuinely fail when adding incremental queues > for a given priority level. In that case application would > attempt to configure a queue at a different priority level. > Not an actual error. > > Signed-off-by: Nicolas Chautru > --- > lib/bbdev/rte_bbdev.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/lib/bbdev/rte_bbdev.c b/lib/bbdev/rte_bbdev.c > index fc37236..defddcf 100644 > --- a/lib/bbdev/rte_bbdev.c > +++ b/lib/bbdev/rte_bbdev.c > @@ -528,9 +528,10 @@ struct rte_bbdev * > ret = dev->dev_ops->queue_setup(dev, queue_id, (conf != NULL) ? > conf : &dev_info.default_queue_conf); > if (ret < 0) { > - rte_bbdev_log(ERR, > - "Device %u queue %u setup failed", dev_id, > - queue_id); > + /* This may happen when trying different priority levels */ > + rte_bbdev_log(INFO, > + "Device %u queue %u setup failed", > + dev_id, queue_id); This change is just changing the log level, which is fine. I am looking at how the error handling is done for the function. It seems like the bailing is done in the middle of change the queue state. ex/ the block above this one /* Release existing queue ... */ Does this leave the queue in a bad state ? Tom > return ret; > } >