From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id 0F6761B1C6
 for <dev@dpdk.org>; Tue,  9 Jan 2018 16:30:22 +0100 (CET)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga003.fm.intel.com ([10.253.24.29])
 by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
 09 Jan 2018 07:30:21 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.46,336,1511856000"; d="scan'208";a="17866974"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.48])
 ([10.237.220.48])
 by FMSMGA003.fm.intel.com with ESMTP; 09 Jan 2018 07:30:21 -0800
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org
References: <20171219000519.53666-1-ferruh.yigit@intel.com>
 <20180109151229.79325-1-ferruh.yigit@intel.com> <4205065.psd1szYZHI@xps>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <eb165296-fcd4-6f93-4429-dc15799cee19@intel.com>
Date: Tue, 9 Jan 2018 15:30:20 +0000
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.5.2
MIME-Version: 1.0
In-Reply-To: <4205065.psd1szYZHI@xps>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v3] kni: convert license headers to SPDX tags
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 09 Jan 2018 15:30:23 -0000

On 1/9/2018 3:24 PM, Thomas Monjalon wrote:
> 09/01/2018 16:12, Ferruh Yigit:
>> --- a/lib/librte_eal/linuxapp/eal/include/exec-env/rte_kni_common.h
>> +++ b/lib/librte_eal/linuxapp/eal/include/exec-env/rte_kni_common.h
>> +/* SPDX-License-Identifier: (BSD-3-Clause OR LGPL-2.1) */
>> +/*
>> + * Copyright(c) 2007-2014 Intel Corporation.
>>   */
> 
>> --- a/lib/librte_eal/linuxapp/kni/kni_net.c
>> +++ b/lib/librte_eal/linuxapp/kni/kni_net.c
>> +// SPDX-License-Identifier: GPL-2.0
>> +/*
>> + * Copyright(c) 2010-2014 Intel Corporation.
>>   */
> 
> Why these empty lines between SPDX and Copyright?

For kernel module files I followed Linux style, as "//" comments in .c files.
I don't have strong opinion about this...