From: Ferruh Yigit <ferruh.yigit@intel.com>
To: viveksharma@marvell.com, dev@dpdk.org
Cc: intoviveksharma@gmail.com
Subject: Re: [dpdk-dev] [PATCH] app/testpmd: support QinQ offload in VLAN set command
Date: Wed, 9 Oct 2019 13:56:05 +0100 [thread overview]
Message-ID: <eb27d016-1038-276d-8d27-5fbed6e3e6cb@intel.com> (raw)
In-Reply-To: <1568376912-9585-1-git-send-email-viveksharma@marvell.com>
On 9/13/2019 1:15 PM, viveksharma@marvell.com wrote:
> From: Vivek Sharma <viveksharma@marvell.com>
>
> Segregate QinQ from Extend Offload and support QinQ offload
> in vlan set command. Merge all port wise rx vlan offloads in
> command line help and documentation for a cleaner structure.
>
> Signed-off-by: Vivek Sharma <viveksharma@marvell.com>
<...>
> @@ -3902,6 +3895,8 @@ cmd_vlan_offload_parsed(void *parsed_result,
> }
> else if (!strcmp(res->what, "filter"))
> rx_vlan_filter_set(port_id, on);
> + else if (!strcmp(res->what, "qinq"))
Indeed this is enabling QinQ strip, what do you think calling it 'qinq_strip'?
> + rx_vlan_qinq_strip_set(port_id, on);
> else
> vlan_extend_set(port_id, on);
>
> @@ -3916,7 +3911,7 @@ cmdline_parse_token_string_t cmd_vlan_offload_set =
> set, "set");
> cmdline_parse_token_string_t cmd_vlan_offload_what =
> TOKEN_STRING_INITIALIZER(struct cmd_vlan_offload_result,
> - what, "strip#filter#qinq#stripq");
> + what, "strip#filter#qinq#extend#stripq");
> cmdline_parse_token_string_t cmd_vlan_offload_on =
> TOKEN_STRING_INITIALIZER(struct cmd_vlan_offload_result,
> on, "on#off");
> @@ -3927,9 +3922,9 @@ cmdline_parse_token_string_t cmd_vlan_offload_portid =
> cmdline_parse_inst_t cmd_vlan_offload = {
> .f = cmd_vlan_offload_parsed,
> .data = NULL,
> - .help_str = "vlan set strip|filter|qinq|stripq on|off "
> + .help_str = "vlan set strip|filter|qinq|extend|stripq on|off "
"show port info ..." command ('port_infos_display()') displays the vlan offloads
too, can you please add displaying 'qinq' support too.
btw, it displays line by line:
VLAN offload:
strip off
filter on
qinq(extend) off
perhaps we can flatten it, to reduce the info length, what do you think?
VLAN offload:
strip off, filter on, qinq(extend) off, qinq off
next prev parent reply other threads:[~2019-10-09 12:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-13 12:15 viveksharma
2019-09-29 4:28 ` Vivek Kumar Sharma
2019-10-09 12:56 ` Ferruh Yigit [this message]
2019-10-10 7:20 ` Vivek Sharma
2019-10-10 10:24 ` Ferruh Yigit
2019-10-10 10:28 ` Ferruh Yigit
2019-10-10 10:31 ` Vivek Sharma
2019-10-11 4:05 ` [dpdk-dev] [PATCH v2] " viveksharma
2019-10-14 10:40 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eb27d016-1038-276d-8d27-5fbed6e3e6cb@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=intoviveksharma@gmail.com \
--cc=viveksharma@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).