From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B121841DC7; Fri, 3 Mar 2023 13:31:16 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8F2A940687; Fri, 3 Mar 2023 13:31:16 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 1029B400D6 for ; Fri, 3 Mar 2023 13:31:14 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677846674; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CR05wwkSbeu98gm9N84spIDqoR2sEbqylzXSMsCpL5Q=; b=jBVTDmLBnQkFUaIXMXzHFMK0Hez7dcPewEJMn7H2DfgsLWKdrPa8MX3u7/PwgzpiHLYmoG rPeJQ+sKongA7ODWhHnFQFDEz0aRDv3xoqmoezX4BkyQ8g0khliSXlyTYcZSSOeypcxKAZ fNr+9/ChLQdrGCLeklo/VwEc7Y8vHlk= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-470-zel-8qk7MNemFwQALiuEWg-1; Fri, 03 Mar 2023 07:31:10 -0500 X-MC-Unique: zel-8qk7MNemFwQALiuEWg-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 002C488904E; Fri, 3 Mar 2023 12:31:10 +0000 (UTC) Received: from [10.39.208.28] (unknown [10.39.208.28]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C1EF7440D8; Fri, 3 Mar 2023 12:31:08 +0000 (UTC) Message-ID: Date: Fri, 3 Mar 2023 13:31:07 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v3 08/17] test/bbdev: test start/stop bbdev API To: Hernan Vargas , dev@dpdk.org, gakhil@marvell.com, trix@redhat.com Cc: nicolas.chautru@intel.com, qi.z.zhang@intel.com References: <20230302202211.170017-1-hernan.vargas@intel.com> <20230302202211.170017-9-hernan.vargas@intel.com> From: Maxime Coquelin In-Reply-To: <20230302202211.170017-9-hernan.vargas@intel.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 3/2/23 21:22, Hernan Vargas wrote: > Add a call to queue start and queue stop specifically for testing the > bbdev API. > > Signed-off-by: Hernan Vargas > --- > app/test-bbdev/test_bbdev_perf.c | 19 +++++++++++++------ > 1 file changed, 13 insertions(+), 6 deletions(-) > > diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/test_bbdev_perf.c > index 546fc195aac4..7bfc4cd5779e 100644 > --- a/app/test-bbdev/test_bbdev_perf.c > +++ b/app/test-bbdev/test_bbdev_perf.c > @@ -886,19 +886,23 @@ add_bbdev_dev(uint8_t dev_id, struct rte_bbdev_info *info, > "Allocated all queues (id=%u) at prio%u on dev%u\n", > queue_id, qconf.priority, dev_id); > qconf.priority++; > - ret = rte_bbdev_queue_configure(ad->dev_id, queue_id, > - &qconf); > + ret = rte_bbdev_queue_configure(ad->dev_id, queue_id, &qconf); > } > if (ret != 0) { > - printf("All queues on dev %u allocated: %u\n", > - dev_id, queue_id); > + printf("All queues on dev %u allocated: %u\n", dev_id, queue_id); > + break; > + } > + ret = rte_bbdev_queue_start(ad->dev_id, queue_id); > + if (ret != 0) { > + printf("Failed to start queue on dev %u q_id: %u\n", dev_id, queue_id); > break; > } > ad->queue_ids[queue_id] = queue_id; > } > TEST_ASSERT(queue_id != 0, > - "ERROR Failed to configure any queues on dev %u", > - dev_id); > + "ERROR Failed to configure any queues on dev %u\n" > + "\tthe device may not support the related operation capability\n" > + "\tor the device may not have been configured yet", dev_id); > ad->nb_queues = queue_id; > > set_avail_op(ad, op_type); > @@ -3844,6 +3848,9 @@ throughput_pmd_lcore_ldpc_dec(void *arg) > TEST_ASSERT_SUCCESS(ret, "Validation failed!"); > } > > + ret = rte_bbdev_queue_stop(tp->dev_id, queue_id); > + if (ret != 0) > + printf("Failed to stop queue on dev %u q_id: %u\n", tp->dev_id, queue_id); > rte_bbdev_dec_op_free_bulk(ops_enq, num_ops); > > double tb_len_bits = calc_ldpc_dec_TB_size(ref_op); Reviewed-by: Maxime Coquelin Thanks, Maxime