From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Olivier Matz <olivier.matz@6wind.com>,
dev@dpdk.org, Ajit Khaparde <ajit.khaparde@broadcom.com>,
Somnath Kotur <somnath.kotur@broadcom.com>
Cc: stable@dpdk.org
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2] net/bnxt: fix packet type
Date: Thu, 8 Feb 2018 13:30:43 +0000 [thread overview]
Message-ID: <eb48fbe5-527d-29bd-77f0-051015f06916@intel.com> (raw)
In-Reply-To: <20180208082417.22626-1-olivier.matz@6wind.com>
On 2/8/2018 8:24 AM, Olivier Matz wrote:
> The hw flags are not read correctly: the defines
> RX_PKT_CMPL_FLAGS_ITYPE_* are not bits but values, so the should not be
> tested with if (value & X) but with if ((value & MASK) == X).
> This was resulting in a wrong packet type.
>
> For instance, an IPv4/ICMP packet was returning a value of 7 for
> the layer 4, which is undefined.
>
> This patch rework the way packet types are processed, to ensure
> that only valid packet types will be advertised.
>
> Fixes: 3d2a6644eb05 ("net/bnxt: support getting ptypes")
> Cc: stable@dpdk.org
>
> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
> Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
Applied to dpdk-next-net/master, thanks.
prev parent reply other threads:[~2018-02-08 13:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-06 17:07 [dpdk-dev] [PATCH] " Olivier Matz
2018-02-06 23:23 ` Ajit Khaparde
2018-02-07 21:56 ` Olivier Matz
2018-02-08 8:24 ` [dpdk-dev] [PATCH v2] " Olivier Matz
2018-02-08 13:30 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eb48fbe5-527d-29bd-77f0-051015f06916@intel.com \
--to=ferruh.yigit@intel.com \
--cc=ajit.khaparde@broadcom.com \
--cc=dev@dpdk.org \
--cc=olivier.matz@6wind.com \
--cc=somnath.kotur@broadcom.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).